Skip to contentSkip to conversation

rxrpc: Replace fake flex-array with flexible-array member

PATCH Applied David Howells 2 participants 2 messages Apr 21, 2023 – Apr 23, 2023

Subsystems (3)
lore
Share & tools
lore

David Howells

author maintainer
#0 lore raw

PATCH 1/1 rxrpc: Replace fake flex-array with flexible-array member

From: Gustavo A. R. Silva <[email protected]>

Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct rxrpc_ackpacket.

Address the following warnings found with GCC-13 and
-fstrict-flex-arrays=3 enabled:
net/rxrpc/call_event.c:149:38: warning: array subscript i is outside array bounds of ‘uint8_t[0]’ {aka ‘unsigned char[]’} [-Warray-bounds=]

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].

---
 net/rxrpc/protocol.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/rxrpc/protocol.h +1 -1
index 6760cb99c6d6..e8ee4af43ca8 100644
@@ -126,7 +126,7 @@ struct rxrpc_ackpacket {
 	uint8_t		nAcks;		/* number of ACKs */
 #define RXRPC_MAXACKS	255
 
-	uint8_t		acks[0];	/* list of ACK/NAKs */
+	uint8_t		acks[];		/* list of ACK/NAKs */
 #define RXRPC_ACK_TYPE_NACK		0
 #define RXRPC_ACK_TYPE_ACK		1
 
#1 lore raw
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 9 lines · On Fri, 21 Apr 2023 14:08:53 +0100 you wrote:

From: Gustavo A. R. Silva <[email protected]>

Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead.

Transform zero-length array into flexible-array member in struct rxrpc_ackpacket.

[...]

Here is the summary with links:
- [net-next] rxrpc: Replace fake flex-array with flexible-array member

    https://git.kernel.org/netdev/net-next/c/788352191c85

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html