Skip to contentSkip to conversation

clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks

PATCH Applied Mantas Pucka 3 participants 3 messages Apr 25, 2023 – May 25, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks

SDCC clocks must be rounded down to avoid overclocking the controller.

Fixes d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support")

---
v2: remove unnecessary newline in commit message

 drivers/clk/qcom/gcc-ipq6018.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/gcc-ipq6018.c +1 -1
index 3f9c2f61a5d9..5c5d1b04ea7a 100644
@@ -1654,7 +1654,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
 		.name = "sdcc1_apps_clk_src",
 		.parent_data = gcc_xo_gpll0_gpll2_gpll0_out_main_div2,
 		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
 	},
 };
 
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · Mantas Pucka

SDCC clocks must be rounded down to avoid overclocking the controller.

Fixes d9db07f088af ("clk: qcom: Add ipq6018 Global Clock Controller support")

---

Konrad

Quoted 18 lines

v2: remove unnecessary newline in commit message

  drivers/clk/qcom/gcc-ipq6018.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/gcc-ipq6018.c +1 -1
index 3f9c2f61a5d9..5c5d1b04ea7a 100644
@@ -1654,7 +1654,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
  		.name = "sdcc1_apps_clk_src",
  		.parent_data = gcc_xo_gpll0_gpll2_gpll0_out_main_div2,
  		.num_parents = 4,
-		.ops = &clk_rcg2_ops,
+		.ops = &clk_rcg2_floor_ops,
  	},
  };
 
maintainer Applied
#2 lore raw
In reply to Mantas Pucka
Quoted 3 lines · Mantas Pucka

SDCC clocks must be rounded down to avoid overclocking the controller.

Applied, thanks!

[1/1] clk: qcom: gcc-ipq6018: Use floor ops for sdcc clocks

      commit: 56e5ae0116aef87273cf1812d608645b076e4f02

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>