net: atlantic: Define aq_pm_ops conditionally on CONFIG_PM
Subsystems (3)
PATCH 1/1 net: atlantic: Define aq_pm_ops conditionally on CONFIG_PM
For s390, gcc with W=1 reports drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:458:32: error:
'aq_pm_ops' defined but not used [-Werror=unused-const-variable=] 458 | static const struct dev_pm_ops aq_pm_ops = {
| ^~~~~~~~~
The only use of aq_pm_ops is conditional on CONFIG_PM. The definition of aq_pm_ops and its functions should also be conditional on CONFIG_PM.
--- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c +2 -0
@@ -379,6 +379,7 @@ static void aq_pci_shutdown(struct pci_dev *pdev) } } +#ifdef CONFIG_PM static int aq_suspend_common (struct device *dev) {struct aq_nic_s *nic =pci_get_drvdata (to_pci_dev (dev));
@@ -463,6 +464,7 @@ static const struct dev_pm_ops aq_pm_ops = { .restore = aq_pm_resume_restore, .thaw = aq_pm_thaw, }; +#endif static struct pci_driver aq_pci_ops = { .name =AQ_CFG_DRV_NAME ,
Signature · 1 line
2.27.0
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 11 lines · On Fri, 28 Apr 2023 17:43:21 -0400 you wrote:
For s390, gcc with W=1 reports
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:458:32: error:
'aq_pm_ops' defined but not used [-Werror=unused-const-variable=] 458 | static const structdev_pm_opsaq_pm_ops= {
| ^~~~~~~~~The only use of
aq_pm_opsis conditional onCONFIG_PM. The definition ofaq_pm_opsand its functions should also be conditional onCONFIG_PM.[...]
Here is the summary with links:
- net: atlantic: Define aq_pm_ops conditionally on CONFIG_PM
https://git.kernel.org/netdev/net/c/4f163bf82b02
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html