dt-bindings: perf: riscv,pmu: fix property dependencies
Subsystems (3)
PATCH 1/1 dt-bindings: perf: riscv,pmu: fix property dependencies
From: Conor Dooley <[email protected]>
Seemingly I mis-implemented the dependencies here. The OpenSBI docs only point out that the "riscv,event-to-mhpmcounters property is mandatory if riscv,event-to-mhpmevent is present". It never claims that riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
Drop the dependency of riscv,event-to-mhpmcounters on riscv,event-to-mhpmevent.
---
Atish, I'm not 100% on this one but I noticed it while doing dt-validate on a dump of the qemu virt machine which doesn't use the event-to-mhpmevent property.
--- Documentation/devicetree/bindings/perf/riscv,pmu.yaml | 1 - 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/perf/riscv,pmu.yaml +0 -1
@@ -91,7 +91,6 @@ properties: dependencies: "riscv,event-to-mhpmevent": [ "riscv,event-to-mhpmcounters" ] - "riscv,event-to-mhpmcounters": [ "riscv,event-to-mhpmevent" ] required: - compatible
Signature · 7 lines
2.39.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Rob Herring
maintainerQuoted 10 lines · Conor Dooley
From: Conor Dooley <[email protected]>
Seemingly I mis-implemented the dependencies here. The OpenSBI docs only point out that the "riscv,event-to-mhpmcounters property is mandatory if riscv,event-to-mhpmevent is present". It never claims that riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
Drop the dependency of riscv,event-to-mhpmcounters on riscv,event-to-mhpmevent.
Quoted 7 lines
Fixes 7e38085d9c59 ("dt-bindings: riscv: add SBI PMU event mappings")Signed-off-by Conor Dooley <[email protected]>---
Atish, I'm not 100% on this one but I noticed it while doing dt-validate on a dump of the qemu virt machine which doesn't use the event-to-mhpmevent property.
Waiting for comments before I apply this...
Quoted 29 lines
CC Rob Herring <[email protected]>CC Krzysztof Kozlowski <[email protected]>CC Paul Walmsley <[email protected]>CC Palmer Dabbelt <[email protected]>CC Atish Patra <[email protected]>CC Andrew Jones <[email protected]>--- Documentation/devicetree/bindings/perf/riscv,pmu.yaml | 1 - 1 file changed, 1 deletion(-)Documentation/devicetree/bindings/perf/riscv,pmu.yaml +0
-1@@ -91,7 +91,6 @@ properties: dependencies: "riscv,event-to-mhpmevent": [ "riscv,event-to-mhpmcounters" ] - "riscv,event-to-mhpmcounters": [ "riscv,event-to-mhpmevent" ] required: - compatibleSignature · 1 line
2.39.2
Atish Kumar Patra
Reviewed-byQuoted 12 lines · Rob Herring
Quoted 10 lines · Conor Dooley
From: Conor Dooley <[email protected]>
Seemingly I mis-implemented the dependencies here. The OpenSBI docs only point out that the "riscv,event-to-mhpmcounters property is mandatory if riscv,event-to-mhpmevent is present". It never claims that riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
Drop the dependency of riscv,event-to-mhpmcounters on riscv,event-to-mhpmevent.
Quoted 7 lines
Quoted 7 lines
Fixes 7e38085d9c59 ("dt-bindings: riscv: add SBI PMU event mappings")Signed-off-by Conor Dooley <[email protected]>---
Atish, I'm not 100% on this one but I noticed it while doing dt-validate on a dump of the qemu virt machine which doesn't use the event-to-mhpmevent property.
Yes. That's correct. virt machine uses default encoding specified by the SBI PMU spec.
Hence, event-to-mhpmevent is not used.
Quoted 3 lines
Waiting for comments before I apply this...
Sorry for the delay. Not sure why this did not show up in my gmail. Probably due to all the bouncing issues going on.
Quoted 24 lines
Quoted 24 lines
CC Rob Herring <[email protected]>CC Krzysztof Kozlowski <[email protected]>CC Paul Walmsley <[email protected]>CC Palmer Dabbelt <[email protected]>CC Atish Patra <[email protected]>CC Andrew Jones <[email protected]>--- Documentation/devicetree/bindings/perf/riscv,pmu.yaml | 1 - 1 file changed, 1 deletion(-)Documentation/devicetree/bindings/perf/riscv,pmu.yaml +0
-1@@ -91,7 +91,6 @@ properties: dependencies: "riscv,event-to-mhpmevent": [ "riscv,event-to-mhpmcounters" ] - "riscv,event-to-mhpmcounters": [ "riscv,event-to-mhpmevent" ]
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/perf/riscv,pmu.yaml +0
-1required: - compatible --2.39.2
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 27 lines · Conor Dooley
From: Conor Dooley <[email protected]>
Seemingly I mis-implemented the dependencies here. The OpenSBI docs only point out that the "riscv,event-to-mhpmcounters property is mandatory if riscv,event-to-mhpmevent is present". It never claims that riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
Drop the dependency of riscv,event-to-mhpmcounters on riscv,event-to-mhpmevent.
Fixes 7e38085d9c59 ("dt-bindings: riscv: add SBI PMU event mappings")Signed-off-by Conor Dooley <[email protected]>---
Atish, I'm not 100% on this one but I noticed it while doing dt-validate on a dump of the qemu virt machine which doesn't use the event-to-mhpmevent property.
CC Rob Herring <[email protected]>CC Krzysztof Kozlowski <[email protected]>CC Paul Walmsley <[email protected]>CC Palmer Dabbelt <[email protected]>CC Atish Patra <[email protected]>CC Andrew Jones <[email protected]>
Quoted 4 lines
--- Documentation/devicetree/bindings/perf/riscv,pmu.yaml | 1 - 1 file changed, 1 deletion(-)
Applied, thanks!
This patch was applied to riscv/linux.git (fixes) by Rob Herring <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Rob Herring <[email protected]>:
Quoted 8 lines · On Tue, 4 Apr 2023 19:03:22 +0100 you wrote:
From: Conor Dooley <[email protected]>
Seemingly I mis-implemented the dependencies here. The OpenSBI docs only point out that the "riscv,event-to-mhpmcounters property is mandatory if riscv,event-to-mhpmevent is present". It never claims that riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
[...]
Here is the summary with links:
- [v1] dt-bindings: perf: riscv,pmu: fix property dependencies
https://git.kernel.org/riscv/c/4d276e4d3bb4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html