bpf: drop unnecessary user-triggerable WARN_ONCE in verifierl log
Andrii Nakryiko
maintainerPATCH 1/1 bpf: drop unnecessary user-triggerable WARN_ONCE in verifierl log
It's trivial for user to trigger "verifier log line truncated" warning, as verifier has a fixed-sized buffer of 1024 bytes (as of now), and there are at least two pieces of user-provided information that can be output through this buffer, and both can be arbitrarily sized by user:
- BTF names;
- BTF.ext source code lines strings.
Verifier log buffer should be properly sized for typical verifier state output. But it's sort-of expected that this buffer won't be long enough in some circumstances. So let's drop the check. In any case code will work correctly, at worst truncating a part of a single line output.
--- kernel/bpf/log.c | 3 --- 1 file changed, 3 deletions(-)
kernel/bpf/log.c +0 -3
@@ -62,9 +62,6 @@ void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt, n =vscnprintf (log->kbuf,BPF_VERIFIER_TMP_LOG_SIZE , fmt, args); -WARN_ONCE (n >=BPF_VERIFIER_TMP_LOG_SIZE -1 , -"verifier log line truncated - local buffer too short\n" ); -if (log->level ==BPF_LOG_KERNEL ) {bool newline = n >0 && log->kbuf[n -1 ] =='\n' ;
Signature · 1 line
2.34.1
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 8 lines · On Tue, 16 May 2023 11:04:09 -0700 you wrote:
It's trivial for user to trigger "verifier log line truncated" warning, as verifier has a fixed-sized buffer of 1024 bytes (as of now), and there are at least two pieces of user-provided information that can be output through this buffer, and both can be arbitrarily sized by user:
- BTF names;
- BTF.ext source code lines strings.[...]
Here is the summary with links:
- [bpf-next] bpf: drop unnecessary user-triggerable WARN_ONCE in verifierl log
https://git.kernel.org/bpf/bpf-next/c/cff36398bd4c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html