drm/tilcdc: Add bridge support and sync-lost flood recovery

drivers/gpu/drm/bridge/ti-tfp410.c new file +9 -0

+	if (!bridge->encoder) {
+		dev_err(dvi->dev, "Missing encoder\n");
+		return -ENODEV;
+	}
+
+	drm_connector_helper_add(&dvi->connector,
+				 &tfp410_con_helper_funcs);
+	ret = drm_connector_init(bridge->dev, &dvi->connector,
+				 &tfp410_con_funcs, DRM_MODE_CONNECTOR_HDMIA);

The module unload should not be allowed while the bridge is attached. So still need to add these:

Quoted 6 lines · Jyri Sarha

drivers/gpu/drm/bridge/ti-tfp410.c new file +6 -0

+
+static int tfp410_attach(struct drm_bridge *bridge)
+{
+	struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
+	int ret;
+

Quoted 19 lines

drivers/gpu/drm/bridge/ti-tfp410.c new file +19 -0

+	if (!bridge->encoder) {
+		dev_err(dvi->dev, "Missing encoder\n");
+		return -ENODEV;
+	}
+
+	drm_connector_helper_add(&dvi->connector,
+				 &tfp410_con_helper_funcs);
+	ret = drm_connector_init(bridge->dev, &dvi->connector,
+				 &tfp410_con_funcs, DRM_MODE_CONNECTOR_HDMIA);
+	if (ret) {
+		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
+		return ret;
+	}
+
+	drm_mode_connector_attach_encoder(&dvi->connector,
+					  bridge->encoder);
+
+	return 0;
+}

drivers/gpu/drm/bridge/ti-tfp410.c new file +5 -0

+static void tfp410_detach(struct drm_bridge *bridge)
+{
+       module_put(THIS_MODULE);
+}
+

drivers/gpu/drm/bridge/ti-tfp410.c line 125

Quoted 4 lines

drivers/gpu/drm/bridge/ti-tfp410.c new file +3 -0

+
+static const struct drm_bridge_funcs tfp410_bridge_funcs = {
+	.attach		= tfp410_attach,

+ .detach = tfp410_detach,

Quoted 2 lines

(quoted diff) +2 -0

+};
+

Hi Jyri,

Quoted 4 lines · On Tuesday 29 Nov 2016 22:18:25 Jyri Sarha wrote:

Quoted 4 lines

The module unload should not be allowed while the bridge is attached. So still need to add these:

On 11/25/16 11:02, Jyri Sarha wrote:

Quoted 12 lines

drivers/gpu/drm/bridge/ti-tfp410.c line 108

Quoted 12 lines

Quoted 6 lines

Quoted 6 lines

drivers/gpu/drm/bridge/ti-tfp410.c new file +6 -0

+
+static int tfp410_attach(struct drm_bridge *bridge)
+{
+	struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
+	int ret;
+

drivers/gpu/drm/bridge/ti-tfp410.c new file +5 -0

+       if (!try_module_get(THIS_MODULE)) {
+               dev_err(dvi->dev, "Module unloading\n");
+               return -ENODEV;
+       }
+

Shouldn't this be done in core code ?

drivers/gpu/drm/tilcdc/tilcdc_external.c +1 -3

-void tilcdc_remove_external_encoders(struct drm_device *dev)
+void tilcdc_remove_external_device(struct drm_device *dev)
 {
 	struct tilcdc_drm_private *priv = dev->dev_private;
-	int i;
 
 	/* Restore the original helper functions, if any. */
-	for (i = 0; i < priv->num_connectors; i++)

+}

Quoted 8 lines · Jyri Sarha

drivers/gpu/drm/tilcdc/tilcdc_external.c +1 -3

-void tilcdc_remove_external_encoders(struct drm_device *dev)
+void tilcdc_remove_external_device(struct drm_device *dev)
 {
 	struct tilcdc_drm_private *priv = dev->dev_private;
-	int i;
 
 	/* Restore the original helper functions, if any. */
-	for (i = 0; i < priv->num_connectors; i++)

drivers/gpu/drm/tilcdc/tilcdc_external.c static int tilcdc_add_external_encoder(struct drm_device *dev, · line 155

Quoted 10 lines

drivers/gpu/drm/tilcdc/tilcdc_external.c +5 -5

-		if (IS_ERR(priv->connector_funcs[i]))
-			drm_connector_helper_add(priv->connectors[i], NULL);
-		else if (priv->connector_funcs[i])
-			drm_connector_helper_add(priv->connectors[i],
-						 priv->connector_funcs[i]);
+	if (IS_ERR(priv->connector_funcs))
+		drm_connector_helper_add(priv->external_connector, NULL);
+	else if (priv->connector_funcs)
+		drm_connector_helper_add(priv->external_connector,
+					 priv->connector_funcs);

I still need to add:

Quoted 1 line

+}

... and reorder the tilcdc_fini() a bit. I need to put tilcdc_remove_external_device() before drm_mode_config_cleanup() for drm_bridge_detach() to be called before whole mode config is teared apart.

There is also a bug in tearing down drm debugfs that had to be fixed before I got module unload and reload to work properly. I'll send a patch shortly.

Changes since v4:
- "drm/bridge: Add ti-tfp410 DVI transmitter driver"
- Put i2c behind #if IS_ENABLED(CONFIG_I2C)
- "drm/tilcdc: Add drm bridge support for attaching drm bridge drivers"
- Use exsisting infrastructure to hookup crtc mode validation code to newly connected connector, whether that came from componentized driver or trough an attached bridge

Changes since v3:
- "drm/tilcdc: Enable sync lost error and recovery handling for rev 1 LCDC"
- Fix broken irq enable/disble code for LCDC rev 1
- Add: "dt-bindings: Move "ti,tfp410.txt" from display/ti to display/bridge"
- "drm/bridge: Add ti-tfp410 DVI transmitter driver"
- Don't fail if either i2c or platform driver register succeeds
- ftp410 -> tfp410
- Merge the old display/ti,tfp410.txt document with my addition

Changes since v2:
- "drm/tilcdc: Recover from sync lost error flood by resetting the LCDC"
- no change
- "drm/bridge: Add ti-tfp410 DVI transmitter driver"
- Fix deveice-tree document
- "driver node" -> "device node"
- remove "(the current implementation does not yet support this)"
- Add dummy i2c support. The driver probe works also if placed under i2c controller node, but there is no actual i2c probing.
- "drm/tilcdc: Add drm bridge support for attaching drm bridge drivers"
- no change

Changes since first version of the series:
- "drm/tilcdc: Recover from sync lost error flood by resetting the LCDC"
- no change
- "drm/bridge: Add ti-tfp410 DVI transmitter driver"
- HDMI -> DVI
- DT Binding document
- Prepare for tfp410 connected trough i2c by optional reg property
- Require two port nodes
- Implementation
- Implement connector node functionality with in tfp410 bridge drive, but follow generic connector binding by pulling the ddc-i2c-bus property from the connector node.
- "drm/tilcdc: Add drm bridge support for attaching drm bridge drivers"
- Remove earlier change in TD binding document. There is no need to mention DRM implementation details, like bridge support, in DT binding.

The first patch is an independent on and I've been testing it for quite a while now.

The tfp410 bridge driver and the tilcdc bridge support are tested with BeagleBone DVI-D Cape Rev A3. The tfp410 bridge driver is missing a lot of features, because the DVI-D cape does not have too many wires connected. The missing features can be added later when they are needed.

Jyri Sarha (4):
drm/tilcdc: Recover from sync lost error flood by resetting the LCDC
dt-bindings: Move "ti,tfp410.txt" from display/ti to display/bridge drm/bridge: Add ti-tfp410 DVI transmitter driver drm/tilcdc: Add drm bridge support for attaching drm bridge drivers

 .../bindings/display/{ti => bridge}/ti,tfp410.txt  |   9 +-
 drivers/gpu/drm/bridge/Kconfig                     |   7 +
 drivers/gpu/drm/bridge/Makefile                    |   1 +
 drivers/gpu/drm/bridge/ti-tfp410.c                 | 317 +++++++++++++++++++++
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               |  26 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  11 +-
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |   5 +-
 drivers/gpu/drm/tilcdc/tilcdc_external.c           | 260 ++++++++++++-----
 drivers/gpu/drm/tilcdc/tilcdc_external.h           |   5 +-
 9 files changed, 564 insertions(+), 77 deletions(-)
 rename Documentation/devicetree/bindings/display/{ti => bridge}/ti,tfp410.txt (65%)
 create mode 100644 drivers/gpu/drm/bridge/ti-tfp410.c

--
1.9.1