net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
Subsystems (3)
PATCH 1/1 net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
From: Arnd Bergmann <[email protected]>
Without LED triggers, the driver now fails to build:
drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds':drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'struct led_classdev' has no member named 'hw_control_is_supported'
403 | port_led->cdev.hw_control_is_supported = qca8k_cled_hw_control_is_supported;
| ^
There is a mix of 'depends on' and 'select' for LEDS_TRIGGERS, so it's not clear what we should use here, but in general using 'depends on' causes fewer problems, so use that.
--- drivers/net/dsa/qca/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/dsa/qca/Kconfig +1 -0
@@ -20,6 +20,7 @@ config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K + depends on LEDS_TRIGGERS help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips.
Signature · 1 line
2.39.2
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 10 lines · On Thu, 1 Jun 2023 23:31:04 +0200 you wrote:
From: Arnd Bergmann <[email protected]>
Without LED triggers, the driver now fails to build:
drivers/net/dsa/qca/qca8k-leds.c: In function 'qca8k_parse_port_leds':drivers/net/dsa/qca/qca8k-leds.c:403:31: error: 'structled_classdev' has no member named 'hw_control_is_supported'
403 |port_led->cdev.hw_control_is_supported=qca8k_cled_hw_control_is_supported;
| ^[...]
Here is the summary with links:
- net: dsa: qca8k: add CONFIG_LEDS_TRIGGERS dependency
https://git.kernel.org/netdev/net/c/37a826d86ff7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html