Skip to contentSkip to conversation

net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

PATCH Applied Min-Hua Chen 3 participants 3 messages Jun 2, 2023 – Jun 4, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

This patch fixes the following sparse warning:

net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?

No functional change intended.

---
 net/sched/sch_api.c | 2 ++
 1 file changed, 2 insertions(+)
net/sched/sch_api.c +2 -0
index 014209b1dd58..9ea51812b9cf 100644
@@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
 	.exit = psched_net_exit,
 };
 
+#if IS_ENABLED(CONFIG_RETPOLINE)
 DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
+#endif
 
 static int __init pktsched_init(void)
 {
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Min-Hua Chen

This patch fixes the following sparse warning:

net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?

No functional change intended.

LGTM,

Quoted 18 lines
---
  net/sched/sch_api.c | 2 ++
  1 file changed, 2 insertions(+)
net/sched/sch_api.c +2 -0
index 014209b1dd58..9ea51812b9cf 100644
@@ -2302,7 +2302,9 @@ static struct pernet_operations psched_net_ops = {
  	.exit = psched_net_exit,
  };
 
+#if IS_ENABLED(CONFIG_RETPOLINE)
  DEFINE_STATIC_KEY_FALSE(tc_skip_wrapper);
+#endif
 
  static int __init pktsched_init(void)
  {
#2 lore raw
In reply to Min-Hua Chen
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 9 lines · On Sat, 3 Jun 2023 07:52:09 +0800 you wrote:

This patch fixes the following sparse warning:

net/sched/sch_api.c:2305:1: sparse: warning: symbol 'tc_skip_wrapper' was not declared. Should it be static?

No functional change intended.

[...]

Here is the summary with links:
- net: sched: wrap tc_skip_wrapper with CONFIG_RETPOLINE

    https://git.kernel.org/netdev/net/c/8cde87b007da

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html