Skip to contentSkip to conversation

net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition

PATCH Applied Lukas Bulwahn 4 participants 4 messages Jun 5, 2023 – Jun 6, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition

Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0 ("net/pppoe: make number of hash bits configurable") actually defined config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick typo with the numbers.

Fix the typo and define PPPOE_HASH_BITS_1.

Fixes 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
---
 drivers/net/ppp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ppp/Kconfig +1 -1
index 2fbcae31fc02..8c9ed1889d1a 100644
@@ -141,7 +141,7 @@ choice
 
 		This hash table is on a per outer ethernet interface.
 
-config PPPOE_HASH_BITS_2
+config PPPOE_HASH_BITS_1
 	bool "1 bit (2 buckets)"
 
 config PPPOE_HASH_BITS_2
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Lukas Bulwahn

Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0 ("net/pppoe: make number of hash bits configurable") actually defined config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick typo with the numbers.

Fix the typo and define PPPOE_HASH_BITS_1.

Fixes 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
Reviewed-by
#2 lore raw
Quoted 6 lines · Simon Horman
Quoted 5 lines · Lukas Bulwahn

Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0 ("net/pppoe: make number of hash bits configurable") actually defined config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick typo with the numbers.

Quoted 6 lines
Quoted 4 lines

Fix the typo and define PPPOE_HASH_BITS_1.

Fixes 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")

Sorry about that, that was indeed blonde.  Thanks for the fixup.

Kind Regards,
Jaco

#3 lore raw
In reply to Lukas Bulwahn
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Mon, 5 Jun 2023 09:27:43 +0200 you wrote:

Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0 ("net/pppoe: make number of hash bits configurable") actually defined config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick typo with the numbers.

Fix the typo and define PPPOE_HASH_BITS_1.

[...]

Here is the summary with links:
- net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition

    https://git.kernel.org/netdev/net-next/c/ae91f7e436f8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html