scsi: storvsc: Always set no_report_opcodes
Subsystems (3)
PATCH 1/1 scsi: storvsc: Always set no_report_opcodes
Hyper-V synthetic SCSI devices do not support the MAINTENANCE_IN SCSI command, so scsi_report_opcode() always fails, resulting in messages like this:
hv_storvsc <guid>: tag#205 cmd 0xa3 status: scsi 0x2 srb 0x86 hv 0xc0000001
The recently added support for command duration limits calls scsi_report_opcode() four times as each device comes online, which significantly increases the number of messages logged in a system with many disks.
Fix the problem by always marking Hyper-V synthetic SCSI devices as not supporting scsi_report_opcode(). With this setting, the MAINTENANCE_IN SCSI command is not issued and no messages are logged.
--- drivers/scsi/storvsc_drv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/scsi/storvsc_drv.c +2 -0
@@ -1567,6 +1567,8 @@ static int storvsc_device_configure(struct scsi_device *sdevice) {blk_queue_rq_timeout (sdevice->request_queue, (storvsc_timeout *HZ )); +/* storvsc devices don't support MAINTENANCE_IN SCSI cmd */ + sdevice->no_report_opcodes =1 ; sdevice->no_write_same =1 ;/*
Signature · 1 line
1.8.3.1
Martin K. Petersen
AppliedQuoted 4 lines · Michael Kelley
Hyper-V synthetic SCSI devices do not support the
MAINTENANCE_INSCSI command, soscsi_report_opcode()always fails, resulting in messages like this:
Quoted 8 lines
hv_storvsc<guid>: tag#205 cmd0xa3status: scsi0x2srb0x86hv0xc0000001The recently added support for command duration limits calls
scsi_report_opcode()four times as each device comes online, which significantly increases the number of messages logged in a system with many disks.[...]
Applied to 6.4/scsi-fixes, thanks!
[1/1] scsi: storvsc: Always set no_report_opcodes
https://git.kernel.org/mkp/scsi/c/31d16e712bdc
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering