phy: mtk-mipi-csi: add driver for CSI phy
Subsystems (6)
Julien Stephan
maintainerv4 cover phy: mtk-mipi-csi: add driver for CSI phy
Adding a new driver for the MIPI CSI CD-PHY module v 0.5 embedded in some Mediatek soc, such as the MT8365
This driver was adapted from https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
v1 can be found here: https://lore.kernel.org/all/[email protected]/
v2 can be found here: https://lore.kernel.org/all/[email protected]/
v3 can be found here: https://lore.kernel.org/all/[email protected]/
Changelog
Changes in v4:include/dt-bindings/phy/phy.h:
- remove commit adding PHY_TYPE_CDPHY definition
Binding file:
- use the standard phy-type property instead of a custom one so rename mediatek,phy-type -> phy-type
- phy-type property is made optional: when present, describes the phy type and the operating mode
- phy-cell is modified to accept a phy argument representing the phy operating mode if phy-type is not specified
- adding new property num-lanes
Driver:
- add a custom xlate function to handle phy cells
- update probe function to retrieve the new value phy-type instead of the mediatek,phy-type
- remove useless struct define struct mtk_mipi_dphy;
- rename some functin/variable from xx_dphy_xx to xx_cdphy_xx
- update probe function to read num-lanes property
Changes in v3:
Binding file:
- rename compatible string
mediatek,phy-mipi-csi-0-5 -> mediatek,mt8365-csi-rx
- rename binding file to be as compatible string
- change property mediatek,is_cdphy -> mediatek,phy-type using an enum value instead of boolean for scalability
- remove status property from example nodes
- rename example node name 'mipi_rx_csi0: mipi_rx_csi0@11c10000' -> 'csi0_rx: phy@11c10000'
- put reg address in lower case
include/dt-bindings/phy/phy.h:
- add PHY_TYPE_CDPHY definition
Driver:
- rename compatible string
- rename property mediatek,is_cdphy -> mediatek,phy-type
- rename CSIx* macro to CSIX* (x -> X)
- fix style issue on the driver data structure
- update MODULE_DESCRIPTION as suggested by Angelo and update the kconfig module description to match it
- add dphy /cdphy eq tuning function to factor the code and increase readability
- fix typo __PHY_MTK__MIPI_CSI__C_0_5_RX_REG_H_ --> __PHY_MTK_MIPI_CSI_V_0_5_RX_REG_H_
- reword commit message to update my contributions
- added missing copyright
- added module name in Kconfig
Changes in v2:
- fix all comments on bindings
- move the binding chunk from driver to binding commit
- fix dt_binding_check error (reported by DT_CHECKER_FLAGS)
- use a more generic compatible string
- add a new dt properties to simplify the driver "mediatek,is_cdphy"
- rename the driver and the corresponding file to include version
- drop of_match_ptr()
- use devm_platform_ioremap_resource
- use phy-mtk-io.h api instead of regmap
- rework the driver to use dt nodes to declare PHY instead of an array in the driver
- remove useless define for unused registers
- remove support for CSI0A/B because it cannot be tested, and it simplifies the driver for a first review
- edit commit message and bindings to be more descriptive about the hardware
Florian Sylvestre (1):
dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5
Julien Stephan (1):
phy use phy-type
Phi-bang Nguyen (1):
phy: mtk-mipi-csi: add driver for CSI phy
.../bindings/phy/mediatek,mt8365-csi-rx.yaml | 73 ++++ MAINTAINERS | 7 + drivers/phy/mediatek/Kconfig | 12 + drivers/phy/mediatek/Makefile | 2 + .../mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h | 62 ++++ drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c | 331 ++++++++++++++++++ 6 files changed, 487 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c
--
2.41.0
Julien Stephan
maintainerPATCH v4 1/2 dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5
From: Florian Sylvestre <[email protected]>
This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in some Mediatek soc, such as the mt8365
--- .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 79 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml new file +79 -0
@@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2023 MediaTek, BayLibre +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/mediatek,mt8365-csi-rx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek Sensor Interface MIPI CSI CD-PHY + +maintainers: + - Julien Stephan <[email protected]> + - Andy Hsieh <[email protected]> + +description: + The SENINF CD-PHY is a set of CD-PHY connected to the SENINF CSI-2 + receivers. The number of PHYs depends on the SoC model. + Depending on the SoC model, each PHYs can be either CD-PHY or D-PHY only + capable. + +properties: + compatible: + enum: + - mediatek,mt8365-csi-rx + + reg: + maxItems: 1 + + num-lanes: + enum: [2, 3, 4] + + '#phy-cells': + enum: [0, 1] + description: | + If the PHY doesn't support mode selection then #phy-cells must be 0 and + PHY mode is described using phy-type property. + If the PHY supports mode selection, then #phy-cells must be 1 and mode + is set in the PHY cells. Supported modes are: + - PHY_TYPE_DPHY + - PHY_TYPE_CPHY + See include/dt-bindings/phy/phy.h for constants. + + phy-type: + description: + If the PHY doesn't support mode selection then this set the operating mode. + See include/dt-bindings/phy/phy.h for constants. + const: 10 + $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - compatible + - reg + - num-lanes + - '#phy-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/phy/phy.h> + soc { + #address-cells = <2>; + #size-cells = <2>; + + csi0_rx: phy@11c10000 { + compatible = "mediatek,mt8365-csi-rx"; + reg = <0 0x11c10000 0 0x2000>; + num-lanes = <2>; + #phy-cells = <1>; + }; + + csi1_rx: phy@11c12000 { + compatible = "mediatek,mt8365-csi-rx"; + reg = <0 0x11c12000 0 0x2000>; + phy-type = <PHY_TYPE_DPHY>; + num-lanes = <2>; + #phy-cells = <0>; + }; + }; +...
MAINTAINERS +6 -0
@@ -13184,6 +13184,12 @@ F: Documentation/devicetree/bindings/media/mediatek-vpu.txt F: drivers/media/platform/mediatek/vcodec/ F: drivers/media/platform/mediatek/vpu/ +MEDIATEK MIPI-CSI CDPHY DRIVER +M: Julien Stephan <[email protected]> +M: Andy Hsieh <[email protected]> +S: Supported +F: Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml + MEDIATEK MMC/SD/SDIO DRIVER M: Chaotian Jing <[email protected]> S: Maintained
Signature · 7 lines
2.41.0 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v4 1/2] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5
Quoted 5 lines · Julien Stephan
From: Florian Sylvestre <[email protected]>
This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in some Mediatek soc, such as the mt8365
Quoted 8 lines
Signed-off-by Florian Sylvestre <[email protected]>Signed-off-by Julien Stephan <[email protected]>--- .../bindings/phy/mediatek,mt8365-csi-rx.yaml | 79 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml
Julien Stephan
maintainerPATCH v4 2/2 phy: mtk-mipi-csi: add driver for CSI phy
In reply to Julien StephanFrom: Phi-bang Nguyen <[email protected]>
This is a new driver that supports the MIPI CSI CD-PHY version 0.5
The number of PHYs depend on the SoC.
Each PHY can support D-PHY only or CD-PHY configuration. The driver supports only D-PHY mode, so CD-PHY compatible PHY are configured in D-PHY mode.
[Julien Stephan: simplify driver model: one instance per phy vs one instance for all phys]
--- MAINTAINERS | 1 + drivers/phy/mediatek/Kconfig | 12 + drivers/phy/mediatek/Makefile | 2 + .../mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h | 62 ++++ drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c | 343 ++++++++++++++++++ 5 files changed, 420 insertions(+) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c
MAINTAINERS +1 -0
@@ -13189,6 +13189,7 @@ M: Julien Stephan <[email protected]> M: Andy Hsieh <[email protected]> S: Supported F: Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml +F: drivers/phy/mediatek/phy-mtk-mipi-csi-0-5* MEDIATEK MMC/SD/SDIO DRIVER M: Chaotian Jing <[email protected]>
drivers/phy/mediatek/Kconfig +12 -0
@@ -74,3 +74,15 @@ config PHY_MTK_DP select GENERIC_PHY help Support DisplayPort PHY for MediaTek SoCs. + +config PHY_MTK_MIPI_CSI_0_5 + tristate "MediaTek MIPI CSI CD-PHY v0.5 Driver" + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on OF + select GENERIC_PHY + help + Enable this to support the MIPI CSI CD-PHY receiver version 0.5. + The driver supports multiple CSI cdphy ports simultaneously. + + To compile this driver as a module, choose M here: the + module will be called phy-mtk-mipi-csi-0-5.
drivers/phy/mediatek/Makefile +2 -0
@@ -19,3 +19,5 @@ phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o + +obj-$(CONFIG_PHY_MTK_MIPI_CSI_0_5) += phy-mtk-mipi-csi-0-5.o
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h new file +62 -0
62 lines not on this page · raw message
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +343 -0
343 lines not on this page · raw message
Signature · 7 lines
2.41.0 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Vinod Koul
maintainerQuoted 43 lines · Julien Stephan
From: Phi-bang Nguyen <[email protected]>
This is a new driver that supports the MIPI CSI CD-PHY version 0.5
The number of PHYs depend on the SoC.
Each PHY can support D-PHY only or CD-PHY configuration. The driver supports only D-PHY mode, so CD-PHY compatible PHY are configured in D-PHY mode.Signed-off-by Louis Kuo <[email protected]>Signed-off-by Phi-bang Nguyen <[email protected]>[Julien Stephan: refactor code][Julien Stephan: simplify driver model: one instance per phy vs one instance for all phys]
Co-developed-by Julien Stephan <[email protected]>Signed-off-by Julien Stephan <[email protected]>--- MAINTAINERS | 1 + drivers/phy/mediatek/Kconfig | 12 + drivers/phy/mediatek/Makefile | 2 + .../mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h | 62 ++++ drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c | 343 ++++++++++++++++++ 5 files changed, 420 insertions(+) create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.cMAINTAINERS +1
-0@@ -13189,6 +13189,7 @@ M: Julien Stephan <[email protected]> M: Andy Hsieh <[email protected]> S: Supported F: Documentation/devicetree/bindings/phy/mediatek,mt8365-csi-rx.yaml +F: drivers/phy/mediatek/phy-mtk-mipi-csi-0-5* MEDIATEK MMC/SD/SDIO DRIVER M: Chaotian Jing <[email protected]>drivers/phy/mediatek/Kconfig +0
-0
drivers/phy/mediatek/Kconfig config PHY_MTK_DP · line 78
Quoted 5 lines
drivers/phy/mediatek/Kconfig +2
-0@@ -74,3 +74,15 @@ config PHY_MTK_DP select GENERIC_PHY help Support DisplayPort PHY for MediaTek SoCs. + +config PHY_MTK_MIPI_CSI_0_5
Keep this sorted alphabetically pls
Quoted 15 lines
drivers/phy/mediatek/Kconfig +10
-0+ tristate "MediaTek MIPI CSI CD-PHY v0.5 Driver" + depends on ARCH_MEDIATEK || COMPILE_TEST + depends on OF + select GENERIC_PHY + help + Enable this to support the MIPI CSI CD-PHY receiver version 0.5. + The driver supports multiple CSI cdphy ports simultaneously. + + To compile this driver as a module, choose M here: the + module will be called phy-mtk-mipi-csi-0-5.drivers/phy/mediatek/Makefile +0
-0
drivers/phy/mediatek/Makefile phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o · line 23
Quoted 5 lines
drivers/phy/mediatek/Makefile +2
-0@@ -19,3 +19,5 @@ phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o + +obj-$(CONFIG_PHY_MTK_MIPI_CSI_0_5) += phy-mtk-mipi-csi-0-5.o
This one too and no need of empty line
Quoted 116 lines
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5-rx-reg.h new file +62
-0@@ -0,0 +1,62 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Copyright (c) 2023, MediaTek Inc. +* Copyright (c) 2023, BayLibre Inc. +*/ + +#ifndef __PHY_MTK_MIPI_CSI_V_0_5_RX_REG_H__ +#define __PHY_MTK_MIPI_CSI_V_0_5_RX_REG_H__ + +/* +* CSI1 and CSI2 are identical, and similar to CSI0. All CSIX macros are +* applicable to the three PHYs. Where differences exist, they are denoted by +* macro names using CSI0 and CSI1, the latter being applicable to CSI1 and +* CSI2 alike. +*/ + +#define MIPI_RX_ANA00_CSIXA 0x0000 +#define RG_CSI0A_CPHY_EN BIT(0) +#define RG_CSIXA_EQ_PROTECT_EN BIT(1) +#define RG_CSIXA_BG_LPF_EN BIT(2) +#define RG_CSIXA_BG_CORE_EN BIT(3) +#define RG_CSIXA_DPHY_L0_CKMODE_EN BIT(5) +#define RG_CSIXA_DPHY_L0_CKSEL BIT(6) +#define RG_CSIXA_DPHY_L1_CKMODE_EN BIT(8) +#define RG_CSIXA_DPHY_L1_CKSEL BIT(9) +#define RG_CSIXA_DPHY_L2_CKMODE_EN BIT(11) +#define RG_CSIXA_DPHY_L2_CKSEL BIT(12) + +#define MIPI_RX_ANA18_CSIXA 0x0018 +#define RG_CSI0A_L0_T0AB_EQ_IS GENMASK(5, 4) +#define RG_CSI0A_L0_T0AB_EQ_BW GENMASK(7, 6) +#define RG_CSI0A_L1_T1AB_EQ_IS GENMASK(21, 20) +#define RG_CSI0A_L1_T1AB_EQ_BW GENMASK(23, 22) +#define RG_CSI0A_L2_T1BC_EQ_IS GENMASK(21, 20) +#define RG_CSI0A_L2_T1BC_EQ_BW GENMASK(23, 22) +#define RG_CSI1A_L0_EQ_IS GENMASK(5, 4) +#define RG_CSI1A_L0_EQ_BW GENMASK(7, 6) +#define RG_CSI1A_L1_EQ_IS GENMASK(21, 20) +#define RG_CSI1A_L1_EQ_BW GENMASK(23, 22) +#define RG_CSI1A_L2_EQ_IS GENMASK(5, 4) +#define RG_CSI1A_L2_EQ_BW GENMASK(7, 6) + +#define MIPI_RX_ANA1C_CSIXA 0x001c +#define MIPI_RX_ANA20_CSI0A 0x0020 + +#define MIPI_RX_ANA24_CSIXA 0x0024 +#define RG_CSIXA_RESERVE GENMASK(31, 24) + +#define MIPI_RX_ANA40_CSIXA 0x0040 +#define RG_CSIXA_CPHY_FMCK_SEL GENMASK(1, 0) +#define RG_CSIXA_ASYNC_OPTION GENMASK(7, 4) +#define RG_CSIXA_CPHY_SPARE GENMASK(31, 16) + +#define MIPI_RX_WRAPPER80_CSIXA 0x0080 +#define CSR_CSI_RST_MODE GENMASK(17, 16) + +#define MIPI_RX_ANAA8_CSIXA 0x00a8 +#define RG_CSIXA_CDPHY_L0_T0_BYTECK_INVERT BIT(0) +#define RG_CSIXA_DPHY_L1_BYTECK_INVERT BIT(1) +#define RG_CSIXA_CDPHY_L2_T1_BYTECK_INVERT BIT(2) + +#endif drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +42
-0@@ -0,0 +1,343 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* MediaTek MIPI CSI v0.5 driver +* +* Copyright (c) 2023, MediaTek Inc. +* Copyright (c) 2023, BayLibre Inc. +*/ + +#include <dt-bindings/phy/phy.h> +#include <linux/bitfield.h> +#include <linux/delay.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +#include "phy-mtk-io.h" +#include "phy-mtk-mipi-csi-0-5-rx-reg.h" + +#define CSIXB_OFFSET 0x1000 + +struct mtk_mipi_cdphy_port { +struct device *dev; +void __iomem *base; +struct phy *phy; +u32 type; +u32 mode; +u32 num_lanes; +}; + +enum PHY_TYPE { +DPHY =0 , +CPHY , +CDPHY , +}; + +static void mtk_phy_csi_cdphy_ana_eq_tune (void __iomem *base) +{ +mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI0A_L0_T0AB_EQ_IS ,1 );
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c line 52
Quoted 10 lines
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +10
-0+mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI0A_L0_T0AB_EQ_BW ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA1C_CSIXA , +RG_CSI0A_L1_T1AB_EQ_IS ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA1C_CSIXA , +RG_CSI0A_L1_T1AB_EQ_BW ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA20_CSI0A , +RG_CSI0A_L2_T1BC_EQ_IS ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA20_CSI0A , +RG_CSI0A_L2_T1BC_EQ_BW ,1 );
single line would be better (less than 100)
Quoted 161 lines
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +161
-0+ +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI0A_L0_T0AB_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI0A_L0_T0AB_EQ_BW ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA1C_CSIXA , +RG_CSI0A_L1_T1AB_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA1C_CSIXA , +RG_CSI0A_L1_T1AB_EQ_BW ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA20_CSI0A , +RG_CSI0A_L2_T1BC_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA20_CSI0A , +RG_CSI0A_L2_T1BC_EQ_BW ,1 ); +} + +static void mtk_phy_csi_dphy_ana_eq_tune (void __iomem *base) +{ +mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L0_EQ_IS ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L0_EQ_BW ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L1_EQ_IS ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L1_EQ_BW ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA1C_CSIXA , +RG_CSI1A_L2_EQ_IS ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA1C_CSIXA , +RG_CSI1A_L2_EQ_BW ,1 ); + +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L0_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L0_EQ_BW ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L1_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA18_CSIXA , +RG_CSI1A_L1_EQ_BW ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA1C_CSIXA , +RG_CSI1A_L2_EQ_IS ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA1C_CSIXA , +RG_CSI1A_L2_EQ_BW ,1 ); +} + +static int mtk_mipi_phy_power_on (struct phy *phy) +{ +struct mtk_mipi_cdphy_port *port =phy_get_drvdata (phy); +void __iomem *base = port->base; + +/* +* The driver currently supports DPHY and CD-PHY phys, +* but the only mode supported is DPHY, +* so CD-PHY capable phys must be configured in DPHY mode +*/ +if (port->type ==CDPHY ) { +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSI0A_CPHY_EN ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSI0A_CPHY_EN ,0 ); + } + +/* +* Lane configuration: +* +* Only 4 data + 1 clock is supported for now with the following mapping: +* +* CSIXA_LNR0 --> D2 +* CSIXA_LNR1 --> D0 +* CSIXA_LNR2 --> C +* CSIXB_LNR0 --> D1 +* CSIXB_LNR1 --> D3 +*/ +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L0_CKMODE_EN ,0 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L0_CKSEL ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L1_CKMODE_EN ,0 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L1_CKSEL ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L2_CKMODE_EN ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L2_CKSEL ,1 ); + +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L0_CKMODE_EN ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L0_CKSEL ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L1_CKMODE_EN ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L1_CKSEL ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L2_CKMODE_EN ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_DPHY_L2_CKSEL ,1 ); + +/* Byte clock invert */ +mtk_phy_update_field (base +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_CDPHY_L0_T0_BYTECK_INVERT ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_DPHY_L1_BYTECK_INVERT ,1 ); +mtk_phy_update_field (base +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_CDPHY_L2_T1_BYTECK_INVERT ,1 ); + +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_CDPHY_L0_T0_BYTECK_INVERT ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_DPHY_L1_BYTECK_INVERT ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANAA8_CSIXA , +RG_CSIXA_CDPHY_L2_T1_BYTECK_INVERT ,1 ); + +/* Start ANA EQ tuning */ +if (port->type ==CDPHY ) +mtk_phy_csi_cdphy_ana_eq_tune (base); +else +mtk_phy_csi_dphy_ana_eq_tune (base); + +/* End ANA EQ tuning */ +mtk_phy_set_bits (base +MIPI_RX_ANA40_CSIXA ,0x90 ); + +mtk_phy_update_field (base +MIPI_RX_ANA24_CSIXA , +RG_CSIXA_RESERVE ,0x40 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA24_CSIXA , +RG_CSIXA_RESERVE ,0x40 ); +mtk_phy_update_field (base +MIPI_RX_WRAPPER80_CSIXA , +CSR_CSI_RST_MODE ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_WRAPPER80_CSIXA , +CSR_CSI_RST_MODE ,0 ); +/* ANA power on */ +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_CORE_EN ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_CORE_EN ,1 ); +usleep_range (20 ,40 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_LPF_EN ,1 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_LPF_EN ,1 ); + +return 0 ; +} + +static int mtk_mipi_phy_power_off (struct phy *phy) +{ +struct mtk_mipi_cdphy_port *port =phy_get_drvdata (phy); +void __iomem *base = port->base; + +/* Disable MIPI BG. */ +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_CORE_EN ,0 ); +mtk_phy_update_field (base +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_LPF_EN ,0 ); + +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_CORE_EN ,0 ); +mtk_phy_update_field (base +CSIXB_OFFSET +MIPI_RX_ANA00_CSIXA , +RG_CSIXA_BG_LPF_EN ,0 ); + +return 0 ;
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c line 223
Quoted 10 lines
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +10
-0+} + +static struct phy *mtk_mipi_cdphy_xlate (struct device *dev, +struct of_phandle_args *args) +{ +struct mtk_mipi_cdphy_port *priv =dev_get_drvdata (dev); + +/* +* If PHY is CD-PHY then we need to get the operating mode +* For now only D-PHY mode is supported
D-PHY or CD-PHY??
Quoted 122 lines
drivers/phy/mediatek/phy-mtk-mipi-csi-0-5.c new file +120
-0+*/ +if (priv->type ==CDPHY ) { +if (args->args_count !=1 ) { +dev_err (dev,"invalid number of arguments\n" ); +return ERR_PTR (-EINVAL ); + } +switch (args->args[0 ]) { +case PHY_TYPE_DPHY : + priv->mode =DPHY ; +if (priv->num_lanes !=4 ) { +dev_err (dev,"Only 4D1C mode is supported for now!\n" ); +return ERR_PTR (-EINVAL ); + } +break ; +default : +dev_err (dev,"Unsupported PHY type: %i\n" , args->args[0 ]); +return ERR_PTR (-EINVAL ); + } + }else { +if (args->args_count) { +dev_err (dev,"invalid number of arguments\n" ); +return ERR_PTR (-EINVAL ); + } + priv->mode =DPHY ; + } + +return priv->phy; +} + +static const struct phy_ops mtk_cdphy_ops = { + .power_on = mtk_mipi_phy_power_on, + .power_off = mtk_mipi_phy_power_off, + .owner =THIS_MODULE , +}; + +static int mtk_mipi_cdphy_probe (struct platform_device *pdev) +{ +struct device *dev = &pdev->dev; +struct phy_provider *phy_provider; +struct mtk_mipi_cdphy_port *port; +struct phy *phy; +int ret; +u32 phy_type; + + port =devm_kzalloc (dev,sizeof (*port),GFP_KERNEL ); +if (!port) +return -ENOMEM ; + +dev_set_drvdata (dev, port); + + port->dev = dev; + + port->base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (port->base)) +return PTR_ERR (port->base); + + ret =of_property_read_u32 (dev->of_node,"num-lanes" , &port->num_lanes); +if (ret) { +dev_err (dev,"Failed to read num-lanes property: %i\n" , ret); +return ret; + } + +/* +* phy-type is optional, if not present, PHY is considered to be CD-PHY +*/ +if (device_property_present (dev,"phy-type" )) { + ret =of_property_read_u32 (dev->of_node,"phy-type" , &phy_type); +if (ret) { +dev_err (dev,"Failed to read phy-type property: %i\n" , ret); +return ret; + } +switch (phy_type) { +case PHY_TYPE_DPHY : + port->type =DPHY ; +break ; +default : +dev_err (dev,"Unsupported PHY type: %i\n" , phy_type); +return -EINVAL ; + } + }else { + port->type =CDPHY ; + } + + phy =devm_phy_create (dev,NULL , &mtk_cdphy_ops); +if (IS_ERR (phy)) { +dev_err (dev,"Failed to create PHY: %ld\n" ,PTR_ERR (phy)); +return PTR_ERR (phy); + } + + port->phy = phy; +phy_set_drvdata (phy, port); + + phy_provider =devm_of_phy_provider_register (dev, mtk_mipi_cdphy_xlate); +if (IS_ERR (phy_provider)) { +dev_err (dev,"Failed to register PHY provider: %ld\n" , +PTR_ERR (phy_provider)); +return PTR_ERR (phy_provider); + } + +return 0 ; +} + +static const struct of_device_id mtk_mipi_cdphy_of_match[] = { + { .compatible ="mediatek,mt8365-csi-rx" }, + {/* sentinel */ }, +}; +MODULE_DEVICE_TABLE (of, mtk_mipi_cdphy_of_match); + +static struct platform_driver mipi_cdphy_pdrv = { + .probe = mtk_mipi_cdphy_probe, + .driver = { + .name ="mtk-mipi-csi-0-5" , + .of_match_table = mtk_mipi_cdphy_of_match, + }, +}; +module_platform_driver (mipi_cdphy_pdrv); + +MODULE_DESCRIPTION ("MediaTek MIPI CSI CD-PHY v0.5 Driver" ); +MODULE_AUTHOR ("Louis Kuo <[email protected]>" ); +MODULE_LICENSE ("GPL" );Signature · 1 line
2.41.0
Signature · 1 line
~Vinod