net: stmmac: fix double serdes powerdown
Subsystems (4)
PATCH 1/1 net: stmmac: fix double serdes powerdown
From: Bartosz Golaszewski <[email protected]>
Commit 49725ffc15fc ("net: stmmac: power up/down serdes in stmmac_open/release") correctly added a call to the serdes_powerdown() callback to stmmac_release() but did not remove the one from stmmac_remove() which leads to a doubled call to serdes_powerdown().
This can lead to all kinds of problems: in the case of the qcom ethqos driver, it caused an unbalanced regulator disable splat.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +0 -6
@@ -7461,12 +7461,6 @@ void stmmac_dvr_remove(struct device *dev)netif_carrier_off (ndev);unregister_netdev (ndev); -/* Serdes power down needs to happen after VLAN filter -* is deleted that is triggered by unregister_netdev(). -*/ -if (priv->plat->serdes_powerdown) - priv->plat->serdes_powerdown (ndev, priv->plat->bsp_priv); -#ifdef CONFIG_DEBUG_FS stmmac_exit_fs (ndev);#endif
Signature · 1 line
2.39.2
Quoted 7 lines · Wed, Jun 21, 2023 at 03:55:37PM CEST, [email protected] wrote:
From: Bartosz Golaszewski <[email protected]>
Commit
49725ffc15fc("net: stmmac: power up/down serdes in stmmac_open/release") correctly added a call to theserdes_powerdown()callback tostmmac_release()but did not remove the one fromstmmac_remove()which leads to a doubled call toserdes_powerdown().
Quoted 5 lines
This can lead to all kinds of problems: in the case of the qcom ethqos driver, it caused an unbalanced regulator disable splat.
Fixes 49725ffc15fc ("net: stmmac: power up/down serdes in stmmac_open/release")Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Commit
49725ffc15fc("net: stmmac: power up/down serdes in stmmac_open/release") correctly added a call to theserdes_powerdown()callback tostmmac_release()but did not remove the one fromstmmac_remove()which leads to a doubled call toserdes_powerdown().
Quoted 5 lines
This can lead to all kinds of problems: in the case of the qcom ethqos driver, it caused an unbalanced regulator disable splat.
Fixes 49725ffc15fc ("net: stmmac: power up/down serdes in stmmac_open/release")Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 24 lines
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ------ 1 file changed, 6 deletions(-)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +0
-6@@ -7461,12 +7461,6 @@ void stmmac_dvr_remove(struct device *dev)netif_carrier_off (ndev);unregister_netdev (ndev); -/* Serdes power down needs to happen after VLAN filter -* is deleted that is triggered by unregister_netdev(). -*/ -if (priv->plat->serdes_powerdown) - priv->plat->serdes_powerdown (ndev, priv->plat->bsp_priv); -#ifdef CONFIG_DEBUG_FS stmmac_exit_fs (ndev);#endif Signature · 1 line
2.39.2
-----Original Message-----
From: Andrew Halaney <[email protected]>
Sent: Friday, June 23, 2023 2:54 AM
To: Bartosz Golaszewski <[email protected]>
Cc: Giuseppe Cavallaro <[email protected]>; Alexandre Torgue <[email protected]>; Jose Abreu <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Maxime Coquelin <[email protected]>; Chang, Junxiao <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; Bartosz Golaszewski <[email protected]>
Subject: Re: [PATCH net] net: stmmac: fix double serdes powerdown
Quoted 7 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Commit
49725ffc15fc("net: stmmac: power up/down serdes in stmmac_open/release") correctly added a call to theserdes_powerdown()callback tostmmac_release()but did not remove the one fromstmmac_remove()which leads to a doubled call toserdes_powerdown().
Quoted 6 lines
This can lead to all kinds of problems: in the case of the qcom ethqos driver, it caused an unbalanced regulator disable splat.
Fixes 49725ffc15fc ("net: stmmac: power up/down serdes instmmac_open/release")
Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 25 lines
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ------ 1 file changed, 6 deletions(-)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +0
-7@@ -7461,12 +7461,6 @@ void stmmac_dvr_remove(struct device *dev)netif_carrier_off (ndev);unregister_netdev (ndev); -/* Serdes power down needs to happen after VLAN filter -* is deleted that is triggered by unregister_netdev(). -*/ -if (priv->plat->serdes_powerdown) - priv->plat->serdes_powerdown (ndev, priv->plat->bsp_priv); -#ifdef CONFIG_DEBUG_FS stmmac_exit_fs (ndev);#endif --2.39.2
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 21 Jun 2023 15:55:37 +0200 you wrote:
From: Bartosz Golaszewski <[email protected]>
Commit
49725ffc15fc("net: stmmac: power up/down serdes in stmmac_open/release") correctly added a call to theserdes_powerdown()callback tostmmac_release()but did not remove the one fromstmmac_remove()which leads to a doubled call toserdes_powerdown().[...]
Here is the summary with links:
- [net] net: stmmac: fix double serdes powerdown
https://git.kernel.org/netdev/net/c/c4fc88ad2a76
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html