gve: Set default duplex configuration to full
Subsystems (3)
PATCH 1/1 gve: Set default duplex configuration to full
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities.
Set the default duplex configuration to full, as the driver runs in full duplex mode at this point.
--- drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/google/gve/gve_ethtool.c +3 -0
@@ -590,6 +590,9 @@ static int gve_get_link_ksettings(struct net_device *netdev, err =gve_adminq_report_link_speed (priv); cmd->base.speed = priv->link_speed; + + cmd->base.duplex =DUPLEX_FULL ; +return err; }
Signature · 1 line
2.25.1
Quoted 7 lines · Junfeng Guo
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities.
Set the default duplex configuration to full, as the driver runs in full duplex mode at this point.
Quoted 6 lines
Fixes 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")Signed-off-by Junfeng Guo <[email protected]>--- drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++ 1 file changed, 3 insertions(+)
Thanks,
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 6 Jul 2023 12:41:28 +0800 you wrote:
Current duplex mode was unset in the driver, resulting in the default parameter being set to 0, which corresponds to half duplex. It might mislead users to have incorrect expectation about the driver's transmission capabilities.
Set the default duplex configuration to full, as the driver runs in full duplex mode at this point.[...]
Here is the summary with links:
- [net] gve: Set default duplex configuration to full
https://git.kernel.org/netdev/net/c/0503efeadbf6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html