Skip to contentSkip to conversation

ionic: remove dead device fail path

PATCH Applied Shannon Nelson 2 participants 2 messages Jul 6, 2023 – Jul 7, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ionic: remove dead device fail path

Remove the probe error path code that leaves the driver bound to the device, but with essentially a dead device. This was useful maybe twice early in the driver's life and no longer makes sense to keep.

Fixes 30a1e6d0f8e2 ("ionic: keep ionic dev on lif init fail")
---
 drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c +0 -6
index b8678da1cce5..ab7d217b98b3 100644
@@ -353,12 +353,6 @@ static int ionic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	ionic_reset(ionic);
 err_out_teardown:
 	ionic_dev_teardown(ionic);
-	pci_clear_master(pdev);
-	/* Don't fail the probe for these errors, keep
-	 * the hw interface around for inspection
-	 */
-	return 0;
-
 err_out_unmap_bars:
 	ionic_unmap_bars(ionic);
 err_out_pci_release_regions:
Signature · 1 line
2.17.1
#1 lore raw
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

Quoted 9 lines · On Thu, 6 Jul 2023 13:59:24 -0700 you wrote:

Remove the probe error path code that leaves the driver bound to the device, but with essentially a dead device. This was useful maybe twice early in the driver's life and no longer makes sense to keep.

Fixes 30a1e6d0f8e2 ("ionic: keep ionic dev on lif init fail")

[...]

Here is the summary with links:
- [net] ionic: remove dead device fail path

    https://git.kernel.org/netdev/net/c/3a7af34fb6ec

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html