net: bgmac: postpone turning IRQs off to avoid SoC hangs
Subsystems (3)
PATCH 1/1 net: bgmac: postpone turning IRQs off to avoid SoC hangs
From: Rafał Miłecki <[email protected]>
Turning IRQs off is done by accessing Ethernet controller registers. That can't be done until device's clock is enabled. It results in a SoC hang otherwise.
This bug remained unnoticed for years as most bootloaders keep all Ethernet interfaces turned on. It seems to only affect a niche SoC family BCM47189. It has two Ethernet controllers but CFE bootloader uses only the first one.
--- drivers/net/ethernet/broadcom/bgmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/broadcom/bgmac.c +2 -2
@@ -1492,8 +1492,6 @@ int bgmac_enet_probe(struct bgmac *bgmac) bgmac->in_init = true; -bgmac_chip_intrs_off (bgmac); - net_dev->irq = bgmac->irq;SET_NETDEV_DEV (net_dev, bgmac->dev);dev_set_drvdata (bgmac->dev, bgmac);
@@ -1511,6 +1509,8 @@ int bgmac_enet_probe(struct bgmac *bgmac)*/ bgmac_clk_enable (bgmac,0 ); +bgmac_chip_intrs_off (bgmac); +/* This seems to be fixing IRQ by assigning OOB #6 to the core */ if (!(bgmac->feature_flags &BGMAC_FEAT_IDM_MASK )) {if (bgmac->feature_flags &BGMAC_FEAT_IRQ_ID_OOB_6 )
Signature · 1 line
2.35.3
Quoted 43 lines · Rafał Miłecki
From: Rafał Miłecki <[email protected]>
Turning IRQs off is done by accessing Ethernet controller registers. That can't be done until device's clock is enabled. It results in a SoC hang otherwise.
This bug remained unnoticed for years as most bootloaders keep all Ethernet interfaces turned on. It seems to only affect a niche SoC family BCM47189. It has two Ethernet controllers but CFE bootloader uses only the first one.
Fixes 34322615cbaa ("net: bgmac: Mask interrupts during probe")Signed-off-by Rafał Miłecki <[email protected]>--- drivers/net/ethernet/broadcom/bgmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/broadcom/bgmac.c +2
-2@@ -1492,8 +1492,6 @@ int bgmac_enet_probe(struct bgmac *bgmac) bgmac->in_init = true; -bgmac_chip_intrs_off (bgmac); - net_dev->irq = bgmac->irq;SET_NETDEV_DEV (net_dev, bgmac->dev);dev_set_drvdata (bgmac->dev, bgmac);@@ -1511,6 +1509,8 @@ int bgmac_enet_probe(struct bgmac *bgmac)*/ bgmac_clk_enable (bgmac,0 ); +bgmac_chip_intrs_off (bgmac); +/* This seems to be fixing IRQ by assigning OOB #6 to the core */ if (!(bgmac->feature_flags &BGMAC_FEAT_IDM_MASK )) {if (bgmac->feature_flags &BGMAC_FEAT_IRQ_ID_OOB_6 )Signature · 1 line
2.35.3
Looks like a good catch!
Thanks,
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 6 lines · On Fri, 7 Jul 2023 08:53:25 +0200 you wrote:
From: Rafał Miłecki <[email protected]>
Turning IRQs off is done by accessing Ethernet controller registers. That can't be done until device's clock is enabled. It results in a SoC hang otherwise.
Quoted 6 lines
This bug remained unnoticed for years as most bootloaders keep all Ethernet interfaces turned on. It seems to only affect a niche SoC family BCM47189. It has two Ethernet controllers but CFE bootloader uses only the first one.
[...]
Here is the summary with links:
- [net.git] net: bgmac: postpone turning IRQs off to avoid SoC hangs
https://git.kernel.org/netdev/net/c/e7731194fdf0
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html