Skip to contentSkip to conversation

ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

PATCH New Tomasz Figa 3 participants 6 messages Oct 8, 2012 – Oct 23, 2012

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Tomasz Figa

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board.

Signed-off-by Tomasz Figa <[email protected]>
---
 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)
arch/arm/boot/dts/exynos4210-origen.dts +16 -0
index d1a1101..c7295fb 100644
@@ -57,6 +57,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	gpio_keys {
 		compatible = "gpio-keys";
 		#address-cells = <1>;
arch/arm/boot/dts/exynos4210-smdkv310.dts +16 -0
index b87cca2..f634907 100644
@@ -43,6 +43,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	keypad at 100A0000 {
 		samsung,keypad-num-rows = <2>;
 		samsung,keypad-num-columns = <8>;
Signature · 1 line
1.7.12
author
#1 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

Hi Kgene,

Quoted 9 lines · On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:

This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board.

Signed-off-by Tomasz Figa <[email protected]>
---
 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)

I think you missed this patch when applying Exynos dts reorganization patches. It is needed to enable serial ports on Origen and SMDKV310 boards. Could you apply it as well?

Best regards,

Signature · 2 lines
Tomasz Figa
Samsung Poland R&D Center
#2 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

Quoted 14 lines · Tomasz Figa

Hi Kgene,

Quoted 9 lines · On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:

This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board.

Signed-off-by Tomasz Figa <[email protected]>
---
 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)
Quoted 2 lines

I think you missed this patch when applying Exynos dts reorganization patches. It is needed to enable serial ports on Origen and SMDKV310

boards.

Quoted 2 lines

Could you apply it as well?

Oops, yeah. I will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#3 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

Hi Kgene,

Quoted 15 lines · On Monday 15 of October 2012 23:23:22 Kukjin Kim wrote:
Quoted 14 lines · Tomasz Figa

Hi Kgene,

Quoted 10 lines · On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:

This patch adds status override of serial nodes to enable used serial
ports on Origen and SMDKV310 board.

Signed-off-by Tomasz Figa <[email protected]>

---

 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)
Quoted 8 lines
Quoted 2 lines

I think you missed this patch when applying Exynos dts reorganization patches. It is needed to enable serial ports on Origen and SMDKV310

boards.

Quoted 1 line

Could you apply it as well?

Oops, yeah. I will apply.

I saw that you applied this patch to your next/dt-samsung branch, thanks.

However I think this should be considered a fix, because without it serial console on Origen and SMDKV310 will be broken.

Best regards,
Tomasz Figa

#4 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

Quoted 4 lines · Tomasz Figa

However I think this should be considered a fix, because without it serial console on Origen and SMDKV310 will be broken.

Well, I couldn't find any broken due to miss this for v3.7. I think, there is no usage of serial controller in mainline for Origen and SMDKV310 now. So this should be queued for -next. If not, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#5 lore raw

PATCH 1/1 ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

Quoted 8 lines · On Tuesday 23 of October 2012 21:03:01 Kukjin Kim wrote:
Quoted 2 lines · Tomasz Figa

However I think this should be considered a fix, because without it serial console on Origen and SMDKV310 will be broken.

Well, I couldn't find any broken due to miss this for v3.7. I think, there is no usage of serial controller in mainline for Origen and SMDKV310 now. So this should be queued for -next. If not, please let me know.

Personally I'm fine with this, but it sounds a bit off, since (correct me if I am wrong) it looks like serial console is the only way to check if the board boots.

Best regards,
Tomasz Figa