riscv: mm: fix truncates issue on RV32
PATCH 1/1 riscv: mm: fix truncates issue on RV32
lkp reports below sparse warning when building for RV32:arch/riscv/mm/init.c:1204:48: sparse: warning: cast truncates bits from constant value (100000000 becomes 0)
IMO, the reason we didn't see this truncates bug in real world is "0" means MEMBLOCK_ALLOC_ACCESSIBLE in memblock and there's no RV32 HW with more than 4GB memory.
Fix it anyway to make sparse happy.
--- arch/riscv/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/mm/init.c +1 -1
@@ -1346,7 +1346,7 @@ static void __init reserve_crashkernel(void)*/ crash_base =memblock_phys_alloc_range (crash_size,PMD_SIZE , search_start, -min (search_end, (unsigned long )SZ_4G )); +min (search_end, (unsigned long )(SZ_4G -1 )));if (crash_base ==0 ) {/* Try again without restricting region to 32bit addressible memory */ crash_base = memblock_phys_alloc_range(crash_size, PMD_SIZE,
Signature · 1 line
2.40.1
Palmer Dabbelt
AppliedQuoted 9 lines · Jisheng Zhang
lkp reports below sparse warning when building for RV32:
arch/riscv/mm/init.c:1204:48: sparse: warning: cast truncates bits from constant value (100000000 becomes 0)IMO, the reason we didn't see this truncates bug in real world is "0" means
MEMBLOCK_ALLOC_ACCESSIBLEin memblock and there's no RV32 HW with more than 4GB memory.[...]
Applied, thanks!
[1/1] riscv: mm: fix truncates issue on RV32
https://git.kernel.org/palmer/c/b690e266dae2
Best regards,
Signature · 7 lines
Palmer Dabbelt <[email protected]> _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
This patch was applied to riscv/linux.git (fixes) by Palmer Dabbelt <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:
Quoted 9 lines · On Mon, 10 Jul 2023 01:10:36 +0800 you wrote:
lkp reports below sparse warning when building for RV32:
arch/riscv/mm/init.c:1204:48: sparse: warning: cast truncates bits from constant value (100000000 becomes 0)IMO, the reason we didn't see this truncates bug in real world is "0" means
MEMBLOCK_ALLOC_ACCESSIBLEin memblock and there's no RV32 HW with more than 4GB memory.[...]
Here is the summary with links:
- riscv: mm: fix truncates issue on RV32
https://git.kernel.org/riscv/c/b690e266dae2
You are awesome, thank you!
Signature · 9 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv