Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool()
Subsystems (3)
PATCH v3 1/1 Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool()
strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name.
While at it, include the corresponding header file (<linux/kstrtox.h>)
---
This patch was already sent as a part of a serie ([1]) that axed all usages of strtobool().
Most of the patches have been merged in -next.
I synch'ed with latest -next and re-send the remaining ones as individual patches.
Only 2 patches remain un-applied.
Changes in v3:
- No change
- Adding in cc: [email protected]
- Fix a duplicated Signed-off-by at the end of the "below --- section"
Changes in v2:
- No change
- https://lore.kernel.org/all/58207d5b81c5739c037c030893fb08ea3dbedc57.1673687451.git.christophe.jaillet@wanadoo.fr/
v1:
[1]: https://lore.kernel.org/all/[email protected]/
--- net/bluetooth/hci_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/bluetooth/hci_debugfs.c +2 -1
@@ -22,6 +22,7 @@*/ #include <linux/debugfs.h> +#include <linux/kstrtox.h> #include <net/bluetooth/bluetooth.h> #include <net/bluetooth/hci_core.h>
@@ -1152,7 +1153,7 @@ static ssize_t force_no_mitm_write(struct file *file,return -EFAULT ; buf[buf_size] ='\0' ; -if (strtobool (buf, &enable)) +if (kstrtobool (buf, &enable))return -EINVAL ;if (enable ==hci_dev_test_flag (hdev,HCI_FORCE_NO_MITM ))
Signature · 1 line
2.34.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=764536
---Test result---
Test Summary:
CheckPatch PASS 0.69 seconds GitLint FAIL 0.63 seconds SubjectPrefix PASS 0.14 seconds BuildKernel PASS 33.35 seconds CheckAllWarning PASS 36.61 seconds CheckSparse PASS 41.58 seconds CheckSmatch PASS 114.87 seconds BuildKernel32 PASS 32.08 seconds TestRunnerSetup PASS 487.74 seconds TestRunner_l2cap-tester PASS 22.52 seconds TestRunner_iso-tester PASS 40.30 seconds TestRunner_bnep-tester PASS 10.19 seconds TestRunner_mgmt-tester PASS 214.76 seconds TestRunner_rfcomm-tester PASS 15.63 seconds TestRunner_sco-tester PASS 16.55 seconds TestRunner_ioctl-tester PASS 17.22 seconds TestRunner_mesh-tester PASS 12.98 seconds TestRunner_smp-tester PASS 13.79 seconds TestRunner_userchan-tester PASS 10.69 seconds IncrementalBuild PASS 30.56 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[v3] Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool()
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
29: B1 Line exceeds max length (118>80): " - https://lore.kernel.org/all/58207d5b81c5739c037c030893fb08ea3dbedc57.1673687451.git.christophe.jaillet@wanadoo.fr/"
31: B2 Line has trailing whitespace: "v1: "
32: B1 Line exceeds max length (84>80): "[1]: https://lore.kernel.org/all/[email protected]/"
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 9 lines · On Tue, 11 Jul 2023 19:41:10 +0200 you wrote:
strtobool()is the same askstrtobool(). However, the latter is more used within the kernel.In order to remove
strtobool()and slightly simplifykstrtox.h, switch to the other function name.While at it, include the corresponding header file (<
linux/kstrtox.h>)[...]
Here is the summary with links:
- [v3] Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool()
https://git.kernel.org/bluetooth/bluetooth-next/c/34ffc92ed051
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html