net: mana: Fix doorbell access for receive queues
Subsystems (5)
v5 cover net: mana: Fix doorbell access for receive queues
From: Long Li <[email protected]>
This patchset fixes the issues discovered during 200G physical link tests. It fixes doorbell usage and WQE format for receive queues.
Long Li (2):
net: mana: Batch ringing RX queue doorbell on receiving packets
net: mana: Use the correct WQE count for ringing RQ doorbell
drivers/net/ethernet/microsoft/mana/gdma_main.c | 5 ++++- drivers/net/ethernet/microsoft/mana/mana_en.c | 10 ++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
PATCH v5 1/2 net: mana: Batch ringing RX queue doorbell on receiving packets
From: Long Li <[email protected]>
It's inefficient to ring the doorbell page every time a WQE is posted to the received queue. Excessive MMIO writes result in CPU spending more time waiting on LOCK instructions (atomic operations), resulting in poor scaling performance.
Move the code for ringing doorbell page to where after we have posted all WQEs to the receive queue during a callback from napi_poll().
With this change, tests showed an improvement from 120G/s to 160G/s on a 200G physical link, with 16 or 32 hardware queues.
Tests showed no regression in network latency benchmarks on single connection.
---
Change log:
v2:
Check for comp_read > 0 as it might be negative on completion error. Set rq.wqe_cnt to 0 according to BNIC spec.
v3:
Add details in the commit on the reason of performance increase and test numbers. Add details in the commit on why rq.wqe_cnt should be set to 0 according to hardware spec. Add "Reviewed-by" from Haiyang and Dexuan.
v4:
Split the original patch into two: one for batching doorbell, one for setting the correct wqe count
v5:
drop Cc: stable and use net-next
drivers/net/ethernet/microsoft/mana/mana_en.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/net/ethernet/microsoft/mana/mana_en.c +8 -2
@@ -1383,8 +1383,8 @@ static void mana_post_pkt_rxq(struct mana_rxq *rxq) recv_buf_oob = &rxq->rx_oobs[curr_index]; - err =mana_gd_post_and_ring (rxq->gdma_rq, &recv_buf_oob->wqe_req, - &recv_buf_oob->wqe_inf); + err =mana_gd_post_work_request (rxq->gdma_rq, &recv_buf_oob->wqe_req, + &recv_buf_oob->wqe_inf);if (WARN_ON_ONCE (err))return ;
@@ -1654,6 +1654,12 @@ static void mana_poll_rx_cq(struct mana_cq *cq)mana_process_rx_cqe (rxq, cq, &comp[i]); } +if (comp_read >0 ) { +struct gdma_context *gc = rxq->gdma_rq->gdma_dev->gdma_context; + +mana_gd_wq_ring_doorbell (gc, rxq->gdma_rq); + } +if (rxq->xdp_flush)xdp_do_flush (); }
Signature · 1 line
2.34.1
PATCH v5 2/2 net: mana: Use the correct WQE count for ringing RQ doorbell
In reply to [email protected]From: Long Li <[email protected]>
The hardware specification specifies that WQE_COUNT should set to 0 for the Receive Queue. Although currently the hardware doesn't enforce the check, in the future releases it may check on this value.
---
Change log:
v4:
Split the original patch into two: one for batching doorbell, one for setting the correct wqe count
v5:
Drop Cc: stable and use net-next
drivers/net/ethernet/microsoft/mana/gdma_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/microsoft/mana/gdma_main.c +4 -1
@@ -300,8 +300,11 @@ static void mana_gd_ring_doorbell(struct gdma_context *gc, u32 db_index,void mana_gd_wq_ring_doorbell (struct gdma_context *gc,struct gdma_queue *queue) { +/* Hardware Spec specifies that software client should set 0 for +* wqe_cnt for Receive Queues. This value is not used in Send Queues. +*/ mana_gd_ring_doorbell (gc, queue->gdma_dev->doorbell, queue->type, - queue->id, queue->head *GDMA_WQE_BU_SIZE ,1 ); + queue->id, queue->head *GDMA_WQE_BU_SIZE ,0 ); }void mana_gd_ring_cq (struct gdma_queue *cq,u8 arm_bit)
Signature · 1 line
2.34.1
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 17 Jul 2023 12:35:37 -0700 you wrote:
From: Long Li <[email protected]>
This patchset fixes the issues discovered during 200G physical link tests. It fixes doorbell usage and WQE format for receive queues.
Long Li (2):
net: mana: Batch ringing RX queue doorbell on receiving packets
net: mana: Use the correct WQE count for ringing RQ doorbell[...]
Here is the summary with links:
- [net-next,v5,1/2] net: mana: Batch ringing RX queue doorbell on receiving packets
https://git.kernel.org/netdev/net-next/c/da4e8648079e - [net-next,v5,2/2] net: mana: Use the correct WQE count for ringing RQ doorbell https://git.kernel.org/netdev/net-next/c/f5e39b57124f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html