Skip to contentSkip to conversation

octeontx2-pf: Dont allocate BPIDs for LBK interfaces

PATCH Applied Geetha sowjanya 2 participants 2 messages Jul 16, 2023 – Jul 18, 2023

Subsystems (3)
lore
Share & tools
lore

Geetha sowjanya

author maintainer
#0 lore raw

PATCH 1/1 octeontx2-pf: Dont allocate BPIDs for LBK interfaces

Current driver enables backpressure for LBK interfaces. But these interfaces do not support this feature. Hence, this patch fixes the issue by skipping the backpressure configuration for these interfaces.

Fixes 75f36270990c ("octeontx2-pf: Support to enable/disable pause frames via ethtool").
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +3 -2
index fe8ea4e531b7..9551b422622a 100644
@@ -1454,8 +1454,9 @@ static int otx2_init_hw_resources(struct otx2_nic *pf)
 	if (err)
 		goto err_free_npa_lf;
 
-	/* Enable backpressure */
-	otx2_nix_config_bp(pf, true);
+	/* Enable backpressure for CGX mapped PF/VFs */
+	if (!is_otx2_lbkvf(pf->pdev))
+		otx2_nix_config_bp(pf, true);
 
 	/* Init Auras and pools used by NIX RQ, for free buffer ptrs */
 	err = otx2_rq_aura_pool_init(pf);
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:

Quoted 10 lines · On Sun, 16 Jul 2023 15:07:41 +0530 you wrote:

Current driver enables backpressure for LBK interfaces. But these interfaces do not support this feature. Hence, this patch fixes the issue by skipping the backpressure configuration for these interfaces.

Fixes 75f36270990c ("octeontx2-pf: Support to enable/disable pause frames via ethtool").

[...]

Here is the summary with links:
- [net] octeontx2-pf: Dont allocate BPIDs for LBK interfaces

    https://git.kernel.org/netdev/net/c/8fcd7c7b3a38

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html