Skip to contentSkip to conversation

bpf, x86: initialize the variable "first_off" in save_args()

PATCH Applied [email protected] 2 participants 2 messages Jul 19, 2023

Subsystems (5)
Networking Network drivers x86 BPF +1 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpf, x86: initialize the variable "first_off" in save_args()

From: Menglong Dong <[email protected]>

As Dan Carpenter reported, the variable "first_off" which is passed to clean_stack_garbage() in save_args() can be uninitialized, which can cause runtime warnings with KMEMsan. Therefore, init it with 0.

Fixes 473e3150e30a ("bpf, x86: allow function arguments up to 12 for TRACING")
Cc Hao Peng <[email protected]>
---
 arch/x86/net/bpf_jit_comp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/net/bpf_jit_comp.c +1 -1
index 5ab531be56ac..83c4b45dc65f 100644
@@ -1925,7 +1925,7 @@ static int get_nr_used_regs(const struct btf_func_model *m)
 static void save_args(const struct btf_func_model *m, u8 **prog,
 		      int stack_size, bool for_call_origin)
 {
-	int arg_regs, first_off, nr_regs = 0, nr_stack_slots = 0;
+	int arg_regs, first_off = 0, nr_regs = 0, nr_stack_slots = 0;
 	int i, j;
 
 	/* Store function arguments to stack.
Signature · 1 line
2.40.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 6 lines · On Wed, 19 Jul 2023 19:03:30 +0800 you wrote:

From: Menglong Dong <[email protected]>

As Dan Carpenter reported, the variable "first_off" which is passed to clean_stack_garbage() in save_args() can be uninitialized, which can cause runtime warnings with KMEMsan. Therefore, init it with 0.

Quoted 7 lines
Fixes 473e3150e30a ("bpf, x86: allow function arguments up to 12 for TRACING")
Cc Hao Peng <[email protected]>

[...]

Here is the summary with links:
- [bpf-next] bpf, x86: initialize the variable "first_off" in save_args()

    https://git.kernel.org/bpf/bpf-next/c/492e797fdab2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html