Skip to contentSkip to conversation

dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out

PATCH Applied Eugen Hristev 4 participants 4 messages Jul 18, 2023 – Jul 20, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out

'clock_in_out' property is optional, and it can be one of two enums. The binding does not specify what is the behavior when the property is missing altogether.
Hence, add a default value that the driver can use.

---
 Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +1 -0
index 176ea5f90251..bb943c96c196 100644
@@ -80,6 +80,7 @@ properties:
       "output" means GMAC provides the reference clock.
     $ref: /schemas/types.yaml#/definitions/string
     enum: [input, output]
+    default: input
 
   rockchip,grf:
     description: The phandle of the syscon node for the general register file.
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines · Eugen Hristev

'clock_in_out' property is optional, and it can be one of two enums. The binding does not specify what is the behavior when the property is missing altogether.
Hence, add a default value that the driver can use.

---

-- Sebastian

Quoted 21 lines
 Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +1 -0
index 176ea5f90251..bb943c96c196 100644
@@ -80,6 +80,7 @@ properties:
       "output" means GMAC provides the reference clock.
     $ref: /schemas/types.yaml#/definitions/string
     enum: [input, output]
+    default: input
 
   rockchip,grf:
     description: The phandle of the syscon node for the general register file.
Signature · 5 lines
2.34.1


-- 
To unsubscribe, send mail to [email protected].
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Eugen Hristev
Quoted 10 lines · Eugen Hristev

'clock_in_out' property is optional, and it can be one of two enums. The binding does not specify what is the behavior when the property is missing altogether.
Hence, add a default value that the driver can use.

---
 Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
 1 file changed, 1 insertion(+)
#3 lore raw
In reply to Eugen Hristev
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 18 Jul 2023 12:09:14 +0300 you wrote:

'clock_in_out' property is optional, and it can be one of two enums. The binding does not specify what is the behavior when the property is missing altogether.
Hence, add a default value that the driver can use.

[...]

Here is the summary with links:
- dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out

    https://git.kernel.org/netdev/net-next/c/51318bf44395

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html