tcp: tcp_enter_quickack_mode() should be static
Subsystems (3)
PATCH 1/1 tcp: tcp_enter_quickack_mode() should be static
After commit d2ccd7bc8acd ("tcp: avoid resetting ACK timer in DCTCP"), tcp_enter_quickack_mode() is only used from net/ipv4/tcp_input.c.
Fixes d2ccd7bc8acd ("tcp: avoid resetting ACK timer in DCTCP")
Signed-off-by Eric Dumazet <[email protected]>
Cc Yuchung Cheng <[email protected]>
Cc Neal Cardwell <[email protected]>
--- include/net/tcp.h | 1 - net/ipv4/tcp_input.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-)
include/net/tcp.h +0 -1
@@ -350,7 +350,6 @@ ssize_t tcp_splice_read(struct socket *sk, loff_t *ppos,struct sk_buff *tcp_stream_alloc_skb (struct sock *sk,gfp_t gfp,bool force_schedule); -void tcp_enter_quickack_mode (struct sock *sk,unsigned int max_quickacks);static inline void tcp_dec_quickack_mode (struct sock *sk,const unsigned int pkts) {
net/ipv4/tcp_input.c +1 -2
@@ -287,7 +287,7 @@ static void tcp_incr_quickack(struct sock *sk, unsigned int max_quickacks) icsk->icsk_ack.quick = quickacks; } -void tcp_enter_quickack_mode (struct sock *sk,unsigned int max_quickacks) +static void tcp_enter_quickack_mode (struct sock *sk,unsigned int max_quickacks) {struct inet_connection_sock *icsk =inet_csk (sk);
@@ -295,7 +295,6 @@ void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks)inet_csk_exit_pingpong_mode (sk); icsk->icsk_ack.ato =TCP_ATO_MIN ; } -EXPORT_SYMBOL (tcp_enter_quickack_mode);/* Send ACKs quickly, if "quick" count is not exhausted * and the session is not interactive.
Signature · 1 line
2.41.0.255.g8b1d071c50-goog
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Tue, 18 Jul 2023 16:20:49 +0000 you wrote:
After commit
d2ccd7bc8acd("tcp: avoid resetting ACK timer in DCTCP"),tcp_enter_quickack_mode()is only used fromnet/ipv4/tcp_input.c.Fixes d2ccd7bc8acd ("tcp: avoid resetting ACK timer in DCTCP")Signed-off-by Eric Dumazet <[email protected]>Cc Yuchung Cheng <[email protected]>Cc Neal Cardwell <[email protected]>[...]
Here is the summary with links:
- [net-next] tcp: tcp_enter_quickack_mode() should be static
https://git.kernel.org/netdev/net-next/c/03b123debcbc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html