Skip to contentSkip to conversation

Bluetooth: btbcm: add default address for BCM43430A1

PATCH Applied Mans Rullgard 3 participants 3 messages Jul 15, 2023 – Jul 20, 2023 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: btbcm: add default address for BCM43430A1

The BCM43430A1 has a default MAC address of AA:AA:AA:AA:AA:AA. Although, unlike some other entries, this does not include the chip name, it is clearly not a real address. This was found in AzureWave AW-NB197SM and AW-NM372SM modules.

---
 drivers/bluetooth/btbcm.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/bluetooth/btbcm.c +5 -0
index de2ea589aa49..0a5445ac5e1b 100644
@@ -24,6 +24,7 @@
 #define BDADDR_BCM20702A1 (&(bdaddr_t) {{0x00, 0x00, 0xa0, 0x02, 0x70, 0x20}})
 #define BDADDR_BCM2076B1 (&(bdaddr_t) {{0x79, 0x56, 0x00, 0xa0, 0x76, 0x20}})
 #define BDADDR_BCM43430A0 (&(bdaddr_t) {{0xac, 0x1f, 0x12, 0xa0, 0x43, 0x43}})
+#define BDADDR_BCM43430A1 (&(bdaddr_t) {{0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa}})
 #define BDADDR_BCM4324B3 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb3, 0x24, 0x43}})
 #define BDADDR_BCM4330B1 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb1, 0x30, 0x43}})
 #define BDADDR_BCM4334B0 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb0, 0x34, 0x43}})
@@ -115,6 +116,9 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
 	 *
 	 * The address 43:43:A0:12:1F:AC indicates a BCM43430A0 controller
 	 * with no configured address.
+	 *
+	 * The address AA:AA:AA:AA:AA:AA indicates a BCM43430A1 controller
+	 * with no configured address.
 	 */
 	if (!bacmp(&bda->bdaddr, BDADDR_BCM20702A0) ||
 	    !bacmp(&bda->bdaddr, BDADDR_BCM20702A1) ||
@@ -124,6 +128,7 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
 	    !bacmp(&bda->bdaddr, BDADDR_BCM4334B0) ||
 	    !bacmp(&bda->bdaddr, BDADDR_BCM4345C5) ||
 	    !bacmp(&bda->bdaddr, BDADDR_BCM43430A0) ||
+	    !bacmp(&bda->bdaddr, BDADDR_BCM43430A1) ||
 	    !bacmp(&bda->bdaddr, BDADDR_BCM43341B)) {
 		/* Try falling back to BDADDR EFI variable */
 		if (btbcm_set_bdaddr_from_efi(hdev) != 0) {
Signature · 1 line
2.41.0
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=766180

---Test result---

Test Summary:

CheckPatch                    PASS      0.62 seconds
GitLint                       PASS      0.23 seconds
SubjectPrefix                 PASS      0.06 seconds
BuildKernel                   PASS      45.50 seconds
CheckAllWarning               PASS      49.17 seconds
CheckSparse                   PASS      55.67 seconds
CheckSmatch                   PASS      146.86 seconds
BuildKernel32                 PASS      42.67 seconds
TestRunnerSetup               PASS      656.97 seconds
TestRunner_l2cap-tester       PASS      31.97 seconds
TestRunner_iso-tester         PASS      79.53 seconds
TestRunner_bnep-tester        PASS      14.41 seconds
TestRunner_mgmt-tester        PASS      260.56 seconds
TestRunner_rfcomm-tester      PASS      21.71 seconds
TestRunner_sco-tester         PASS      21.87 seconds
TestRunner_ioctl-tester       PASS      25.22 seconds
TestRunner_mesh-tester        PASS      18.57 seconds
TestRunner_smp-tester         PASS      19.30 seconds
TestRunner_userchan-tester    PASS      15.28 seconds
IncrementalBuild              PASS      40.10 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Mans Rullgard
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 8 lines · On Sat, 15 Jul 2023 17:41:59 +0100 you wrote:

The BCM43430A1 has a default MAC address of AA:AA:AA:AA:AA:AA. Although, unlike some other entries, this does not include the chip name, it is clearly not a real address. This was found in AzureWave AW-NB197SM and AW-NM372SM modules.

[...]

Here is the summary with links:
- Bluetooth: btbcm: add default address for BCM43430A1

    https://git.kernel.org/bluetooth/bluetooth-next/c/2d54008f4b68

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html