team: Remove NULL check before dev_{put, hold}
Subsystems (3)
PATCH 1/1 team: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
--- drivers/net/team/team.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/team/team.c +1 -2
@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info) ifindex =nla_get_u32 (info->attrs[TEAM_ATTR_TEAM_IFINDEX ]); dev =dev_get_by_index (net, ifindex);if (!dev || dev->netdev_ops != &team_netdev_ops) { -if (dev) -dev_put (dev); +dev_put (dev);return NULL ; }
Signature · 1 line
2.20.1.7.g153144c
Quoted 9 lines · Yang Li
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 11 lines · On Thu, 27 Jul 2023 08:57:41 +0800 you wrote:
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>[...]
Here is the summary with links:
- [net-next] team: Remove NULL check before dev_{put, hold}
https://git.kernel.org/netdev/net-next/c/64a37272fa5f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 9 lines · Yang Li
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning:
./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>
Quoted 21 lines
--- drivers/net/team/team.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/team/team.c +1
-2@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info) ifindex =nla_get_u32 (info->attrs[TEAM_ATTR_TEAM_IFINDEX ]); dev =dev_get_by_index (net, ifindex);if (!dev || dev->netdev_ops != &team_netdev_ops) { -if (dev) -dev_put (dev); +dev_put (dev);return NULL ; }Signature · 1 line
2.20.1.7.g153144c