Skip to contentSkip to conversation

net: bcmgenet: Remove TX ring full logging

PATCH Applied Florian Fainelli 3 participants 3 messages Jul 28, 2023 – Jul 31, 2023

Subsystems (3)
lore
Share & tools
lore

Florian Fainelli

author maintainer
#0 lore raw

PATCH 1/1 net: bcmgenet: Remove TX ring full logging

There is no need to spam the kernel log with such an indication, remove this message.

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/net/ethernet/broadcom/genet/bcmgenet.c +1 -5
index 2b5761ad2f92..24bade875ca6 100644
@@ -2077,12 +2077,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
 
 	spin_lock(&ring->lock);
 	if (ring->free_bds <= (nr_frags + 1)) {
-		if (!netif_tx_queue_stopped(txq)) {
+		if (!netif_tx_queue_stopped(txq))
 			netif_tx_stop_queue(txq);
-			netdev_err(dev,
-				   "%s: tx ring %d full when queue %d awake\n",
-				   __func__, index, ring->queue);
-		}
 		ret = NETDEV_TX_BUSY;
 		goto out;
 	}
Signature · 1 line
2.34.1
#2 lore raw
In reply to Florian Fainelli
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Fri, 28 Jul 2023 11:39:45 -0700 you wrote:

There is no need to spam the kernel log with such an indication, remove this message.

---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Here is the summary with links:
- [net-next] net: bcmgenet: Remove TX ring full logging

    https://git.kernel.org/netdev/net-next/c/df41fa677d9b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html