selftest: net: Assert on a proper value in so_incoming_cpu.c.
Subsystems (3)
PATCH 1/1 selftest: net: Assert on a proper value in so_incoming_cpu.c.
Dan Carpenter reported an error spotted by Smatch.
./tools/testing/selftests/net/so_incoming_cpu.c:163 create_clients()
error: uninitialized symbol 'ret'.
The returned value of sched_setaffinity() should be checked with ASSERT_EQ(), but the value was not saved in a proper variable, resulting in an error above.
Let's save the returned value of with sched_setaffinity().
--- tools/testing/selftests/net/so_incoming_cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/so_incoming_cpu.c +1 -1
@@ -159,7 +159,7 @@ void create_clients(struct __test_metadata *_metadata,/* Make sure SYN will be processed on the i-th CPU * and finally distributed to the i-th listener. */ -sched_setaffinity (0 ,sizeof (cpu_set), &cpu_set); + ret =sched_setaffinity (0 ,sizeof (cpu_set), &cpu_set);ASSERT_EQ (ret,0 );for (j =0 ; j <CLIENT_PER_SERVER ; j++) {
Signature · 1 line
2.30.2
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 31 Jul 2023 11:15:53 -0700 you wrote:
Dan Carpenter reported an error spotted by Smatch.
./tools/testing/selftests/net/so_incoming_cpu.c:163create_clients()
error: uninitialized symbol 'ret'.The returned value of
sched_setaffinity()should be checked withASSERT_EQ(), but the value was not saved in a proper variable, resulting in an error above.[...]
Here is the summary with links:
- [v1,net] selftest: net: Assert on a proper value in so_incoming_cpu.c.
https://git.kernel.org/netdev/net/c/3ff1617450ec
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html