Skip to contentSkip to conversation

net: dsa: hellcreek: Replace bogus comment

PATCH Applied Kurt Kanzenbach 3 participants 3 messages Aug 1, 2023 – Aug 2, 2023

Subsystems (4)
lore
Share & tools
lore

Kurt Kanzenbach

author maintainer
#0 lore raw

PATCH 1/1 net: dsa: hellcreek: Replace bogus comment

Replace bogus comment about matching the latched timestamp to one of the received frames. That comment is probably copied from mv88e6xxx and true for these switches. However, the hellcreek switch is configured to insert the timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as well, because it doesn't add any value.

---
 drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c +1 -8
index ffd06cf8c44f..bd7aacc71a63 100644
@@ -298,17 +298,10 @@ static void hellcreek_get_rxts(struct hellcreek *hellcreek,
 	struct sk_buff_head received;
 	unsigned long flags;
 
-	/* The latched timestamp belongs to one of the received frames. */
+	/* Construct Rx timestamps for all received PTP packets. */
 	__skb_queue_head_init(&received);
-
-	/* Lock & disable interrupts */
 	spin_lock_irqsave(&rxq->lock, flags);
-
-	/* Add the reception queue "rxq" to the "received" queue an reintialize
-	 * "rxq".  From now on, we deal with "received" not with "rxq"
-	 */
 	skb_queue_splice_tail_init(rxq, &received);
-
 	spin_unlock_irqrestore(&rxq->lock, flags);
 
 	for (; skb; skb = __skb_dequeue(&received)) {
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kurt Kanzenbach

Replace bogus comment about matching the latched timestamp to one of the received frames. That comment is probably copied from mv88e6xxx and true for these switches. However, the hellcreek switch is configured to insert the timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as well, because it doesn't add any value.

---

#2 lore raw
In reply to Kurt Kanzenbach
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 1 Aug 2023 15:16:47 +0200 you wrote:

Replace bogus comment about matching the latched timestamp to one of the received frames. That comment is probably copied from mv88e6xxx and true for these switches. However, the hellcreek switch is configured to insert the timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as well, because it doesn't add any value.

[...]

Here is the summary with links:
- [net-next] net: dsa: hellcreek: Replace bogus comment

    https://git.kernel.org/netdev/net-next/c/ae3683a34265

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html