Skip to contentSkip to conversation

ss: report when the RxNoPad optimization is set on TLS sockets

PATCH Applied Jakub Kicinski 2 participants 2 messages Jul 31, 2023 – Aug 3, 2023

Subsystems (2)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 ss: report when the RxNoPad optimization is set on TLS sockets

Similarly to RO ZC report when RxNoPad is set.

---
 misc/ss.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
misc/ss.c +4 -7
index e9d813596b91..c71b08f98525 100644
@@ -2983,12 +2983,6 @@ static void tcp_tls_conf(const char *name, struct rtattr *attr)
 	}
 }
 
-static void tcp_tls_zc_sendfile(struct rtattr *attr)
-{
-	if (attr)
-		out(" zc_ro_tx");
-}
-
 static void mptcp_subflow_info(struct rtattr *tb[])
 {
 	u_int32_t flags = 0;
@@ -3219,7 +3213,10 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
 			tcp_tls_cipher(tlsinfo[TLS_INFO_CIPHER]);
 			tcp_tls_conf("rxconf", tlsinfo[TLS_INFO_RXCONF]);
 			tcp_tls_conf("txconf", tlsinfo[TLS_INFO_TXCONF]);
-			tcp_tls_zc_sendfile(tlsinfo[TLS_INFO_ZC_RO_TX]);
+			if (!!tlsinfo[TLS_INFO_ZC_RO_TX])
+				out(" zc_ro_tx");
+			if (!!tlsinfo[TLS_INFO_RX_NO_PAD])
+				out(" no_pad_rx");
 		}
 		if (ulpinfo[INET_ULP_INFO_MPTCP]) {
 			struct rtattr *sfinfo[MPTCP_SUBFLOW_ATTR_MAX + 1] =
Signature · 1 line
2.41.0
#1 lore raw
This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Hello:

This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <[email protected]>:

Quoted 6 lines · On Mon, 31 Jul 2023 08:06:28 -0700 you wrote:

Similarly to RO ZC report when RxNoPad is set.

---
 misc/ss.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

Here is the summary with links:
- [iproute2-next] ss: report when the RxNoPad optimization is set on TLS sockets

    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=109ddfb4e525

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html