bpf: bpf_struct_ops: Remove unnecessary initial values of variables
Subsystems (3)
PATCH v2 1/1 bpf: bpf_struct_ops: Remove unnecessary initial values of variables
err and tlinks is assigned first, so it does not need to initialize the assignment.
Signed-off-by Li kunyu <[email protected]>
---
v2:
Remove tlinks initialization assignment.
kernel/bpf/bpf_struct_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/bpf/bpf_struct_ops.c +3 -3
@@ -374,9 +374,9 @@ static long bpf_struct_ops_map_update_elem(struct bpf_map *map, void *key,struct bpf_struct_ops_value *uvalue, *kvalue;const struct btf_member *member;const struct btf_type *t = st_ops->type; -struct bpf_tramp_links *tlinks =NULL ; +struct bpf_tramp_links *tlinks;void *udata, *kdata; -int prog_fd, err =0 ; +int prog_fd, err;void *image, *image_end;u32 i;
@@ -818,7 +818,7 @@ static int bpf_struct_ops_map_link_update(struct bpf_link *link, struct bpf_mapstruct bpf_struct_ops_map *st_map, *old_st_map;struct bpf_map *old_map;struct bpf_struct_ops_link *st_link; -int err =0 ; +int err; st_link = container_of(link, struct bpf_struct_ops_link, link); st_map = container_of(new_map, struct bpf_struct_ops_map, map);
Signature · 1 line
2.18.2
Quoted 4 lines · Li kunyu
err and tlinks is assigned first, so it does not need to initialize the assignment.
Signed-off-by Li kunyu <[email protected]>
Reviewed-by Simon Horman <[email protected]>
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Quoted 9 lines · On Sat, 5 Aug 2023 01:59:29 +0800 you wrote:
err and tlinks is assigned first, so it does not need to initialize the assignment.
Signed-off-by Li kunyu <[email protected]>---
v2:
Remove tlinks initialization assignment.[...]
Here is the summary with links:
- [bpf-next,v2] bpf: bpf_struct_ops: Remove unnecessary initial values of variables
https://git.kernel.org/bpf/bpf-next/c/5964d1e4594e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html