Skip to contentSkip to conversation

platform/chrome: chromeos_acpi: support official HID GOOG0016

PATCH Applied Tzung-Bi Shih 5 participants 6 messages Jul 31, 2023 – Aug 8, 2023

Subsystems (3)
lore
Share & tools
lore

Tzung-Bi Shih

author maintainer
#0 lore raw

PATCH v3 1/1 platform/chrome: chromeos_acpi: support official HID GOOG0016

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

Changes from v1[3]:
- Preserve the PNP ID GGL0001 for backward compatible to older firmwares.
- Modify commit title and message accordingly.

[2]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/
[3]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/

 .../ABI/testing/sysfs-driver-chromeos-acpi        | 15 +++++++++++++++
 .../firmware-guide/acpi/chromeos-acpi-device.rst  |  5 ++---
 drivers/platform/chrome/chromeos_acpi.c           |  2 +-
 3 files changed, 18 insertions(+), 4 deletions(-)
Documentation/ABI/testing/sysfs-driver-chromeos-acpi +15 -0
index c308926e1568..22082f9a7922 100644
@@ -1,4 +1,5 @@
 What:		/sys/bus/platform/devices/GGL0001:*/BINF.2
+		/sys/bus/platform/devices/GOOG0016:*/BINF.2
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -10,6 +11,7 @@ Description:
 		== ===============================
 
 What:		/sys/bus/platform/devices/GGL0001:*/BINF.3
+		/sys/bus/platform/devices/GOOG0016:*/BINF.3
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -23,6 +25,7 @@ Description:
 		== =====================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/CHSW
+		/sys/bus/platform/devices/GOOG0016:*/CHSW
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -38,6 +41,7 @@ Description:
 		==== ===========================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/FMAP
+		/sys/bus/platform/devices/GOOG0016:*/FMAP
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -45,6 +49,7 @@ Description:
 		processor firmware flashmap.
 
 What:		/sys/bus/platform/devices/GGL0001:*/FRID
+		/sys/bus/platform/devices/GOOG0016:*/FRID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -52,6 +57,7 @@ Description:
 		main processor firmware.
 
 What:		/sys/bus/platform/devices/GGL0001:*/FWID
+		/sys/bus/platform/devices/GOOG0016:*/FWID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -59,6 +65,7 @@ Description:
 		main processor firmware.
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.0
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.0
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -73,6 +80,7 @@ Description:
 		=========== ==================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.1
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.1
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -84,6 +92,7 @@ Description:
 		== =======================
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.2
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.2
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -91,18 +100,21 @@ Description:
 		controller.
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.3
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.3
 Date:		May 2022
 KernelVersion:	5.19
 Description:
 		Returns name of the GPIO controller.
 
 What:		/sys/bus/platform/devices/GGL0001:*/HWID
+		/sys/bus/platform/devices/GOOG0016:*/HWID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
 		Returns hardware ID for the Chromebook.
 
 What:		/sys/bus/platform/devices/GGL0001:*/MECK
+		/sys/bus/platform/devices/GOOG0016:*/MECK
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -113,6 +125,7 @@ Description:
 		present, or if the firmware was unable to read the extended registers, this buffer size can be zero.
 
 What:		/sys/bus/platform/devices/GGL0001:*/VBNV.0
+		/sys/bus/platform/devices/GOOG0016:*/VBNV.0
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -122,6 +135,7 @@ Description:
 		clock data).
 
 What:		/sys/bus/platform/devices/GGL0001:*/VBNV.1
+		/sys/bus/platform/devices/GOOG0016:*/VBNV.1
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -129,6 +143,7 @@ Description:
 		storage block.
 
 What:		/sys/bus/platform/devices/GGL0001:*/VDAT
+		/sys/bus/platform/devices/GOOG0016:*/VDAT
 Date:		May 2022
 KernelVersion:	5.19
 Description:
Documentation/firmware-guide/acpi/chromeos-acpi-device.rst +2 -3
index f37fc90ce340..89419e116413 100644
@@ -5,9 +5,8 @@ Chrome OS ACPI Device
 =====================
 
 Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device.
-The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google.
-PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI
-objects are supported:
+The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is
+GOOG0016.  The following ACPI objects are supported:
 
 .. flat-table:: Supported ACPI Objects
    :widths: 1 2
drivers/platform/chrome/chromeos_acpi.c +1 -1
index 50d8a4d4352d..1cc01d893ada 100644
@@ -235,9 +235,9 @@ static int chromeos_acpi_device_probe(struct platform_device *pdev)
 	return 0;
 }
 
-/* GGL is valid PNP ID of Google. PNP ID can be used with the ACPI devices. */
 static const struct acpi_device_id chromeos_device_ids[] = {
 	{ "GGL0001", 0 },
+	{ "GOOG0016", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(acpi, chromeos_device_ids);
Signature · 1 line
2.41.0.487.g6d72f3e995-goog
Reviewed-by on v3 1/1
#1 lore raw
Quoted 5 lines · Tzung-Bi Shih

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

Quoted 167 lines

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

Changes from v1[3]:
- Preserve the PNP ID GGL0001 for backward compatible to older firmwares.
- Modify commit title and message accordingly.

[2]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/
[3]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/

 .../ABI/testing/sysfs-driver-chromeos-acpi        | 15 +++++++++++++++
 .../firmware-guide/acpi/chromeos-acpi-device.rst  |  5 ++---
 drivers/platform/chrome/chromeos_acpi.c           |  2 +-
 3 files changed, 18 insertions(+), 4 deletions(-)
Documentation/ABI/testing/sysfs-driver-chromeos-acpi +15 -0
index c308926e1568..22082f9a7922 100644
@@ -1,4 +1,5 @@
 What:		/sys/bus/platform/devices/GGL0001:*/BINF.2
+		/sys/bus/platform/devices/GOOG0016:*/BINF.2
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -10,6 +11,7 @@ Description:
 		== ===============================
 
 What:		/sys/bus/platform/devices/GGL0001:*/BINF.3
+		/sys/bus/platform/devices/GOOG0016:*/BINF.3
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -23,6 +25,7 @@ Description:
 		== =====================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/CHSW
+		/sys/bus/platform/devices/GOOG0016:*/CHSW
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -38,6 +41,7 @@ Description:
 		==== ===========================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/FMAP
+		/sys/bus/platform/devices/GOOG0016:*/FMAP
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -45,6 +49,7 @@ Description:
 		processor firmware flashmap.
 
 What:		/sys/bus/platform/devices/GGL0001:*/FRID
+		/sys/bus/platform/devices/GOOG0016:*/FRID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -52,6 +57,7 @@ Description:
 		main processor firmware.
 
 What:		/sys/bus/platform/devices/GGL0001:*/FWID
+		/sys/bus/platform/devices/GOOG0016:*/FWID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -59,6 +65,7 @@ Description:
 		main processor firmware.
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.0
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.0
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -73,6 +80,7 @@ Description:
 		=========== ==================================
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.1
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.1
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -84,6 +92,7 @@ Description:
 		== =======================
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.2
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.2
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -91,18 +100,21 @@ Description:
 		controller.
 
 What:		/sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.3
+		/sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.3
 Date:		May 2022
 KernelVersion:	5.19
 Description:
 		Returns name of the GPIO controller.
 
 What:		/sys/bus/platform/devices/GGL0001:*/HWID
+		/sys/bus/platform/devices/GOOG0016:*/HWID
 Date:		May 2022
 KernelVersion:	5.19
 Description:
 		Returns hardware ID for the Chromebook.
 
 What:		/sys/bus/platform/devices/GGL0001:*/MECK
+		/sys/bus/platform/devices/GOOG0016:*/MECK
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -113,6 +125,7 @@ Description:
 		present, or if the firmware was unable to read the extended registers, this buffer size can be zero.
 
 What:		/sys/bus/platform/devices/GGL0001:*/VBNV.0
+		/sys/bus/platform/devices/GOOG0016:*/VBNV.0
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -122,6 +135,7 @@ Description:
 		clock data).
 
 What:		/sys/bus/platform/devices/GGL0001:*/VBNV.1
+		/sys/bus/platform/devices/GOOG0016:*/VBNV.1
 Date:		May 2022
 KernelVersion:	5.19
 Description:
@@ -129,6 +143,7 @@ Description:
 		storage block.
 
 What:		/sys/bus/platform/devices/GGL0001:*/VDAT
+		/sys/bus/platform/devices/GOOG0016:*/VDAT
 Date:		May 2022
 KernelVersion:	5.19
 Description:
Documentation/firmware-guide/acpi/chromeos-acpi-device.rst +2 -3
index f37fc90ce340..89419e116413 100644
@@ -5,9 +5,8 @@ Chrome OS ACPI Device
 =====================
 
 Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device.
-The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google.
-PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI
-objects are supported:
+The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is
+GOOG0016.  The following ACPI objects are supported:
 
 .. flat-table:: Supported ACPI Objects
    :widths: 1 2
drivers/platform/chrome/chromeos_acpi.c +1 -1
index 50d8a4d4352d..1cc01d893ada 100644
@@ -235,9 +235,9 @@ static int chromeos_acpi_device_probe(struct platform_device *pdev)
 	return 0;
 }
 
-/* GGL is valid PNP ID of Google. PNP ID can be used with the ACPI devices. */
 static const struct acpi_device_id chromeos_device_ids[] = {
 	{ "GGL0001", 0 },
+	{ "GOOG0016", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(acpi, chromeos_device_ids);
Signature · 2 lines
BR,
Muhammad Usama Anjum
Reviewed-by
#2 lore raw
Quoted 24 lines · Muhammad Usama Anjum
Quoted 5 lines · Tzung-Bi Shih

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

Quoted 15 lines

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

Changes from v1[3]:
- Preserve the PNP ID GGL0001 for backward compatible to older firmwares.
- Modify commit title and message accordingly.

[2]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/
[3]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/

 .../ABI/testing/sysfs-driver-chromeos-acpi        | 15 +++++++++++++++
 .../firmware-guide/acpi/chromeos-acpi-device.rst  |  5 ++---
 drivers/platform/chrome/chromeos_acpi.c           |  2 +-
 3 files changed, 18 insertions(+), 4 deletions(-)
Reviewed-by on v3 1/1
#3 lore raw
In reply to Tzung-Bi Shih
Quoted 6 lines · Tzung-Bi Shih

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

Quoted 170 lines

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

Changes from v1[3]:
- Preserve the PNP ID GGL0001 for backward compatible to older firmwares.
- Modify commit title and message accordingly.

[2]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/
[3]: https://patchwork.kernel.org/project/chrome-platform/patch/[email protected]/

 .../ABI/testing/sysfs-driver-chromeos-acpi        | 15 +++++++++++++++
 .../firmware-guide/acpi/chromeos-acpi-device.rst  |  5 ++---
 drivers/platform/chrome/chromeos_acpi.c           |  2 +-
 3 files changed, 18 insertions(+), 4 deletions(-)
Documentation/ABI/testing/sysfs-driver-chromeos-acpi +15 -0
index c308926e1568..22082f9a7922 100644
@@ -1,4 +1,5 @@
 What:          /sys/bus/platform/devices/GGL0001:*/BINF.2
+               /sys/bus/platform/devices/GOOG0016:*/BINF.2
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -10,6 +11,7 @@ Description:
                == ===============================
 
 What:          /sys/bus/platform/devices/GGL0001:*/BINF.3
+               /sys/bus/platform/devices/GOOG0016:*/BINF.3
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -23,6 +25,7 @@ Description:
                == =====================================
 
 What:          /sys/bus/platform/devices/GGL0001:*/CHSW
+               /sys/bus/platform/devices/GOOG0016:*/CHSW
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -38,6 +41,7 @@ Description:
                ==== ===========================================
 
 What:          /sys/bus/platform/devices/GGL0001:*/FMAP
+               /sys/bus/platform/devices/GOOG0016:*/FMAP
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -45,6 +49,7 @@ Description:
                processor firmware flashmap.
 
 What:          /sys/bus/platform/devices/GGL0001:*/FRID
+               /sys/bus/platform/devices/GOOG0016:*/FRID
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -52,6 +57,7 @@ Description:
                main processor firmware.
 
 What:          /sys/bus/platform/devices/GGL0001:*/FWID
+               /sys/bus/platform/devices/GOOG0016:*/FWID
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -59,6 +65,7 @@ Description:
                main processor firmware.
 
 What:          /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.0
+               /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.0
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -73,6 +80,7 @@ Description:
                =========== ==================================
 
 What:          /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.1
+               /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.1
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -84,6 +92,7 @@ Description:
                == =======================
 
 What:          /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.2
+               /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.2
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -91,18 +100,21 @@ Description:
                controller.
 
 What:          /sys/bus/platform/devices/GGL0001:*/GPIO.X/GPIO.3
+               /sys/bus/platform/devices/GOOG0016:*/GPIO.X/GPIO.3
 Date:          May 2022
 KernelVersion: 5.19
 Description:
                Returns name of the GPIO controller.
 
 What:          /sys/bus/platform/devices/GGL0001:*/HWID
+               /sys/bus/platform/devices/GOOG0016:*/HWID
 Date:          May 2022
 KernelVersion: 5.19
 Description:
                Returns hardware ID for the Chromebook.
 
 What:          /sys/bus/platform/devices/GGL0001:*/MECK
+               /sys/bus/platform/devices/GOOG0016:*/MECK
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -113,6 +125,7 @@ Description:
                present, or if the firmware was unable to read the extended registers, this buffer size can be zero.
 
 What:          /sys/bus/platform/devices/GGL0001:*/VBNV.0
+               /sys/bus/platform/devices/GOOG0016:*/VBNV.0
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -122,6 +135,7 @@ Description:
                clock data).
 
 What:          /sys/bus/platform/devices/GGL0001:*/VBNV.1
+               /sys/bus/platform/devices/GOOG0016:*/VBNV.1
 Date:          May 2022
 KernelVersion: 5.19
 Description:
@@ -129,6 +143,7 @@ Description:
                storage block.
 
 What:          /sys/bus/platform/devices/GGL0001:*/VDAT
+               /sys/bus/platform/devices/GOOG0016:*/VDAT
 Date:          May 2022
 KernelVersion: 5.19
 Description:
Documentation/firmware-guide/acpi/chromeos-acpi-device.rst +2 -3
index f37fc90ce340..89419e116413 100644
@@ -5,9 +5,8 @@ Chrome OS ACPI Device
 =====================
 
 Hardware functionality specific to Chrome OS is exposed through a Chrome OS ACPI device.
-The plug and play ID of a Chrome OS ACPI device is GGL0001. GGL is a valid PNP ID of Google.
-PNP ID can be used with the ACPI devices according to the guidelines. The following ACPI
-objects are supported:
+The plug and play ID of a Chrome OS ACPI device is GGL0001 and the hardware ID is
+GOOG0016.  The following ACPI objects are supported:
 
 .. flat-table:: Supported ACPI Objects
    :widths: 1 2
drivers/platform/chrome/chromeos_acpi.c +1 -2
index 50d8a4d4352d..1cc01d893ada 100644
@@ -235,9 +235,9 @@ static int chromeos_acpi_device_probe(struct platform_device *pdev)
        return 0;
 }
 
-/* GGL is valid PNP ID of Google. PNP ID can be used with the ACPI devices. */
 static const struct acpi_device_id chromeos_device_ids[] = {
        { "GGL0001", 0 },
+       { "GOOG0016", 0 },
        {}
 };
 MODULE_DEVICE_TABLE(acpi, chromeos_device_ids);
--

2.41.0.487.g6d72f3e995-goog

#4 lore raw
In reply to Tzung-Bi Shih
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Mon, 31 Jul 2023 10:42:14 +0800 you wrote:

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

[...]

Here is the summary with links:
- [v3] platform/chrome: chromeos_acpi: support official HID GOOG0016

    https://git.kernel.org/chrome-platform/c/703e77134ebf

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#5 lore raw
In reply to Tzung-Bi Shih
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Quoted 10 lines · On Mon, 31 Jul 2023 10:42:14 +0800 you wrote:

Support official HID GOOG0016 for ChromeOS ACPI (see [1]).

[1]: https://crrev.com/c/2266713

---
Changes from v2[2]:
- Instead of replacing, appending "GOOG0016" in sysfs-driver-chromeos-acpi.

[...]

Here is the summary with links:
- [v3] platform/chrome: chromeos_acpi: support official HID GOOG0016

    https://git.kernel.org/chrome-platform/c/703e77134ebf

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html