Skip to contentSkip to conversation

devlink: clear flag on port register error path

PATCH Applied Jiri Pirko 3 participants 3 messages Aug 8, 2023 – Aug 9, 2023

Subsystems (3)
lore
Share & tools
lore

Jiri Pirko

author maintainer
#0 lore raw

PATCH 1/1 devlink: clear flag on port register error path

From: Jiri Pirko <[email protected]>

When xarray insertion fails, clear the flag.

Fixes 47b438cc2725 ("net: devlink: convert port_list into xarray")
---
 net/devlink/leftover.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
net/devlink/leftover.c +3 -1
index 0a9b49dfeb61..5568992a1a90 100644
@@ -6840,8 +6840,10 @@ int devl_port_register_with_ops(struct devlink *devlink,
 	spin_lock_init(&devlink_port->type_lock);
 	INIT_LIST_HEAD(&devlink_port->reporter_list);
 	err = xa_insert(&devlink->ports, port_index, devlink_port, GFP_KERNEL);
-	if (err)
+	if (err) {
+		devlink_port->registered = false;
 		return err;
+	}
 
 	INIT_DELAYED_WORK(&devlink_port->type_warn_dw, &devlink_port_type_warn);
 	devlink_port_type_warn_schedule(devlink_port);
Signature · 1 line
2.41.0
#2 lore raw
In reply to Jiri Pirko
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 8 Aug 2023 10:20:20 +0200 you wrote:

From: Jiri Pirko <[email protected]>

When xarray insertion fails, clear the flag.

Fixes 47b438cc2725 ("net: devlink: convert port_list into xarray")

[...]

Here is the summary with links:
- [net-next] devlink: clear flag on port register error path

    https://git.kernel.org/netdev/net-next/c/832140804e3b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html