Skip to contentSkip to conversation

RDMA/bnxt_re: Bug fixes

PATCH Applied Selvin Xavier 2 participants 5 messages Aug 10, 2023

Subsystems (2)
lore
Share & tools
lore

Selvin Xavier

author maintainer
#0 lore raw

cover RDMA/bnxt_re: Bug fixes

Includes few bug fixes in the driver.
Please review and apply.

Thanks,
Selvin

Kalesh AP (1):
RDMA/bnxt_re: Fix error handling in probe failure path

Kashyap Desai (1):
RDMA/bnxt_re: Initialize dpi_tbl_lock mutex

Selvin Xavier (1):
RDMA/bnxt_re: Fix ib device unalloc

 drivers/infiniband/hw/bnxt_re/main.c      | 4 +++-
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.5.5
author maintainer
#1 lore raw

PATCH 1/3 RDMA/bnxt_re: Fix ib device unalloc

ib_dealloc_device should be called only after device cleanup. Fix the dealloc sequence.

Fixes 6d758147c7b8 ("RDMA/bnxt_re: Use auxiliary driver interface")
---
 drivers/infiniband/hw/bnxt_re/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/bnxt_re/main.c +1 -1
index b42166f..1c76460 100644
@@ -1526,8 +1526,8 @@ static void bnxt_re_remove(struct auxiliary_device *adev)
 	}
 	bnxt_re_setup_cc(rdev, false);
 	ib_unregister_device(&rdev->ibdev);
-	ib_dealloc_device(&rdev->ibdev);
 	bnxt_re_dev_uninit(rdev);
+	ib_dealloc_device(&rdev->ibdev);
 skip_remove:
 	mutex_unlock(&bnxt_re_mutex);
 }
Signature · 1 line
2.5.5
author maintainer
#2 lore raw

PATCH 2/3 RDMA/bnxt_re: Fix error handling in probe failure path

In reply to Selvin Xavier

From: Kalesh AP <[email protected]>

During bnxt_re_dev_init(), when bnxt_re_setup_chip_ctx() fails unregister with L2 first before bailing out probe.

Fixes ae8637e13185 ("RDMA/bnxt_re: Add chip context to identify 57500 series")
---
 drivers/infiniband/hw/bnxt_re/main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/infiniband/hw/bnxt_re/main.c +2 -0
index 1c76460..63e98e2 100644
@@ -1253,6 +1253,8 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode)
 
 	rc = bnxt_re_setup_chip_ctx(rdev, wqe_mode);
 	if (rc) {
+		bnxt_unregister_dev(rdev->en_dev);
+		clear_bit(BNXT_RE_FLAG_NETDEV_REGISTERED, &rdev->flags);
 		ibdev_err(&rdev->ibdev, "Failed to get chip context\n");
 		return -EINVAL;
 	}
Signature · 1 line
2.5.5
author maintainer
#3 lore raw

PATCH 3/3 RDMA/bnxt_re: Initialize dpi_tbl_lock mutex

In reply to Selvin Xavier

From: Kashyap Desai <[email protected]>

Fix the missing dpi_tbl_lock mutex initialization

Fixes 0ac20faf5d83 ("RDMA/bnxt_re: Reorg the bar mapping")
---
 drivers/infiniband/hw/bnxt_re/qplib_res.c | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/hw/bnxt_re/qplib_res.c +1 -0
index 5fd8f7c..739d942 100644
@@ -819,6 +819,7 @@ static int bnxt_qplib_alloc_dpi_tbl(struct bnxt_qplib_res *res,
 	}
 
 	memset((u8 *)dpit->tbl, 0xFF, bytes);
+	mutex_init(&res->dpi_tbl_lock);
 	dpit->priv_db = dpit->ucreg.bar_reg + dpit->ucreg.offset;
 
 	return 0;
Signature · 1 line
2.5.5
maintainer Applied
#4 lore raw
In reply to Selvin Xavier
Quoted 6 lines · Selvin Xavier

Includes few bug fixes in the driver.
Please review and apply.

Thanks,
Selvin

Quoted 8 lines

Kalesh AP (1):
RDMA/bnxt_re: Fix error handling in probe failure path

Kashyap Desai (1):
RDMA/bnxt_re: Initialize dpi_tbl_lock mutex

Selvin Xavier (1):
RDMA/bnxt_re: Fix ib device unalloc

Applied to for-rc, thanks

Jason