Skip to contentSkip to conversation

Remove use and definition of RTE_STD_C11 macro

PATCH In review Tyler Retzlaff 5 participants 39 messages Aug 11, 2023 – Aug 31, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Remove use and definition of RTE_STD_C11 macro

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

Tyler Retzlaff (32):
timer: remove use of RTE STD C11 macro
stack: remove use of RTE STD C11 macro
security: remove use of RTE STD C11 macro
sched: remove use of RTE STD C11 macro
ring: remove use of RTE STD C11 macro
regexdev: remove use of RTE STD C11 macro
rawdev: remove use of RTE STD C11 macro
power: remove use of RTE STD C11 macro
pipeline: remove use of RTE STD C11 macro
net: remove use of RTE STD C11 macro
mldev: remove use of RTE STD C11 macro
mempool: remove use of RTE STD C11 macro
mbuf: remove use of RTE STD C11 macro
ip_frag: remove use of RTE STD C11 macro
hash: remove use of RTE STD C11 macro
graph: remove use of RTE STD C11 macro
eventdev: remove use of RTE STD C11 macro
ethdev: remove use of RTE STD C11 macro
dmadev: remove use of RTE STD C11 macro
cryptodev: remove use of RTE STD C11 macro examples/ipsec-secgw: remove use of RTE STD C11 macro examples/ip_pipeline: remove use of RTE STD C11 macro net/sfc: remove use of RTE STD C11 macro net/octeontx: remove use of RTE STD C11 macro net/mlx5: remove use of RTE STD C11 macro net/mlx4: remove use of RTE STD C11 macro net/igc: remove use of RTE STD C11 macro net/avp: remove use of RTE STD C11 macro dma/idxd: remove use of RTE STD C11 macro common/mlx5: remove use of RTE STD C11 macro common/cnxk: remove use of RTE STD C11 macro
eal: remove use and definition of RTE STD C11 macro

 drivers/common/cnxk/hw/nix.h            |  7 -------
 drivers/common/cnxk/roc_nix.h           |  1 -
 drivers/common/cnxk/roc_npc.h           |  3 ---
 drivers/common/cnxk/roc_platform.h      |  1 -
 drivers/common/mlx5/mlx5_common_mp.h    |  2 --
 drivers/dma/idxd/idxd_hw_defs.h         |  1 -
 drivers/net/avp/rte_avp_common.h        |  2 --
 drivers/net/igc/igc_ethdev.h            |  2 --
 drivers/net/mlx4/mlx4.h                 |  1 -
 drivers/net/mlx5/mlx5.h                 |  4 ----
 drivers/net/octeontx/octeontx_rxtx.h    |  2 --
 drivers/net/sfc/sfc_flow.h              |  2 --
 drivers/net/sfc/sfc_mae.h               |  1 -
 drivers/net/sfc/sfc_stats.h             |  1 -
 examples/ip_pipeline/pipeline.h         |  2 --
 examples/ip_pipeline/thread.c           |  2 --
 examples/ipsec-secgw/event_helper.h     |  2 --
 examples/ipsec-secgw/flow.c             |  1 -
 lib/cryptodev/cryptodev_pmd.h           |  2 +-
 lib/cryptodev/rte_crypto_asym.h         |  4 ----
 lib/cryptodev/rte_crypto_sym.h          |  3 ---
 lib/cryptodev/rte_cryptodev.h           |  2 --
 lib/dmadev/rte_dmadev.h                 |  1 -
 lib/eal/common/eal_common_proc.c        |  1 -
 lib/eal/common/eal_interrupts.h         |  1 -
 lib/eal/common/malloc_mp.h              |  2 --
 lib/eal/include/generic/rte_atomic.h    |  2 --
 lib/eal/include/rte_common.h            |  7 -------
 lib/eal/include/rte_devargs.h           |  1 -
 lib/eal/include/rte_memory.h            |  2 --
 lib/eal/include/rte_memzone.h           |  1 -
 lib/eal/linux/eal_vfio.h                |  1 -
 lib/eal/x86/include/rte_atomic_32.h     |  1 -
 lib/eal/x86/include/rte_cycles.h        |  1 -
 lib/ethdev/rte_flow.h                   | 11 -----------
 lib/ethdev/rte_mtr.h                    |  1 -
 lib/ethdev/rte_tm.h                     |  3 ---
 lib/eventdev/event_timer_adapter_pmd.h  |  1 -
 lib/eventdev/eventdev_pmd.h             |  2 --
 lib/eventdev/rte_event_eth_rx_adapter.c |  1 -
 lib/eventdev/rte_event_timer_adapter.h  |  2 --
 lib/eventdev/rte_eventdev.h             |  1 -
 lib/graph/rte_graph.h                   |  3 ---
 lib/graph/rte_graph_worker_common.h     |  4 ----
 lib/hash/rte_thash.h                    |  2 --
 lib/ip_frag/ip_reassembly.h             |  1 -
 lib/mbuf/rte_mbuf_core.h                |  4 ----
 lib/mempool/rte_mempool.h               |  1 -
 lib/mldev/rte_mldev.h                   |  1 -
 lib/net/rte_ecpri.h                     |  3 ---
 lib/net/rte_higig.h                     |  1 -
 lib/net/rte_l2tpv2.h                    |  2 --
 lib/pipeline/rte_pipeline.h             |  1 -
 lib/pipeline/rte_swx_ipsec.h            |  1 -
 lib/pipeline/rte_table_action.h         |  4 ----
 lib/power/rte_power.h                   |  2 --
 lib/rawdev/rte_rawdev.h                 |  1 -
 lib/regexdev/rte_regexdev.h             |  4 ----
 lib/ring/rte_ring_core.h                |  3 ---
 lib/sched/rte_sched.c                   |  2 --
 lib/security/rte_security.h             |  5 -----
 lib/stack/rte_stack.h                   |  1 -
 lib/timer/rte_timer.h                   |  1 -
 63 files changed, 1 insertion(+), 137 deletions(-)
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/32 timer: remove use of RTE STD C11 macro

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/timer/rte_timer.h | 1 -
 1 file changed, 1 deletion(-)
lib/timer/rte_timer.h +0 -1
index c8710c4..d3927d5 100644
@@ -64,7 +64,6 @@ enum rte_timer_type {
  * config) and an owner (the id of the lcore that owns the timer).
  */
 union rte_timer_status {
-	RTE_STD_C11
 	struct {
 		uint16_t state;  /**< Stop, pending, running, config. */
 		int16_t owner;   /**< The lcore that owns the timer. */
Signature · 1 line
1.8.3.1
#2 lore raw

PATCH 2/32 stack: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/stack/rte_stack.h | 1 -
 1 file changed, 1 deletion(-)
lib/stack/rte_stack.h +0 -1
index 278a5bd..921d29a 100644
@@ -78,7 +78,6 @@ struct rte_stack {
 	const struct rte_memzone *memzone;
 	uint32_t capacity; /**< Usable size of the stack. */
 	uint32_t flags; /**< Flags supplied at creation. */
-	RTE_STD_C11
 	union {
 		struct rte_stack_lf stack_lf; /**< Lock-free LIFO structure. */
 		struct rte_stack_std stack_std;	/**< LIFO structure. */
Signature · 1 line
1.8.3.1
#3 lore raw

PATCH 3/32 security: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/security/rte_security.h | 5 -----
 1 file changed, 5 deletions(-)
lib/security/rte_security.h +0 -5
index 3b2df52..3f8abfe 100644
@@ -94,7 +94,6 @@ struct rte_security_ctx {
 struct rte_security_ipsec_tunnel_param {
 	enum rte_security_ipsec_tunnel_type type;
 	/**< Tunnel type: IPv4 or IPv6 */
-	RTE_STD_C11
 	union {
 		struct {
 			struct in_addr src_ip;
@@ -664,7 +663,6 @@ struct rte_security_session_conf {
 	/**< Type of action to be performed on the session */
 	enum rte_security_session_protocol protocol;
 	/**< Security protocol to be configured */
-	RTE_STD_C11
 	union {
 		struct rte_security_ipsec_xform ipsec;
 		struct rte_security_macsec_xform macsec;
@@ -1050,7 +1048,6 @@ struct rte_security_stats {
 	enum rte_security_session_protocol protocol;
 	/**< Security protocol to be configured */
 
-	RTE_STD_C11
 	union {
 		struct rte_security_macsec_secy_stats macsec;
 		struct rte_security_ipsec_stats ipsec;
@@ -1126,7 +1123,6 @@ struct rte_security_capability {
 	/**< Security action type*/
 	enum rte_security_session_protocol protocol;
 	/**< Security protocol */
-	RTE_STD_C11
 	union {
 		struct {
 			enum rte_security_ipsec_sa_protocol proto;
@@ -1237,7 +1233,6 @@ struct rte_security_capability_idx {
 	enum rte_security_session_action_type action;
 	enum rte_security_session_protocol protocol;
 
-	RTE_STD_C11
 	union {
 		struct {
 			enum rte_security_ipsec_sa_protocol proto;
Signature · 1 line
1.8.3.1
#4 lore raw

PATCH 4/32 sched: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/sched/rte_sched.c | 2 --
 1 file changed, 2 deletions(-)
lib/sched/rte_sched.c +0 -2
index a1ca710..751f6cf 100644
@@ -81,7 +81,6 @@ struct rte_sched_queue {
 
 struct rte_sched_queue_extra {
 	struct rte_sched_queue_stats stats;
-	RTE_STD_C11
 	union {
 		struct rte_red red;
 		struct rte_pie pie;
@@ -180,7 +179,6 @@ struct rte_sched_subport {
 	bool cman_enabled;
 	enum rte_sched_cman_mode cman;
 
-	RTE_STD_C11
 	union {
 		struct rte_red_config red_config[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];
 		struct rte_pie_config pie_config[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
Signature · 1 line
1.8.3.1
#5 lore raw

PATCH 5/32 ring: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/ring/rte_ring_core.h | 3 ---
 1 file changed, 3 deletions(-)
lib/ring/rte_ring_core.h +0 -3
index 82b2370..d1e59bf 100644
@@ -68,7 +68,6 @@ enum rte_ring_sync_type {
 struct rte_ring_headtail {
 	volatile uint32_t head;      /**< prod/consumer head. */
 	volatile uint32_t tail;      /**< prod/consumer tail. */
-	RTE_STD_C11
 	union {
 		/** sync type of prod/cons */
 		enum rte_ring_sync_type sync_type;
@@ -130,7 +129,6 @@ struct rte_ring {
 	char pad0 __rte_cache_aligned; /**< empty cache line */
 
 	/** Ring producer status. */
-	RTE_STD_C11
 	union {
 		struct rte_ring_headtail prod;
 		struct rte_ring_hts_headtail hts_prod;
@@ -140,7 +138,6 @@ struct rte_ring {
 	char pad1 __rte_cache_aligned; /**< empty cache line */
 
 	/** Ring consumer status. */
-	RTE_STD_C11
 	union {
 		struct rte_ring_headtail cons;
 		struct rte_ring_hts_headtail hts_cons;
Signature · 1 line
1.8.3.1
#6 lore raw

PATCH 6/32 regexdev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/regexdev/rte_regexdev.h | 4 ----
 1 file changed, 4 deletions(-)
lib/regexdev/rte_regexdev.h +0 -4
index 25476f1..d50af77 100644
@@ -1246,7 +1246,6 @@ struct rte_regexdev_xstats_map {
  * @see struct rte_regex_ops::matches
  */
 struct rte_regexdev_match {
-	RTE_STD_C11
 	union {
 		uint64_t u64;
 		struct {
@@ -1260,7 +1259,6 @@ struct rte_regexdev_match {
 			 */
 			uint16_t start_offset;
 			/**< Starting Byte Position for matched rule. */
-			RTE_STD_C11
 			union {
 				uint16_t len;
 				/**< Length of match in bytes */
@@ -1393,7 +1391,6 @@ struct rte_regex_ops {
 	 */
 
 	/* W3 */
-	RTE_STD_C11
 	union {
 		uint64_t user_id;
 		/**< Application specific opaque value. An application may use
@@ -1406,7 +1403,6 @@ struct rte_regex_ops {
 	};
 
 	/* W4 */
-	RTE_STD_C11
 	union {
 		uint64_t cross_buf_id;
 		/**< ID used by the RegEx device in order to support cross
Signature · 1 line
1.8.3.1
#7 lore raw

PATCH 7/32 rawdev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/rawdev/rte_rawdev.h | 1 -
 1 file changed, 1 deletion(-)
lib/rawdev/rte_rawdev.h +0 -1
index 36c9c9a..7d5764d 100644
@@ -291,7 +291,6 @@ struct rte_rawdev {
 	/**< Driver info. supplied by probing */
 	const char *driver_name;
 
-	RTE_STD_C11
 	/**< Flag indicating the device is attached */
 	uint8_t attached : 1;
 	/**< Device state: STARTED(1)/STOPPED(0) */
Signature · 1 line
1.8.3.1
#8 lore raw

PATCH 8/32 power: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/power/rte_power.h | 2 --
 1 file changed, 2 deletions(-)
lib/power/rte_power.h +0 -2
index 5e2b87c..4d70d9a 100644
@@ -216,10 +216,8 @@ typedef uint32_t (*rte_power_freqs_t)(unsigned int lcore_id, uint32_t *freqs,
  * Power capabilities summary.
  */
 struct rte_power_core_capabilities {
-	RTE_STD_C11
 	union {
 		uint64_t capabilities;
-		RTE_STD_C11
 		struct {
 			uint64_t turbo:1;	/**< Turbo can be enabled. */
 			uint64_t priority:1;	/**< SST-BF high freq core */
Signature · 1 line
1.8.3.1
#9 lore raw

PATCH 9/32 pipeline: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/pipeline/rte_pipeline.h     | 1 -
 lib/pipeline/rte_swx_ipsec.h    | 1 -
 lib/pipeline/rte_table_action.h | 4 ----
 3 files changed, 6 deletions(-)
lib/pipeline/rte_pipeline.h +0 -1
index 68ab40d..ec51b9b 100644
@@ -212,7 +212,6 @@ struct rte_pipeline_table_entry {
 	/** Reserved action */
 	enum rte_pipeline_action action;
 
-	RTE_STD_C11
 	union {
 		/** Output port ID (meta-data for "Send packet to output port"
 		action) */
lib/pipeline/rte_swx_ipsec.h +0 -1
index a43e341..7c07fdc 100644
@@ -263,7 +263,6 @@ struct rte_swx_ipsec_sa_params {
 
 	/** Crypto operation parameters. */
 	struct {
-		RTE_STD_C11
 		union {
 			struct {
 				/** Crypto cipher operation parameters. */
lib/pipeline/rte_table_action.h +0 -4
index 82bc9d9..5dffbeb 100644
@@ -225,7 +225,6 @@ struct rte_table_action_meter_profile {
 	/** Traffic metering algorithm. */
 	enum rte_table_action_meter_algorithm alg;
 
-	RTE_STD_C11
 	union {
 		/** Only valid when *alg* is set to srTCM - IETF RFC 2697. */
 		struct rte_meter_srtcm_params srtcm;
@@ -487,7 +486,6 @@ struct rte_table_action_encap_vxlan_params {
 	struct rte_table_action_ether_hdr ether; /**< Ethernet header. */
 	struct rte_table_action_vlan_hdr vlan; /**< VLAN header. */
 
-	RTE_STD_C11
 	union {
 		struct rte_table_action_ipv4_header ipv4; /**< IPv4 header. */
 		struct rte_table_action_ipv6_header ipv6; /**< IPv6 header. */
@@ -508,7 +506,6 @@ struct rte_table_action_encap_config {
 	uint64_t encap_mask;
 
 	/** Encapsulation type specific configuration. */
-	RTE_STD_C11
 	union {
 		struct {
 			/** Input packet to be encapsulated: offset within the
@@ -547,7 +544,6 @@ struct rte_table_action_encap_params {
 	/** Encapsulation type. */
 	enum rte_table_action_encap_type type;
 
-	RTE_STD_C11
 	union {
 		/** Only valid when *type* is set to Ether. */
 		struct rte_table_action_encap_ether_params ether;
Signature · 1 line
1.8.3.1
#10 lore raw

PATCH 10/32 net: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/net/rte_ecpri.h  | 3 ---
 lib/net/rte_higig.h  | 1 -
 lib/net/rte_l2tpv2.h | 2 --
 3 files changed, 6 deletions(-)
lib/net/rte_ecpri.h +0 -3
index 73b8a45..137c44f 100644
@@ -66,7 +66,6 @@
 /**
  * eCPRI Common Header
  */
-RTE_STD_C11
 struct rte_ecpri_common_hdr {
 	union {
 		rte_be32_t u32;			/**< 4B common header in BE */
@@ -123,7 +122,6 @@ struct rte_ecpri_msg_gen_data {
 /**
  * eCPRI Message Header of Type #4: Remote Memory Access
  */
-RTE_STD_C11
 struct rte_ecpri_msg_rm_access {
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
 	uint32_t ele_id:16;		/**< Element ID */
@@ -169,7 +167,6 @@ struct rte_ecpri_msg_event_ind {
 /**
  * eCPRI Combined Message Header Format: Common Header + Message Types
  */
-RTE_STD_C11
 struct rte_ecpri_combined_msg_hdr {
 	struct rte_ecpri_common_hdr common;
 	union {
lib/net/rte_higig.h +0 -1
index bba3898..7991f6d 100644
@@ -136,7 +136,6 @@ struct rte_higig2_ppt_type1 {
  *
  * higig2 header
  */
-RTE_STD_C11
 struct rte_higig2_hdr {
 	struct rte_higig2_frc fcr;
 	union {
lib/net/rte_l2tpv2.h +0 -2
index d41123a..9cda347 100644
@@ -94,7 +94,6 @@
 /**
  * L2TPv2 Common Header
  */
-RTE_STD_C11
 struct rte_l2tpv2_common_hdr {
 	union {
 		/** header flags and protocol version */
@@ -218,7 +217,6 @@ struct rte_l2tpv2_msg_without_all_options {
 /**
  * L2TPv2 Combined Message Header Format: Common Header + Options
  */
-RTE_STD_C11
 struct rte_l2tpv2_combined_msg_hdr {
 	struct rte_l2tpv2_common_hdr common; /**< common header */
 	union {
Signature · 1 line
1.8.3.1
#11 lore raw

PATCH 11/32 mldev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/mldev/rte_mldev.h | 1 -
 1 file changed, 1 deletion(-)
lib/mldev/rte_mldev.h +0 -1
index 222ecbd..fc3525c 100644
@@ -433,7 +433,6 @@ struct rte_ml_op {
 	/**< Input buffer to hold the inference data. */
 	struct rte_ml_buff_seg output;
 	/**< Output buffer to hold the inference output by the driver. */
-	RTE_STD_C11
 	union {
 		uint64_t user_u64;
 		/**< User data as uint64_t.*/
Signature · 1 line
1.8.3.1
#12 lore raw

PATCH 12/32 mempool: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/mempool/rte_mempool.h | 1 -
 1 file changed, 1 deletion(-)
lib/mempool/rte_mempool.h +0 -1
index 160975a..a05b25d 100644
@@ -218,7 +218,6 @@ struct rte_mempool_info {
  */
 struct rte_mempool {
 	char name[RTE_MEMPOOL_NAMESIZE]; /**< Name of mempool. */
-	RTE_STD_C11
 	union {
 		void *pool_data;         /**< Ring or pool to store objects. */
 		uint64_t pool_id;        /**< External mempool identifier. */
Signature · 1 line
1.8.3.1
#13 lore raw

PATCH 13/32 mbuf: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/mbuf/rte_mbuf_core.h | 4 ----
 1 file changed, 4 deletions(-)
lib/mbuf/rte_mbuf_core.h +0 -4
index 2030b3b..e9bc0d1 100644
@@ -522,7 +522,6 @@ struct rte_mbuf {
 	 * would have RTE_PTYPE_L2_ETHER and not RTE_PTYPE_L2_VLAN because the
 	 * vlan is stripped from the data.
 	 */
-	RTE_STD_C11
 	union {
 		uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
 		__extension__
@@ -531,7 +530,6 @@ struct rte_mbuf {
 			uint8_t l3_type:4;   /**< (Outer) L3 type. */
 			uint8_t l4_type:4;   /**< (Outer) L4 type. */
 			uint8_t tun_type:4;  /**< Tunnel type. */
-			RTE_STD_C11
 			union {
 				uint8_t inner_esp_next_proto;
 				/**< ESP next protocol type, valid if
@@ -555,7 +553,6 @@ struct rte_mbuf {
 	/** VLAN TCI (CPU order), valid if RTE_MBUF_F_RX_VLAN is set. */
 	uint16_t vlan_tci;
 
-	RTE_STD_C11
 	union {
 		union {
 			uint32_t rss;     /**< RSS hash result if RSS enabled */
@@ -614,7 +611,6 @@ struct rte_mbuf {
 #endif
 
 	/* fields to support TX offloads */
-	RTE_STD_C11
 	union {
 		uint64_t tx_offload;       /**< combined for easy fetch */
 		__extension__
Signature · 1 line
1.8.3.1
#14 lore raw

PATCH 14/32 ip_frag: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/ip_frag/ip_reassembly.h | 1 -
 1 file changed, 1 deletion(-)
lib/ip_frag/ip_reassembly.h +0 -1
index ef9d8c0..a9f97ae 100644
@@ -33,7 +33,6 @@ struct ip_frag {
 struct ip_frag_key {
 	uint64_t src_dst[4];
 	/* src and dst address, only first 8 bytes used for IPv4 */
-	RTE_STD_C11
 	union {
 		uint64_t id_key_len; /* combined for easy fetch */
 		__extension__
Signature · 1 line
1.8.3.1
#15 lore raw

PATCH 15/32 hash: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/hash/rte_thash.h | 2 --
 1 file changed, 2 deletions(-)
lib/hash/rte_thash.h +0 -2
index 7b1d154..da06cd5 100644
@@ -73,7 +73,6 @@
 struct rte_ipv4_tuple {
 	uint32_t	src_addr;
 	uint32_t	dst_addr;
-	RTE_STD_C11
 	union {
 		struct {
 			uint16_t dport;
@@ -91,7 +90,6 @@ struct rte_ipv4_tuple {
 struct rte_ipv6_tuple {
 	uint8_t		src_addr[16];
 	uint8_t		dst_addr[16];
-	RTE_STD_C11
 	union {
 		struct {
 			uint16_t dport;
Signature · 1 line
1.8.3.1
#16 lore raw

PATCH 16/32 graph: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/graph/rte_graph.h               | 3 ---
 lib/graph/rte_graph_worker_common.h | 4 ----
 2 files changed, 7 deletions(-)
lib/graph/rte_graph.h +0 -3
index 7e94c15..eca32a4 100644
@@ -168,7 +168,6 @@ struct rte_graph_param {
 	uint64_t num_pkt_to_capture; /**< Number of packets to capture. */
 	char *pcap_filename; /**< Filename in which packets to be captured.*/
 
-	RTE_STD_C11
 	union {
 		struct {
 			uint64_t rsvd; /**< Reserved for rtc model. */
@@ -192,7 +191,6 @@ struct rte_graph_cluster_stats_param {
 	/**< Stats print callback function. NULL value allowed, in that case,
 	 *   default print stat function used.
 	 */
-	RTE_STD_C11
 	union {
 		void *cookie;
 		FILE *f; /**< File pointer to dump the stats when fn == NULL. */
@@ -218,7 +216,6 @@ struct rte_graph_cluster_node_stats {
 	uint64_t prev_objs;	/**< Previous number of processed objs. */
 	uint64_t prev_cycles;	/**< Previous number of cycles. */
 
-	RTE_STD_C11
 	union {
 		struct {
 			uint64_t sched_objs;
lib/graph/rte_graph_worker_common.h +0 -4
index a382459..7d6973c 100644
@@ -59,7 +59,6 @@ struct rte_graph {
 	uint8_t model;		     /**< graph model */
 	uint8_t reserved1;	     /**< Reserved for future use. */
 	uint16_t reserved2;	     /**< Reserved for future use. */
-	RTE_STD_C11
 	union {
 		/* Fast schedule area for mcore dispatch model */
 		struct {
@@ -105,7 +104,6 @@ struct rte_node {
 	/** Original process function when pcap is enabled. */
 	rte_node_process_t original_process;
 
-	RTE_STD_C11
 	union {
 		/* Fast schedule area for mcore dispatch model */
 		struct {
@@ -123,12 +121,10 @@ struct rte_node {
 	uint64_t total_cycles;	/**< Cycles spent in this node. */
 	uint64_t total_calls;	/**< Calls done to this node. */
 	uint64_t total_objs;	/**< Objects processed by this node. */
-	RTE_STD_C11
 		union {
 			void **objs;	   /**< Array of object pointers. */
 			uint64_t objs_u64;
 		};
-	RTE_STD_C11
 		union {
 			rte_node_process_t process; /**< Process function. */
 			uint64_t process_u64;
Signature · 1 line
1.8.3.1
#17 lore raw

PATCH 17/32 eventdev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/eventdev/event_timer_adapter_pmd.h  | 1 -
 lib/eventdev/eventdev_pmd.h             | 2 --
 lib/eventdev/rte_event_eth_rx_adapter.c | 1 -
 lib/eventdev/rte_event_timer_adapter.h  | 2 --
 lib/eventdev/rte_eventdev.h             | 1 -
 5 files changed, 7 deletions(-)
lib/eventdev/event_timer_adapter_pmd.h +0 -1
index 8f3e6c4..65b421b 100644
@@ -108,7 +108,6 @@ struct rte_event_timer_adapter_data {
 	uint32_t service_id;
 	/**< Service ID*/
 
-	RTE_STD_C11
 	uint8_t started : 1;
 	/**< Flag to indicate adapter started. */
 } __rte_cache_aligned;
lib/eventdev/eventdev_pmd.h +0 -2
index c68c3a2..f62f42e 100644
@@ -135,7 +135,6 @@ struct rte_eventdev_data {
 	void *dev_stop_flush_arg;
 	/**< User-provided argument for event flush function */
 
-	RTE_STD_C11
 	uint8_t dev_started : 1;
 	/**< Device state: STARTED(1)/STOPPED(0) */
 
@@ -155,7 +154,6 @@ struct rte_eventdev {
 	struct rte_device *dev;
 	/**< Device info. supplied by probing */
 
-	RTE_STD_C11
 	uint8_t attached : 1;
 	/**< Flag indicating the device is attached */
 
lib/eventdev/rte_event_eth_rx_adapter.c +0 -1
index f7f93cc..5c93967 100644
@@ -52,7 +52,6 @@
  * Used to store port and queue ID of interrupting Rx queue
  */
 union queue_data {
-	RTE_STD_C11
 	void *ptr;
 	struct {
 		uint16_t port;
lib/eventdev/rte_event_timer_adapter.h +0 -2
index 9ac35b7..fbdddf8 100644
@@ -473,7 +473,6 @@ enum rte_event_timer_state {
  * The generic *rte_event_timer* structure to hold the event timer attributes
  * for arm and cancel operations.
  */
-RTE_STD_C11
 struct rte_event_timer {
 	struct rte_event ev;
 	/**<
@@ -539,7 +538,6 @@ struct rte_event_timer_adapter {
 	const struct event_timer_adapter_ops *ops;
 	/**< Functions exported by adapter driver */
 
-	RTE_STD_C11
 	uint8_t allocated : 1;
 	/**< Flag to indicate that this adapter has been allocated */
 } __rte_cache_aligned;
lib/eventdev/rte_eventdev.h +0 -1
index b6a4fa1..2ba8a7b 100644
@@ -1273,7 +1273,6 @@ struct rte_event_vector {
  * The generic *rte_event* structure to hold the event attributes
  * for dequeue and enqueue operation
  */
-RTE_STD_C11
 struct rte_event {
 	/** WORD0 */
 	union {
Signature · 1 line
1.8.3.1
#18 lore raw

PATCH 18/32 ethdev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/ethdev/rte_flow.h | 11 -----------
 lib/ethdev/rte_mtr.h  |  1 -
 lib/ethdev/rte_tm.h   |  3 ---
 3 files changed, 15 deletions(-)
lib/ethdev/rte_flow.h +0 -11
index 86ed98c..2ebb76d 100644
@@ -726,7 +726,6 @@ struct rte_flow_item_quota {
  * RTE_FLOW_ITEM_TYPE_HIGIG2
  * Matches higig2 header
  */
-RTE_STD_C11
 struct rte_flow_item_higig2_hdr {
 	struct rte_higig2_hdr hdr;
 };
@@ -848,7 +847,6 @@ struct rte_flow_item_raw {
  * the EtherType/TPID field. Also, it's possible to leave the two fields unused.
  * If this is the case, both tagged and untagged packets will match the pattern.
  */
-RTE_STD_C11
 struct rte_flow_item_eth {
 	union {
 		struct {
@@ -890,7 +888,6 @@ struct rte_flow_item_eth {
  * If the @p eth_proto of @p hdr and @p has_more_vlan fields are not specified,
  * then any tagged packets will match the pattern.
  */
-RTE_STD_C11
 struct rte_flow_item_vlan {
 	union {
 		struct {
@@ -1075,7 +1072,6 @@ struct rte_flow_item_sctp {
  *
  * Matches a VXLAN header (RFC 7348).
  */
-RTE_STD_C11
 struct rte_flow_item_vxlan {
 	union {
 		struct {
@@ -1246,7 +1242,6 @@ struct rte_flow_item_fuzzy {
  *
  * Matches a GTPv1 header.
  */
-RTE_STD_C11
 struct rte_flow_item_gtp {
 	union {
 		struct {
@@ -1322,7 +1317,6 @@ struct rte_flow_item_geneve {
  *
  * Matches a VXLAN-GPE header.
  */
-RTE_STD_C11
 struct rte_flow_item_vxlan_gpe {
 	union {
 		struct {
@@ -1352,7 +1346,6 @@ struct rte_flow_item_vxlan_gpe {
  *
  * Matches an ARP header for Ethernet/IPv4.
  */
-RTE_STD_C11
 struct rte_flow_item_arp_eth_ipv4 {
 	union {
 		struct {
@@ -1874,7 +1867,6 @@ struct rte_flow_item_integrity {
 	 * @see rte_flow_action_rss
 	 */
 	uint32_t level;
-	RTE_STD_C11
 	union {
 		__extension__
 		struct {
@@ -3893,7 +3885,6 @@ enum rte_flow_field_id {
  */
 struct rte_flow_action_modify_data {
 	enum rte_flow_field_id field; /**< Field or memory type ID. */
-	RTE_STD_C11
 	union {
 		struct {
 			/** Encapsulation level and tag index or flex item handle. */
@@ -4200,7 +4191,6 @@ struct rte_flow_error {
  * @see RTE_FLOW_CONV_OP_RULE
  * @see rte_flow_conv()
  */
-RTE_STD_C11
 struct rte_flow_conv_rule {
 	union {
 		const struct rte_flow_attr *attr_ro; /**< RO attributes. */
@@ -5002,7 +4992,6 @@ struct rte_flow_tunnel {
 	enum rte_flow_item_type	type;
 	uint64_t tun_id; /**< Tunnel identification. */
 
-	RTE_STD_C11
 	union {
 		struct {
 			rte_be32_t src_addr; /**< IPv4 source address. */
lib/ethdev/rte_mtr.h +0 -1
index 7e6a66b..30e6c6b 100644
@@ -129,7 +129,6 @@ struct rte_mtr_meter_profile {
 	/** Traffic metering algorithm. */
 	enum rte_mtr_algorithm alg;
 
-	RTE_STD_C11
 	union {
 		/** Items only valid when *alg* is set to srTCM - RFC 2697. */
 		struct {
lib/ethdev/rte_tm.h +0 -3
index 4103c49..08c5faf 100644
@@ -500,7 +500,6 @@ struct rte_tm_level_capabilities {
 	 */
 	int leaf_nodes_identical;
 
-	RTE_STD_C11
 	union {
 		/** Items valid only for the non-leaf nodes on this level. */
 		struct {
@@ -851,7 +850,6 @@ struct rte_tm_node_capabilities {
 	 */
 	int shaper_shared_byte_mode_supported;
 
-	RTE_STD_C11
 	union {
 		/** Items valid only for non-leaf nodes. */
 		struct {
@@ -1108,7 +1106,6 @@ struct rte_tm_node_params {
 	/** Number of shared shaper IDs in the *shared_shaper_id* array. */
 	uint32_t n_shared_shapers;
 
-	RTE_STD_C11
 	union {
 		/** Parameters only valid for non-leaf nodes. */
 		struct {
Signature · 1 line
1.8.3.1
#19 lore raw

PATCH 19/32 dmadev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/dmadev/rte_dmadev.h | 1 -
 1 file changed, 1 deletion(-)
lib/dmadev/rte_dmadev.h +0 -1
index e61d719..b157ab7 100644
@@ -484,7 +484,6 @@ struct rte_dma_port_param {
 	 * @see enum rte_dma_port_type
 	 */
 	enum rte_dma_port_type port_type;
-	RTE_STD_C11
 	union {
 		/** PCIe access port parameters.
 		 *
Signature · 1 line
1.8.3.1
#20 lore raw

PATCH 20/32 cryptodev: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 lib/cryptodev/cryptodev_pmd.h   | 2 +-
 lib/cryptodev/rte_crypto_asym.h | 4 ----
 lib/cryptodev/rte_crypto_sym.h  | 3 ---
 lib/cryptodev/rte_cryptodev.h   | 2 --
 4 files changed, 1 insertion(+), 10 deletions(-)
lib/cryptodev/cryptodev_pmd.h +1 -1
index 4c98ced..3bb3d95 100644
@@ -683,7 +683,7 @@ uint8_t rte_cryptodev_allocate_driver(struct cryptodev_driver *crypto_drv,
  * @internal
  * Cryptodev asymmetric crypto session.
  */
-RTE_STD_C11 struct rte_cryptodev_asym_session {
+struct rte_cryptodev_asym_session {
 	uint8_t driver_id;
 	/**< Session driver ID. */
 	uint16_t max_priv_data_sz;
lib/cryptodev/rte_crypto_asym.h +0 -4
index 8b5794f..cbcfe1d 100644
@@ -310,7 +310,6 @@ struct rte_crypto_rsa_xform {
 
 	enum rte_crypto_rsa_priv_key_type key_type;
 
-	RTE_STD_C11
 	union {
 		rte_crypto_uint d;
 		/**< the RSA private exponent */
@@ -625,7 +624,6 @@ struct rte_crypto_asym_xform {
 	enum rte_crypto_asym_xform_type xform_type;
 	/**< Asymmetric crypto transform */
 
-	RTE_STD_C11
 	union {
 		struct rte_crypto_rsa_xform rsa;
 		/**< RSA xform parameters */
@@ -725,7 +723,6 @@ struct rte_crypto_sm2_op_param {
  * Structure describing asymmetric crypto operation params.
  */
 struct rte_crypto_asym_op {
-	RTE_STD_C11
 	union {
 		struct rte_cryptodev_asym_session *session;
 		/**< Handle for the initialised session context */
@@ -733,7 +730,6 @@ struct rte_crypto_asym_op {
 		/**< Session-less API crypto operation parameters */
 	};
 
-	RTE_STD_C11
 	union {
 		struct rte_crypto_rsa_op_param rsa;
 		struct rte_crypto_mod_op_param modex;
lib/cryptodev/rte_crypto_sym.h +0 -3
index 76c868c..bde8010 100644
@@ -594,7 +594,6 @@ struct rte_crypto_sym_xform {
 	/**< next xform in chain */
 	enum rte_crypto_sym_xform_type type
 	; /**< xform type */
-	RTE_STD_C11
 	union {
 		struct rte_crypto_auth_xform auth;
 		/**< Authentication / hash xform */
@@ -641,7 +640,6 @@ struct rte_crypto_sym_op {
 	struct rte_mbuf *m_src;	/**< source mbuf */
 	struct rte_mbuf *m_dst;	/**< destination mbuf */
 
-	RTE_STD_C11
 	union {
 		void *session;
 		/**< Handle for the initialised crypto/security session context */
@@ -649,7 +647,6 @@ struct rte_crypto_sym_op {
 		/**< Session-less API crypto operation parameters */
 	};
 
-	RTE_STD_C11
 	union {
 		struct {
 			struct {
lib/cryptodev/rte_cryptodev.h +0 -2
index ba73037..9246df9 100644
@@ -109,7 +109,6 @@ struct rte_crypto_param_range {
 struct rte_cryptodev_symmetric_capability {
 	enum rte_crypto_sym_xform_type xform_type;
 	/**< Transform type : Authentication / Cipher / AEAD */
-	RTE_STD_C11
 	union {
 		struct {
 			enum rte_crypto_auth_algorithm algo;
@@ -198,7 +197,6 @@ struct rte_cryptodev_capabilities {
 	enum rte_crypto_op_type op;
 	/**< Operation type */
 
-	RTE_STD_C11
 	union {
 		struct rte_cryptodev_symmetric_capability sym;
 		/**< Symmetric operation capability parameters */
Signature · 1 line
1.8.3.1
#21 lore raw

PATCH 21/32 examples/ipsec-secgw: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 examples/ipsec-secgw/event_helper.h | 2 --
 examples/ipsec-secgw/flow.c         | 1 -
 2 files changed, 3 deletions(-)
examples/ipsec-secgw/event_helper.h +0 -2
index af5cfcf..dfb81bf 100644
@@ -164,7 +164,6 @@ struct eventmode_conf {
 	uint32_t eth_portmask;
 		/**< Mask of the eth ports to be used */
 	union {
-		RTE_STD_C11
 		struct {
 			uint64_t sched_type			: 2;
 		/**< Schedule type */
@@ -213,7 +212,6 @@ struct eh_conf {
 /* Workers registered by the application */
 struct eh_app_worker_params {
 	union {
-		RTE_STD_C11
 		struct {
 			uint64_t burst : 1;
 			/**< Specify status of rx type burst */
examples/ipsec-secgw/flow.c +0 -1
index 1bcf86c..05a62c3 100644
@@ -19,7 +19,6 @@ struct flow_rule_entry {
 	uint8_t is_eth;
 	uint8_t is_ipv4;
 	uint8_t is_ipv6;
-	RTE_STD_C11
 	union {
 		struct {
 			struct rte_flow_item_ipv4 spec;
Signature · 1 line
1.8.3.1
#22 lore raw

PATCH 22/32 examples/ip_pipeline: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 examples/ip_pipeline/pipeline.h | 2 --
 examples/ip_pipeline/thread.c   | 2 --
 2 files changed, 4 deletions(-)
examples/ip_pipeline/pipeline.h +0 -2
index 083d5e8..22f04fd 100644
@@ -211,7 +211,6 @@ struct pipeline *
 struct table_rule_match_acl {
 	int ip_version;
 
-	RTE_STD_C11
 	union {
 		struct {
 			uint32_t sa;
@@ -254,7 +253,6 @@ struct table_rule_match_hash {
 struct table_rule_match_lpm {
 	int ip_version;
 
-	RTE_STD_C11
 	union {
 		uint32_t ipv4;
 		uint8_t ipv6[16];
examples/ip_pipeline/thread.c +0 -2
index 9817657..b46f64b 100644
@@ -650,7 +650,6 @@ struct pipeline_msg_req {
 	enum pipeline_req_type type;
 	uint32_t id; /* Port IN, port OUT or table ID */
 
-	RTE_STD_C11
 	union {
 		struct pipeline_msg_req_port_in_stats_read port_in_stats_read;
 		struct pipeline_msg_req_port_out_stats_read port_out_stats_read;
@@ -712,7 +711,6 @@ struct pipeline_msg_rsp_table_rule_time_read {
 struct pipeline_msg_rsp {
 	int status;
 
-	RTE_STD_C11
 	union {
 		struct pipeline_msg_rsp_port_in_stats_read port_in_stats_read;
 		struct pipeline_msg_rsp_port_out_stats_read port_out_stats_read;
Signature · 1 line
1.8.3.1
#23 lore raw

PATCH 23/32 net/sfc: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/sfc/sfc_flow.h  | 2 --
 drivers/net/sfc/sfc_mae.h   | 1 -
 drivers/net/sfc/sfc_stats.h | 1 -
 3 files changed, 4 deletions(-)
drivers/net/sfc/sfc_flow.h +0 -2
index 601f93e..06738fe 100644
@@ -109,7 +109,6 @@ struct sfc_flow_spec {
 	/* Flow specification type (engine-based) */
 	enum sfc_flow_spec_type type;
 
-	RTE_STD_C11
 	union {
 		/* Filter-based (VNIC level flows) specification */
 		struct sfc_flow_spec_filter filter;
@@ -149,7 +148,6 @@ enum sfc_flow_parse_ctx_type {
 struct sfc_flow_parse_ctx {
 	enum sfc_flow_parse_ctx_type type;
 
-	RTE_STD_C11
 	union {
 		/* Context pointer valid for filter-based (VNIC) flows */
 		efx_filter_spec_t *filter;
drivers/net/sfc/sfc_mae.h +0 -1
index 059718e..646d055 100644
@@ -25,7 +25,6 @@
 /** FW-allocatable resource context */
 struct sfc_mae_fw_rsrc {
 	unsigned int			refcnt;
-	RTE_STD_C11
 	union {
 		efx_counter_t		counter_id;
 		efx_mae_aset_id_t	aset_id;
drivers/net/sfc/sfc_stats.h +0 -1
index aae8243..597e14d 100644
@@ -26,7 +26,6 @@
  * required.
  */
 union sfc_pkts_bytes {
-	RTE_STD_C11
 	struct {
 		uint64_t		pkts;
 		uint64_t		bytes;
Signature · 1 line
1.8.3.1
#24 lore raw

PATCH 24/32 net/octeontx: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/octeontx/octeontx_rxtx.h | 2 --
 1 file changed, 2 deletions(-)
drivers/net/octeontx/octeontx_rxtx.h +0 -2
index b63a5ed..b6e3515 100644
@@ -28,7 +28,6 @@
 #define PTYPE_SIZE	OCCTX_PKI_LTYPE_LAST
 
 /* octeontx send header sub descriptor structure */
-RTE_STD_C11
 union octeontx_send_hdr_w0_u {
 	uint64_t u;
 	struct {
@@ -53,7 +52,6 @@
 	};
 };
 
-RTE_STD_C11
 union octeontx_send_hdr_w1_u {
 	uint64_t u;
 	struct {
Signature · 1 line
1.8.3.1
#25 lore raw

PATCH 25/32 net/mlx5: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/mlx5/mlx5.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/mlx5/mlx5.h +0 -4
index b753493..3785103 100644
@@ -1535,7 +1535,6 @@ struct mlx5_rxq_obj {
 	LIST_ENTRY(mlx5_rxq_obj) next; /* Pointer to the next element. */
 	struct mlx5_rxq_ctrl *rxq_ctrl; /* Back pointer to parent. */
 	int fd; /* File descriptor for event channel */
-	RTE_STD_C11
 	union {
 		struct {
 			void *wq; /* Work Queue. */
@@ -1555,7 +1554,6 @@ struct mlx5_rxq_obj {
 struct mlx5_ind_table_obj {
 	LIST_ENTRY(mlx5_ind_table_obj) next; /* Pointer to the next element. */
 	uint32_t refcnt; /* Reference counter. */
-	RTE_STD_C11
 	union {
 		void *ind_table; /**< Indirection table. */
 		struct mlx5_devx_obj *rqt; /* DevX RQT object. */
@@ -1570,7 +1568,6 @@ struct mlx5_hrxq {
 	struct mlx5_list_entry entry; /* List entry. */
 	uint32_t standalone:1; /* This object used in shared action. */
 	struct mlx5_ind_table_obj *ind_table; /* Indirection table. */
-	RTE_STD_C11
 	union {
 		void *qp; /* Verbs queue pair. */
 		struct mlx5_devx_obj *tir; /* DevX TIR object. */
@@ -1590,7 +1587,6 @@ struct mlx5_hrxq {
 struct mlx5_txq_obj {
 	LIST_ENTRY(mlx5_txq_obj) next; /* Pointer to the next element. */
 	struct mlx5_txq_ctrl *txq_ctrl; /* Pointer to the control queue. */
-	RTE_STD_C11
 	union {
 		struct {
 			void *cq; /* Completion Queue. */
Signature · 1 line
1.8.3.1
#26 lore raw

PATCH 26/32 net/mlx4: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/mlx4/mlx4.h | 1 -
 1 file changed, 1 deletion(-)
drivers/net/mlx4/mlx4.h +0 -1
index 4023a47..d90570a 100644
@@ -79,7 +79,6 @@ struct mlx4_mp_param {
 	enum mlx4_mp_req_type type;
 	int port_id;
 	int result;
-	RTE_STD_C11
 	union {
 		uintptr_t addr; /* MLX4_MP_REQ_CREATE_MR */
 	} args;
Signature · 1 line
1.8.3.1
#27 lore raw

PATCH 27/32 net/igc: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/igc/igc_ethdev.h | 2 --
 1 file changed, 2 deletions(-)
drivers/net/igc/igc_ethdev.h +0 -2
index 8d7eb54..d3d3ddd 100644
@@ -177,7 +177,6 @@ struct igc_ntuple_info {
 
 /* Structure of n-tuple filter */
 struct igc_ntuple_filter {
-	RTE_STD_C11
 	union {
 		uint64_t hash_val;
 		struct igc_ntuple_info tuple_info;
@@ -215,7 +214,6 @@ enum igc_filter_type {
 struct rte_flow {
 	TAILQ_ENTRY(rte_flow) node;
 	enum igc_filter_type filter_type;
-	RTE_STD_C11
 	char filter[0];		/* filter data */
 };
 
Signature · 1 line
1.8.3.1
#28 lore raw

PATCH 28/32 net/avp: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/net/avp/rte_avp_common.h | 2 --
 1 file changed, 2 deletions(-)
drivers/net/avp/rte_avp_common.h +0 -2
index 4e82ec0..908b31b 100644
@@ -8,7 +8,6 @@
 
 #ifdef __KERNEL__
 #include <linux/if.h>
-#define RTE_STD_C11
 #else
 #include <stdint.h>
 #include <rte_common.h>
@@ -76,7 +75,6 @@ struct rte_avp_device_config {
  */
 struct rte_avp_request {
 	uint32_t req_id; /**< Request id */
-	RTE_STD_C11
 	union {
 		uint32_t new_mtu; /**< New MTU */
 		uint8_t if_up;	/**< 1: interface up, 0: interface down */
Signature · 1 line
1.8.3.1
#29 lore raw

PATCH 29/32 dma/idxd: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/dma/idxd/idxd_hw_defs.h | 1 -
 1 file changed, 1 deletion(-)
drivers/dma/idxd/idxd_hw_defs.h +0 -1
index a38540f..7113d22 100644
@@ -31,7 +31,6 @@ struct idxd_hw_desc {
 	uint32_t op_flags;
 	rte_iova_t completion;
 
-	RTE_STD_C11
 	union {
 		rte_iova_t src;      /* source address for copy ops etc. */
 		rte_iova_t desc_addr; /* descriptor pointer for batch */
Signature · 1 line
1.8.3.1
#30 lore raw

PATCH 30/32 common/mlx5: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/common/mlx5/mlx5_common_mp.h | 2 --
 1 file changed, 2 deletions(-)
drivers/common/mlx5/mlx5_common_mp.h +0 -2
index 34e4fae..ab8bccc 100644
@@ -38,7 +38,6 @@ struct mlx5_mp_arg_queue_id {
 
 struct mlx5_mp_arg_mr_manage {
 	struct mlx5_common_device *cdev;
-	RTE_STD_C11
 	union {
 		struct {
 			struct rte_mempool *mempool;
@@ -53,7 +52,6 @@ struct mlx5_mp_param {
 	enum mlx5_mp_req_type type;
 	int port_id;
 	int result;
-	RTE_STD_C11
 	union {
 		struct mlx5_mp_arg_mr_manage mr_manage;
 		/* MLX5_MP_REQ_MEMPOOL_(UN)REGISTER, MLX5_MP_REQ_CREATE_MR */
Signature · 1 line
1.8.3.1
#31 lore raw

PATCH 31/32 common/cnxk: remove use of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use of RTE_STD_C11 macro marking use of C11 features with __extension__ since it is no longer necessary.

---
 drivers/common/cnxk/hw/nix.h       | 7 -------
 drivers/common/cnxk/roc_nix.h      | 1 -
 drivers/common/cnxk/roc_npc.h      | 3 ---
 drivers/common/cnxk/roc_platform.h | 1 -
 4 files changed, 12 deletions(-)
drivers/common/cnxk/hw/nix.h +0 -7
index 26dcda6..319fe36 100644
@@ -1622,7 +1622,6 @@ struct nix_send_crc_s {
 };
 
 /* NIX send extended header sub descriptor structure */
-PLT_STD_C11
 union nix_send_ext_w0_u {
 	uint64_t u;
 	struct {
@@ -1642,7 +1641,6 @@ struct nix_send_crc_s {
 	};
 };
 
-PLT_STD_C11
 union nix_send_ext_w1_u {
 	uint64_t u;
 	struct {
@@ -1672,7 +1670,6 @@ struct nix_send_ext_s {
 };
 
 /* NIX send header sub descriptor structure */
-PLT_STD_C11
 union nix_send_hdr_w0_u {
 	uint64_t u;
 	struct {
@@ -1686,7 +1683,6 @@ struct nix_send_ext_s {
 	};
 };
 
-PLT_STD_C11
 union nix_send_hdr_w1_u {
 	uint64_t u;
 	struct {
@@ -1728,7 +1724,6 @@ struct nix_send_jump_s {
 };
 
 /* NIX send memory sub descriptor structure */
-PLT_STD_C11
 union nix_send_mem_w0_u {
 	uint64_t u;
 	struct {
@@ -1756,7 +1751,6 @@ struct nix_send_mem_s {
 };
 
 /* NIX send scatter/gather sub descriptor structure */
-PLT_STD_C11
 union nix_send_sg2_s {
 	uint64_t u;
 	struct {
@@ -1771,7 +1765,6 @@ struct nix_send_mem_s {
 	};
 };
 
-PLT_STD_C11
 union nix_send_sg_s {
 	uint64_t u;
 	struct {
drivers/common/cnxk/roc_nix.h +0 -1
index 9c2ba9a..66f0597 100644
@@ -294,7 +294,6 @@ struct roc_nix_stats {
 };
 
 struct roc_nix_stats_queue {
-	PLT_STD_C11
 	union {
 		struct {
 			/* Rx */
drivers/common/cnxk/roc_npc.h +0 -3
index 07e6634..48e550a 100644
@@ -67,7 +67,6 @@ struct roc_ether_addr {
 
 struct roc_ether_hdr {
 	struct roc_ether_addr d_addr; /**< Destination address. */
-	PLT_STD_C11
 	union {
 		struct roc_ether_addr s_addr; /**< Source address. */
 		struct {
@@ -77,7 +76,6 @@ struct roc_ether_hdr {
 	uint16_t ether_type; /**< Frame type. */
 } __plt_aligned(2);
 
-PLT_STD_C11
 struct roc_npc_flow_item_eth {
 	union {
 		struct {
@@ -101,7 +99,6 @@ struct roc_vlan_hdr {
 	uint16_t eth_proto; /**< Ethernet type of encapsulated frame. */
 } __plt_packed;
 
-PLT_STD_C11
 struct roc_npc_flow_item_vlan {
 	union {
 		struct {
drivers/common/cnxk/roc_platform.h +0 -1
index 9884398..08f83ab 100644
@@ -43,7 +43,6 @@
 #define PLT_ASSERT		 RTE_ASSERT
 #define PLT_VERIFY		 RTE_VERIFY
 #define PLT_MEMZONE_NAMESIZE	 RTE_MEMZONE_NAMESIZE
-#define PLT_STD_C11		 RTE_STD_C11
 #define PLT_PTR_ADD		 RTE_PTR_ADD
 #define PLT_PTR_SUB		 RTE_PTR_SUB
 #define PLT_PTR_DIFF		 RTE_PTR_DIFF
Signature · 1 line
1.8.3.1
#32 lore raw

PATCH 32/32 eal: remove use and definition of RTE STD C11 macro

In reply to Tyler Retzlaff

C11 conformant compiler is documented as a minimum requirement to build and consume DPDK. Remove use and definition of RTE_STD_C11 macro.

---
 lib/eal/common/eal_common_proc.c     | 1 -
 lib/eal/common/eal_interrupts.h      | 1 -
 lib/eal/common/malloc_mp.h           | 2 --
 lib/eal/include/generic/rte_atomic.h | 2 --
 lib/eal/include/rte_common.h         | 7 -------
 lib/eal/include/rte_devargs.h        | 1 -
 lib/eal/include/rte_memory.h         | 2 --
 lib/eal/include/rte_memzone.h        | 1 -
 lib/eal/linux/eal_vfio.h             | 1 -
 lib/eal/x86/include/rte_atomic_32.h  | 1 -
 lib/eal/x86/include/rte_cycles.h     | 1 -
 11 files changed, 20 deletions(-)
lib/eal/common/eal_common_proc.c +0 -1
index 02d4599..c4981f2 100644
@@ -80,7 +80,6 @@ struct pending_request {
 	struct rte_mp_msg *request;
 	struct rte_mp_msg *reply;
 	int reply_received;
-	RTE_STD_C11
 	union {
 		struct {
 			struct async_request_param *param;
lib/eal/common/eal_interrupts.h +0 -1
index 482781b..c9d6744 100644
@@ -6,7 +6,6 @@
 #define EAL_INTERRUPTS_H
 
 struct rte_intr_handle {
-	RTE_STD_C11
 	union {
 		struct {
 			int dev_fd; /**< VFIO/UIO cfg device file descriptor */
lib/eal/common/malloc_mp.h +0 -2
index 8d14868..43dc2a8 100644
@@ -39,7 +39,6 @@ struct malloc_req_alloc {
 };
 
 struct malloc_req_free {
-	RTE_STD_C11
 	union {
 		void *addr;
 		uint64_t addr_64;
@@ -49,7 +48,6 @@ struct malloc_req_free {
 
 struct malloc_mp_req {
 	enum malloc_req_type t;
-	RTE_STD_C11
 	union {
 		struct malloc_req_alloc alloc_req;
 		struct malloc_req_free free_req;
lib/eal/include/generic/rte_atomic.h +0 -2
index aef44e2..82b9bfc 100644
@@ -1069,9 +1069,7 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)
 /**
  * 128-bit integer structure.
  */
-RTE_STD_C11
 typedef struct {
-	RTE_STD_C11
 	union {
 		uint64_t val[2];
 #ifdef RTE_ARCH_64
lib/eal/include/rte_common.h +0 -7
index 15765b4..77f937e 100644
@@ -34,13 +34,6 @@
 #endif
 #endif
 
-/** C extension macro for environments lacking C11 features. */
-#if !defined(__STDC_VERSION__) || __STDC_VERSION__ < 201112L
-#define RTE_STD_C11 __extension__
-#else
-#define RTE_STD_C11
-#endif
-
 /*
  * RTE_TOOLCHAIN_GCC is defined if the target is built with GCC,
  * while a host application (like pmdinfogen) may have another compiler.
lib/eal/include/rte_devargs.h +0 -1
index 38dee2f..9126798 100644
@@ -78,7 +78,6 @@ struct rte_devargs {
 	enum rte_dev_policy policy;
 	/** Name of the device. */
 	char name[RTE_DEV_NAME_MAX_LEN];
-	RTE_STD_C11
 	union {
 		const char *args; /**< legacy name. */
 		const char *drv_str; /**< driver-related part of device string. */
lib/eal/include/rte_memory.h +0 -2
index 99a1139..3a1c607 100644
@@ -47,7 +47,6 @@
  */
 struct rte_memseg {
 	rte_iova_t iova;            /**< Start IO address. */
-	RTE_STD_C11
 	union {
 		void *addr;         /**< Start virtual address. */
 		uint64_t addr_64;   /**< Makes sure addr is always 64 bits */
@@ -65,7 +64,6 @@ struct rte_memseg {
  * together with the array itself.
  */
 struct rte_memseg_list {
-	RTE_STD_C11
 	union {
 		void *base_va;
 		/**< Base virtual address for this memseg list. */
lib/eal/include/rte_memzone.h +0 -1
index ebcdae9..931497f 100644
@@ -51,7 +51,6 @@ struct rte_memzone {
 	char name[RTE_MEMZONE_NAMESIZE];  /**< Name of the memory zone. */
 
 	rte_iova_t iova;                  /**< Start IO address. */
-	RTE_STD_C11
 	union {
 		void *addr;                   /**< Start virtual address. */
 		uint64_t addr_64;             /**< Makes sure addr is always 64-bits */
lib/eal/linux/eal_vfio.h +0 -1
index dc8ef32..23a787a 100644
@@ -148,7 +148,6 @@ struct vfio_iommu_type {
 struct vfio_mp_param {
 	int req;
 	int result;
-	RTE_STD_C11
 	union {
 		int group_num;
 		int iommu_type_id;
lib/eal/x86/include/rte_atomic_32.h +0 -1
index c885a66..0f25863 100644
@@ -25,7 +25,6 @@
 rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src)
 {
 	uint8_t res;
-	RTE_STD_C11
 	union {
 		struct {
 			uint32_t l32;
lib/eal/x86/include/rte_cycles.h +0 -1
index a461a4d..23d664b 100644
@@ -25,7 +25,6 @@
 {
 	union {
 		uint64_t tsc_64;
-		RTE_STD_C11
 		struct {
 			uint32_t lo_32;
 			uint32_t hi_32;
Signature · 1 line
1.8.3.1
#33 lore raw
In reply to Tyler Retzlaff
Quoted 28 lines · Tyler Retzlaff

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

Tyler Retzlaff (32):
timer: remove use of RTE STD C11 macro
stack: remove use of RTE STD C11 macro
security: remove use of RTE STD C11 macro
sched: remove use of RTE STD C11 macro
ring: remove use of RTE STD C11 macro
regexdev: remove use of RTE STD C11 macro
rawdev: remove use of RTE STD C11 macro
power: remove use of RTE STD C11 macro
pipeline: remove use of RTE STD C11 macro
net: remove use of RTE STD C11 macro
mldev: remove use of RTE STD C11 macro
mempool: remove use of RTE STD C11 macro
mbuf: remove use of RTE STD C11 macro
ip_frag: remove use of RTE STD C11 macro
hash: remove use of RTE STD C11 macro
graph: remove use of RTE STD C11 macro
eventdev: remove use of RTE STD C11 macro
ethdev: remove use of RTE STD C11 macro
dmadev: remove use of RTE STD C11 macro
cryptodev: remove use of RTE STD C11 macro examples/ipsec-secgw: remove use of RTE STD C11 macro examples/ip_pipeline: remove use of RTE STD C11 macro net/sfc: remove use of RTE STD C11 macro net/octeontx: remove use of RTE STD C11 macro

Quoted 9 lines

net/mlx5: remove use of RTE STD C11 macro net/mlx4: remove use of RTE STD C11 macro net/igc: remove use of RTE STD C11 macro net/avp: remove use of RTE STD C11 macro dma/idxd: remove use of RTE STD C11 macro common/mlx5: remove use of RTE STD C11 macro common/cnxk: remove use of RTE STD C11 macro
eal: remove use and definition of RTE STD C11 macro

#35 lore raw
In reply to Tyler Retzlaff
Quoted 6 lines

From: Morten Brørup
Sent: Monday, 14 August 2023 10.45

Quoted 3 lines

From: Tyler Retzlaff [mailto:[email protected]]
Sent: Saturday, 12 August 2023 00.22

Quoted 6 lines
Quoted 2 lines

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

This was an easy one to review. :-)

By that, I obviously meant:

#36 lore raw
In reply to Tyler Retzlaff
Quoted 94 lines · Tyler Retzlaff

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

Tyler Retzlaff (32):
timer: remove use of RTE STD C11 macro
stack: remove use of RTE STD C11 macro
security: remove use of RTE STD C11 macro
sched: remove use of RTE STD C11 macro
ring: remove use of RTE STD C11 macro
regexdev: remove use of RTE STD C11 macro
rawdev: remove use of RTE STD C11 macro
power: remove use of RTE STD C11 macro
pipeline: remove use of RTE STD C11 macro
net: remove use of RTE STD C11 macro
mldev: remove use of RTE STD C11 macro
mempool: remove use of RTE STD C11 macro
mbuf: remove use of RTE STD C11 macro
ip_frag: remove use of RTE STD C11 macro
hash: remove use of RTE STD C11 macro
graph: remove use of RTE STD C11 macro
eventdev: remove use of RTE STD C11 macro
ethdev: remove use of RTE STD C11 macro
dmadev: remove use of RTE STD C11 macro
cryptodev: remove use of RTE STD C11 macro examples/ipsec-secgw: remove use of RTE STD C11 macro examples/ip_pipeline: remove use of RTE STD C11 macro net/sfc: remove use of RTE STD C11 macro net/octeontx: remove use of RTE STD C11 macro net/mlx5: remove use of RTE STD C11 macro net/mlx4: remove use of RTE STD C11 macro net/igc: remove use of RTE STD C11 macro net/avp: remove use of RTE STD C11 macro dma/idxd: remove use of RTE STD C11 macro common/mlx5: remove use of RTE STD C11 macro common/cnxk: remove use of RTE STD C11 macro
eal: remove use and definition of RTE STD C11 macro

 drivers/common/cnxk/hw/nix.h            |  7 -------
 drivers/common/cnxk/roc_nix.h           |  1 -
 drivers/common/cnxk/roc_npc.h           |  3 ---
 drivers/common/cnxk/roc_platform.h      |  1 -
 drivers/common/mlx5/mlx5_common_mp.h    |  2 --
 drivers/dma/idxd/idxd_hw_defs.h         |  1 -
 drivers/net/avp/rte_avp_common.h        |  2 --
 drivers/net/igc/igc_ethdev.h            |  2 --
 drivers/net/mlx4/mlx4.h                 |  1 -
 drivers/net/mlx5/mlx5.h                 |  4 ----
 drivers/net/octeontx/octeontx_rxtx.h    |  2 --
 drivers/net/sfc/sfc_flow.h              |  2 --
 drivers/net/sfc/sfc_mae.h               |  1 -
 drivers/net/sfc/sfc_stats.h             |  1 -
 examples/ip_pipeline/pipeline.h         |  2 --
 examples/ip_pipeline/thread.c           |  2 --
 examples/ipsec-secgw/event_helper.h     |  2 --
 examples/ipsec-secgw/flow.c             |  1 -
 lib/cryptodev/cryptodev_pmd.h           |  2 +-
 lib/cryptodev/rte_crypto_asym.h         |  4 ----
 lib/cryptodev/rte_crypto_sym.h          |  3 ---
 lib/cryptodev/rte_cryptodev.h           |  2 --
 lib/dmadev/rte_dmadev.h                 |  1 -
 lib/eal/common/eal_common_proc.c        |  1 -
 lib/eal/common/eal_interrupts.h         |  1 -
 lib/eal/common/malloc_mp.h              |  2 --
 lib/eal/include/generic/rte_atomic.h    |  2 --
 lib/eal/include/rte_common.h            |  7 -------
 lib/eal/include/rte_devargs.h           |  1 -
 lib/eal/include/rte_memory.h            |  2 --
 lib/eal/include/rte_memzone.h           |  1 -
 lib/eal/linux/eal_vfio.h                |  1 -
 lib/eal/x86/include/rte_atomic_32.h     |  1 -
 lib/eal/x86/include/rte_cycles.h        |  1 -
 lib/ethdev/rte_flow.h                   | 11 -----------
 lib/ethdev/rte_mtr.h                    |  1 -
 lib/ethdev/rte_tm.h                     |  3 ---
 lib/eventdev/event_timer_adapter_pmd.h  |  1 -
 lib/eventdev/eventdev_pmd.h             |  2 --
 lib/eventdev/rte_event_eth_rx_adapter.c |  1 -
 lib/eventdev/rte_event_timer_adapter.h  |  2 --
 lib/eventdev/rte_eventdev.h             |  1 -
 lib/graph/rte_graph.h                   |  3 ---
 lib/graph/rte_graph_worker_common.h     |  4 ----
 lib/hash/rte_thash.h                    |  2 --
 lib/ip_frag/ip_reassembly.h             |  1 -
 lib/mbuf/rte_mbuf_core.h                |  4 ----
 lib/mempool/rte_mempool.h               |  1 -
 lib/mldev/rte_mldev.h                   |  1 -
 lib/net/rte_ecpri.h                     |  3 ---
 lib/net/rte_higig.h                     |  1 -
 lib/net/rte_l2tpv2.h                    |  2 --
 lib/pipeline/rte_pipeline.h             |  1 -
 lib/pipeline/rte_swx_ipsec.h            |  1 -
 lib/pipeline/rte_table_action.h         |  4 ----
 lib/power/rte_power.h                   |  2 --
Quoted 8 lines
 lib/rawdev/rte_rawdev.h                 |  1 -
 lib/regexdev/rte_regexdev.h             |  4 ----
 lib/ring/rte_ring_core.h                |  3 ---
 lib/sched/rte_sched.c                   |  2 --
 lib/security/rte_security.h             |  5 -----
 lib/stack/rte_stack.h                   |  1 -
 lib/timer/rte_timer.h                   |  1 -
 63 files changed, 1 insertion(+), 137 deletions(-)

Thanks for the cleanup Tyler.
Applied.

Signature · 1 line
David Marchand
#37 lore raw
In reply to Tyler Retzlaff

12/08/2023 00:22, Tyler Retzlaff:

Quoted 2 lines

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

Did you check the occurences of __extension__?
I remember at least the case of bit-fields.
Is there any C standard allowing them?

#38 lore raw
Quoted 5 lines · Thomas Monjalon

12/08/2023 00:22, Tyler Retzlaff:

Quoted 2 lines

We now document C11 conformant compiler as a minimum, it's not necessary to mark C11 feature use with __extension__ to avoid warnings.

Did you check the occurences of __extension__?

i'm aware there is more cleanup to do of __extension__ when it was used directly instead of via the macro.

Quoted 2 lines

I remember at least the case of bit-fields.
Is there any C standard allowing them?

i'd have to see the specific example but bit-fields are often things avoided in the standard text.

the cleanups to use C11 features will be an ongoing work in progress

ty