soc: fsl: Explicitly include correct DT includes
Subsystems (2)
PATCH v2 1/1 soc: fsl: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
---
v2:
- Add qe.c
--- drivers/soc/fsl/dpaa2-console.c | 3 ++- drivers/soc/fsl/qe/qe.c | 3 ++- drivers/soc/fsl/qe/qe_common.c | 1 - drivers/soc/fsl/qe/qe_tdm.c | 4 +--- 4 files changed, 5 insertions(+), 6 deletions(-)
drivers/soc/fsl/dpaa2-console.c +2 -1
@@ -9,9 +9,10 @@#define pr_fmt (fmt) "dpaa2-console: " fmt#include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/of_address.h> #include <linux/miscdevice.h> +#include <linux/platform_device.h> #include <linux/uaccess.h> #include <linux/slab.h> #include <linux/fs.h>
drivers/soc/fsl/qe/qe.c +2 -1
@@ -25,7 +25,8 @@#include <linux/iopoll.h> #include <linux/crc32.h> #include <linux/mod_devicetable.h> -#include <linux/of_platform.h> +#include <linux/of.h> +#include <linux/platform_device.h> #include <soc/fsl/qe/immap_qe.h> #include <soc/fsl/qe/qe.h>
drivers/soc/fsl/qe/qe_common.c +0 -1
@@ -16,7 +16,6 @@#include <linux/genalloc.h> #include <linux/init.h> #include <linux/list.h> -#include <linux/of_device.h> #include <linux/spinlock.h> #include <linux/export.h> #include <linux/of.h>
drivers/soc/fsl/qe/qe_tdm.c +1 -3
@@ -9,9 +9,7 @@*/ #include <linux/io.h> #include <linux/kernel.h> -#include <linux/of_address.h> -#include <linux/of_irq.h> -#include <linux/of_platform.h> +#include <linux/of.h> #include <soc/fsl/qe/qe_tdm.h> static int set_tdm_framer (const char *tdm_framer_type)
Signature · 1 line
2.40.1
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:
Quoted 10 lines · On Mon, 24 Jul 2023 14:55:51 -0600 you wrote:
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.[...]
Here is the summary with links:
- [v2] soc: fsl: Explicitly include correct DT includes
https://git.kernel.org/soc/soc/c/5df5b2e04749
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html