Skip to contentSkip to conversation

ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access

PATCH In review mnlife 2 participants 2 messages Aug 14, 2023 – Aug 15, 2023

Subsystems (2)
lore
Share & tools
lore

mnlife

author
#0 lore raw

PATCH 1/1 ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access

When snd_soc_card_jack_new is not called or the call fails, calling this function causes a null pointer access

---
 sound/soc/soc-jack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-jack.c +1 -1
index f951acb2ce362..b2cc13b9c77b7 100644
@@ -37,7 +37,7 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
 	struct snd_soc_jack_pin *pin;
 	unsigned int sync = 0;
 
-	if (!jack)
+	if (!jack || !jack->jack)
 		return;
 	trace_snd_soc_jack_report(jack, mask, status);
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 4 lines · mnlife

When snd_soc_card_jack_new is not called or the call fails, calling this function causes a null pointer access

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-jack: calling snd_soc_jack_report causes a null pointer access

      commit: 62cc82e6486b9b66b340bbf5fb38b0171fb56a7f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark