Skip to contentSkip to conversation

net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset

PATCH Applied Alfred Lee 4 participants 4 messages Aug 15, 2023 – Aug 17, 2023

Subsystems (4)

v3 of 4 Applied 1/1 Latest is v4 →

lore
Share & tools
lore

Alfred Lee

author
#0 lore raw

PATCH v3 1/1 net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset

If the switch is reset during active EEPROM transactions, as in just after an SoC reset after power up, the I2C bus transaction may be cut short leaving the EEPROM internal I2C state machine in the wrong state. When the switch is reset again, the bad state machine state may result in data being read from the wrong memory location causing the switch to enter unexpected mode rendering it inoperational.

Fixes a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
---
 drivers/net/dsa/mv88e6xxx/chip.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/net/dsa/mv88e6xxx/chip.c +8 -0
index c7d51a539451..7af2f08a62f1 100644
@@ -3034,6 +3034,14 @@ static void mv88e6xxx_hardware_reset(struct mv88e6xxx_chip *chip)
 
 	/* If there is a GPIO connected to the reset pin, toggle it */
 	if (gpiod) {
+		/* If the switch has just been reset and not yet completed
+		 * loading EEPROM, the reset may interrupt the I2C transaction
+		 * mid-byte, causing the first EEPROM read after the reset
+		 * from the wrong location resulting in the switch booting
+		 * to wrong mode and inoperable.
+		 */
+		mv88e6xxx_g1_wait_eeprom_done(chip);
+
 		gpiod_set_value_cansleep(gpiod, 1);
 		usleep_range(10000, 20000);
 		gpiod_set_value_cansleep(gpiod, 0);
Signature · 1 line
2.41.0
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 7 lines · Alfred Lee

If the switch is reset during active EEPROM transactions, as in just after an SoC reset after power up, the I2C bus transaction may be cut short leaving the EEPROM internal I2C state machine in the wrong state. When the switch is reset again, the bad state machine state may result in data being read from the wrong memory location causing the switch to enter unexpected mode rendering it inoperational.

Hi Alfred

It is normal to place a history after the --- of what changed between each version.

Quoted 2 lines
Fixes a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")

Andrew

maintainer
#2 lore raw
In reply to Alfred Lee
Quoted 7 lines · On Mon, 14 Aug 2023 17:13:23 -0700 Alfred Lee wrote:

If the switch is reset during active EEPROM transactions, as in just after an SoC reset after power up, the I2C bus transaction may be cut short leaving the EEPROM internal I2C state machine in the wrong state. When the switch is reset again, the bad state machine state may result in data being read from the wrong memory location causing the switch to enter unexpected mode rendering it inoperational.

I'll apply this instead of the v4:

https://lore.kernel.org/all/[email protected]/

since you dropped Andrew's tag :( Please make sure you keep the tags you were given.

#3 lore raw
In reply to Alfred Lee
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 14 Aug 2023 17:13:23 -0700 you wrote:

If the switch is reset during active EEPROM transactions, as in just after an SoC reset after power up, the I2C bus transaction may be cut short leaving the EEPROM internal I2C state machine in the wrong state. When the switch is reset again, the bad state machine state may result in data being read from the wrong memory location causing the switch to enter unexpected mode rendering it inoperational.

[...]

Here is the summary with links:
- [net,v3] net: dsa: mv88e6xxx: Wait for EEPROM done before HW reset

    https://git.kernel.org/netdev/net/c/23d775f12dcd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html