net: fec: use napi_consume_skb() in fec_enet_tx_queue()
Subsystems (3)
Wei Fang
maintainerPATCH 1/1 net: fec: use napi_consume_skb() in fec_enet_tx_queue()
Now that the "budget" is passed into fec_enet_tx_queue(), one optimization we can do is to use napi_consume_skb() to instead of dev_kfree_skb_any().
Signed-off-by Wei Fang <[email protected]>
Suggested-by Alexander H Duyck <[email protected]>
--- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
@@ -1494,7 +1494,7 @@ fec_enet_tx_queue(struct net_device *ndev, u16 queue_id, int budget) }/* Free the sk buffer associated with this last transmit */ -dev_kfree_skb_any (skb); +napi_consume_skb (skb, budget); }else if (txq->tx_buf[index].type ==FEC_TXBUF_T_XDP_NDO ) {xdp_return_frame_rx_napi (xdpf); }else {/* recycle pages of XDP_TX frames */
Signature · 1 line
2.25.1
Quoted 10 lines · Wei Fang
Now that the "budget" is passed into
fec_enet_tx_queue(), one optimization we can do is to usenapi_consume_skb()to instead ofdev_kfree_skb_any().Signed-off-by Wei Fang <[email protected]>Suggested-by Alexander H Duyck <[email protected]>--- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by Leon Romanovsky <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 16 Aug 2023 17:02:42 +0800 you wrote:
Now that the "budget" is passed into
fec_enet_tx_queue(), one optimization we can do is to usenapi_consume_skb()to instead ofdev_kfree_skb_any().Signed-off-by Wei Fang <[email protected]>Suggested-by Alexander H Duyck <[email protected]>[...]
Here is the summary with links:
- [net-next] net: fec: use napi_consume_skb() in fec_enet_tx_queue()
https://git.kernel.org/netdev/net-next/c/91a10efc89dc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html