Skip to contentSkip to conversation

octeontx2-af: SDP: fix receive link config

PATCH Applied Hariprasad Kelam 3 participants 3 messages Aug 17, 2023 – Aug 18, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 octeontx2-af: SDP: fix receive link config

On SDP interfaces, frame oversize and undersize errors are observed as driver is not considering packet sizes of all subscribers of the link before updating the link config.

This patch fixes the same.

Fixes 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths")
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +2 -1
index 04b0e885f9d2..c2f68678e947 100644
@@ -4270,9 +4270,10 @@ int rvu_mbox_handler_nix_set_hw_frs(struct rvu *rvu, struct nix_frs_cfg *req,
 	if (link < 0)
 		return NIX_AF_ERR_RX_LINK_INVALID;
 
-	nix_find_link_frs(rvu, req, pcifunc);
 
 linkcfg:
+	nix_find_link_frs(rvu, req, pcifunc);
+
 	cfg = rvu_read64(rvu, blkaddr, NIX_AF_RX_LINKX_CFG(link));
 	cfg = (cfg & ~(0xFFFFULL << 16)) | ((u64)req->maxlen << 16);
 	if (req->update_minlen)
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Hariprasad Kelam

On SDP interfaces, frame oversize and undersize errors are observed as driver is not considering packet sizes of all subscribers of the link before updating the link config.

Quoted 9 lines

This patch fixes the same.

Fixes 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths")
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Thanks,

#2 lore raw
In reply to Hariprasad Kelam
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Thu, 17 Aug 2023 12:00:06 +0530 you wrote:

On SDP interfaces, frame oversize and undersize errors are observed as driver is not considering packet sizes of all subscribers of the link before updating the link config.

This patch fixes the same.

Fixes 9b7dd87ac071 ("octeontx2-af: Support to modify min/max allowed packet lengths")

[...]

Here is the summary with links:
- [net] octeontx2-af: SDP: fix receive link config

    https://git.kernel.org/netdev/net/c/05f3d5bc2352

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html