stmmac: intel: Enable correction of MAC propagation delay
Subsystems (4)
PATCH 1/1 stmmac: intel: Enable correction of MAC propagation delay
All captured timestamps should be corrected by PHY, MAC and CDC introduced latency/errors. The CDC correction is already used. Enable MAC propagation delay correction as well which is available since commit 26cfb838aa00 ("net: stmmac:
correct MAC propagation delay").
Before:
|ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1
After:
|ptp4l[620.012]: rms 7 max 20 freq +195 +/- 14 delay 345 +/- 1
Tested on Intel Elkhart Lake.
--- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +1 -0
@@ -627,6 +627,7 @@ static int ehl_common_data(struct pci_dev *pdev, plat->rx_queues_to_use =8 ; plat->tx_queues_to_use =8 ; plat->flags |=STMMAC_FLAG_USE_PHY_WOL ; + plat->flags |=STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY ; plat->safety_feat_cfg->tsoee =1 ; plat->safety_feat_cfg->mrxpee =1 ;
Signature · 1 line
2.39.2
Quoted 8 lines · Kurt Kanzenbach
All captured timestamps should be corrected by PHY, MAC and CDC introduced latency/errors. The CDC correction is already used. Enable MAC propagation delay correction as well which is available since commit
26cfb838aa00("net: stmmac:
correct MAC propagation delay").Before:
|ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1
Quoted 6 lines
After:
|ptp4l[620.012]: rms 7 max 20 freq +195 +/- 14 delay 345 +/- 1Tested on Intel Elkhart Lake.
Signed-off-by Kurt Kanzenbach <[email protected]>
LGTM
feel free to add my
Quoted 16 lines
--- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +1
-0@@ -627,6 +627,7 @@ static int ehl_common_data(struct pci_dev *pdev, plat->rx_queues_to_use =8 ; plat->tx_queues_to_use =8 ; plat->flags |=STMMAC_FLAG_USE_PHY_WOL ; + plat->flags |=STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY ; plat->safety_feat_cfg->tsoee =1 ; plat->safety_feat_cfg->mrxpee =1 ;
Signature · 4 lines
Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 9 lines · On Fri, 18 Aug 2023 13:14:01 +0200 you wrote:
All captured timestamps should be corrected by PHY, MAC and CDC introduced latency/errors. The CDC correction is already used. Enable MAC propagation delay correction as well which is available since commit
26cfb838aa00("net: stmmac:
correct MAC propagation delay").Before:
|ptp4l[390.458]: rms 7 max 21 freq +177 +/- 14 delay 357 +/- 1[...]
Here is the summary with links:
- [net-next] stmmac: intel: Enable correction of MAC propagation delay
https://git.kernel.org/netdev/net-next/c/58f2ffdedf7b
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html