Skip to contentSkip to conversation

net: fec: add statistics for XDP_TX

PATCH Applied Wei Fang 2 participants 2 messages Aug 24, 2023 – Aug 25, 2023

Subsystems (3)
lore
Share & tools
lore

Wei Fang

author maintainer
#0 lore raw

PATCH 1/1 net: fec: add statistics for XDP_TX

The FEC driver supports the statistics for XDP actions except for XDP_TX before, because the XDP_TX was not supported when adding the statistics for XDP. Now the FEC driver has supported XDP_TX since commit f601899e4321 ("net: fec: add XDP_TX feature support"). So it's reasonable and necessary to add statistics for XDP_TX.

---
 drivers/net/ethernet/freescale/fec_main.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +4 -1
index 8909899e9a31..77c8e9cfb445 100644
@@ -1590,9 +1590,12 @@ fec_enet_run_xdp(struct fec_enet_private *fep, struct bpf_prog *prog,
 		break;
 
 	case XDP_TX:
+		rxq->stats[RX_XDP_TX]++;
 		err = fec_enet_xdp_tx_xmit(fep, cpu, xdp, sync);
-		if (unlikely(err))
+		if (unlikely(err)) {
+			rxq->stats[RX_XDP_TX_ERRORS]++;
 			goto xdp_err;
+		}
 
 		ret = FEC_ENET_XDP_TX;
 		break;
Signature · 1 line
2.25.1
#1 lore raw
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 9 lines · On Thu, 24 Aug 2023 14:11:50 +0800 you wrote:

The FEC driver supports the statistics for XDP actions except for XDP_TX before, because the XDP_TX was not supported when adding the statistics for XDP. Now the FEC driver has supported XDP_TX since commit f601899e4321 ("net: fec: add XDP_TX feature support"). So it's reasonable and necessary to add statistics for XDP_TX.

[...]

Here is the summary with links:
- [net-next] net: fec: add statistics for XDP_TX

    https://git.kernel.org/netdev/net-next/c/9540329452b7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html