arch: include asm/cacheflush.h in asm/hugetlb.h
Subsystems (4)
cover arch: include asm/cacheflush.h in asm/hugetlb.h
Three architectures are using PG_dcache_clean in their asm/hugetlb.h, but relying on accident to include the asm/cacheflush.h which defines it.
1/3 arm: include asm/cacheflush.h in asm/hugetlb.h 2/3 arm64: include asm/cacheflush.h in asm/hugetlb.h 3/3 riscv: include asm/cacheflush.h in asm/hugetlb.h
arch/arm/include/asm/hugetlb.h | 1 + arch/arm64/include/asm/hugetlb.h | 1 + arch/riscv/include/asm/hugetlb.h | 1 + 3 files changed, 3 insertions(+)
Hugh
PATCH 1/3 arm: include asm/cacheflush.h in asm/hugetlb.h
PG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h, but better include it directly (like arch/sh/include/asm/hugetlb.h does).
--- arch/arm/include/asm/hugetlb.h | 1 + 1 file changed, 1 insertion(+)
arch/arm/include/asm/hugetlb.h +1 -0
@@ -10,6 +10,7 @@#ifndef _ASM_ARM_HUGETLB_H#define _ASM_ARM_HUGETLB_H +#include <asm/cacheflush.h> #include <asm/page.h> #include <asm/hugetlb-3level.h> #include <asm-generic/hugetlb.h>
Signature · 1 line
2.35.3
PATCH 2/3 arm64: include asm/cacheflush.h in asm/hugetlb.h
In reply to Hugh DickinsPG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h, but better include it directly (like arch/sh/include/asm/hugetlb.h does).
--- arch/arm64/include/asm/hugetlb.h | 1 + 1 file changed, 1 insertion(+)
arch/arm64/include/asm/hugetlb.h +1 -0
@@ -10,6 +10,7 @@#ifndef __ASM_HUGETLB_H#define __ASM_HUGETLB_H +#include <asm/cacheflush.h> #include <asm/page.h> #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
Signature · 1 line
2.35.3
PATCH 3/3 riscv: include asm/cacheflush.h in asm/hugetlb.h
In reply to Hugh DickinsPG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h, but better include it directly (like arch/sh/include/asm/hugetlb.h does).
--- arch/riscv/include/asm/hugetlb.h | 1 + 1 file changed, 1 insertion(+)
arch/riscv/include/asm/hugetlb.h +1 -0
@@ -2,6 +2,7 @@#ifndef _ASM_RISCV_HUGETLB_H#define _ASM_RISCV_HUGETLB_H +#include <asm/cacheflush.h> #include <asm/page.h> static inline void arch_clear_hugepage_flags (struct page *page)
Signature · 1 line
2.35.3
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Hello:
This series was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:
Quoted 8 lines · On Sun, 13 Aug 2023 21:50:34 -0700 (PDT) you wrote:
Three architectures are using
PG_dcache_cleanin theirasm/hugetlb.h, but relying on accident to include theasm/cacheflush.hwhich defines it.1/3 arm: include
asm/cacheflush.hinasm/hugetlb.h2/3 arm64: includeasm/cacheflush.hinasm/hugetlb.h3/3 riscv: includeasm/cacheflush.hinasm/hugetlb.h[...]
Here is the summary with links:
- [1/3] arm: include asm/cacheflush.h in asm/hugetlb.h (no matching commit)
- [2/3] arm64: include asm/cacheflush.h in asm/hugetlb.h (no matching commit)
- [3/3] riscv: include asm/cacheflush.h in asm/hugetlb.h
https://git.kernel.org/riscv/c/3aaad36808b5
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Palmer Dabbelt
AppliedRe: (subset) [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h
In reply to Hugh DickinsQuoted 8 lines · Hugh Dickins
Three architectures are using
PG_dcache_cleanin theirasm/hugetlb.h, but relying on accident to include theasm/cacheflush.hwhich defines it.1/3 arm: include
asm/cacheflush.hinasm/hugetlb.h2/3 arm64: includeasm/cacheflush.hinasm/hugetlb.h3/3 riscv: includeasm/cacheflush.hinasm/hugetlb.h[...]
Applied, thanks!
[3/3] riscv: include asm/cacheflush.h in asm/hugetlb.h
https://git.kernel.org/palmer/c/3aaad36808b5
Best regards,
Signature · 1 line
Palmer Dabbelt <[email protected]>