Skip to contentSkip to conversation

bus/ifpga: remove useless check while browsing devices

PATCH Applied Maxime Gouin 4 participants 4 messages Jan 6, 2022 – Jan 19, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus/ifpga: remove useless check while browsing devices

reported by code analysis tool C++test (version 10.4):

Quoted 3 lines

/build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
67 Condition "afu_dev" is always evaluated to true
81 Condition "afu_dev" is always evaluated to true

The "for" loop already checks that afu_dev is not NULL.

Fixes 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/ifpga/ifpga_bus.c +2 -4
index cbc680928486..c5c8bbd57219 100644
@@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			afu_dev->rawdev == rdev &&
+		if (afu_dev->rawdev == rdev &&
 			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
 			return afu_dev;
 	}
@@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			!strcmp(afu_dev->device.name, name))
+		if (!strcmp(afu_dev->device.name, name))
 			return afu_dev;
 	}
 	return NULL;
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Maxime Gouin

reported by code analysis tool C++test (version 10.4):

Quoted 3 lines

/build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
67 Condition "afu_dev" is always evaluated to true
81 Condition "afu_dev" is always evaluated to true

The "for" loop already checks that afu_dev is not NULL.

Fixes 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Quoted 2 lines
Quoted 29 lines
---
  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/ifpga/ifpga_bus.c +2 -4
index cbc680928486..c5c8bbd57219 100644
@@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
  	struct rte_afu_device *afu_dev = NULL;
 
  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			afu_dev->rawdev == rdev &&
+		if (afu_dev->rawdev == rdev &&
  			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
  			return afu_dev;
  	}
@@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
  	struct rte_afu_device *afu_dev = NULL;
 
  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			!strcmp(afu_dev->device.name, name))
+		if (!strcmp(afu_dev->device.name, name))
  			return afu_dev;
  	}
  	return NULL;
Acked-by on v1 1/1
#2 lore raw
In reply to Maxime Gouin

Hi,

Thanks.

Quoted 50 lines

-----Original Message-----
From: Maxime Gouin <[email protected]>
Sent: Wednesday, January 05, 2022 18:27
To: [email protected]
Cc: Maxime Gouin <[email protected]>; Xu, Rosen <[email protected]>; Zhang, Qi Z <[email protected]>; Zhang, Tianfei <[email protected]>; Olivier Matz <[email protected]>
Subject: [PATCH] bus/ifpga: remove useless check while browsing devices

reported by code analysis tool C++test (version 10.4):

Quoted 3 lines

/build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
67 Condition "afu_dev" is always evaluated to true
81 Condition "afu_dev" is always evaluated to true

The "for" loop already checks that afu_dev is not NULL.

Fixes 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/ifpga/ifpga_bus.c +2 -5
index cbc680928486..c5c8bbd57219 100644
@@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			afu_dev->rawdev == rdev &&
+		if (afu_dev->rawdev == rdev &&
 			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
 			return afu_dev;
 	}
@@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			!strcmp(afu_dev->device.name, name))
+		if (!strcmp(afu_dev->device.name, name))
 			return afu_dev;
 	}
 	return NULL;
--
Quoted 1 line

2.30.2

#3 lore raw
Quoted 6 lines
Quoted 6 lines

reported by code analysis tool C++test (version 10.4):

Quoted 3 lines

/build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
67 Condition "afu_dev" is always evaluated to true
81 Condition "afu_dev" is always evaluated to true

Quoted 8 lines
Quoted 6 lines

The "for" loop already checks that afu_dev is not NULL.

Fixes 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Applied, thanks