pwm: Explicitly include correct DT includes
Subsystems (22)
PATCH 1/1 pwm: Explicitly include correct DT includes
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
--- drivers/pwm/core.c | 1 + drivers/pwm/pwm-apple.c | 1 + drivers/pwm/pwm-atmel-hlcdc.c | 1 + drivers/pwm/pwm-atmel-tcb.c | 3 +-- drivers/pwm/pwm-atmel.c | 1 - drivers/pwm/pwm-berlin.c | 1 + drivers/pwm/pwm-cros-ec.c | 1 + drivers/pwm/pwm-fsl-ftm.c | 3 +-- drivers/pwm/pwm-hibvt.c | 2 +- drivers/pwm/pwm-imx1.c | 1 - drivers/pwm/pwm-jz4740.c | 2 +- drivers/pwm/pwm-lp3943.c | 1 + drivers/pwm/pwm-lpc18xx-sct.c | 1 + drivers/pwm/pwm-mediatek.c | 1 - drivers/pwm/pwm-meson.c | 1 - drivers/pwm/pwm-microchip-core.c | 2 +- drivers/pwm/pwm-mtk-disp.c | 1 - drivers/pwm/pwm-pxa.c | 1 + drivers/pwm/pwm-sifive.c | 1 + drivers/pwm/pwm-sl28cpld.c | 1 + drivers/pwm/pwm-sprd.c | 1 + drivers/pwm/pwm-sun4i.c | 1 - drivers/pwm/pwm-sunplus.c | 1 + drivers/pwm/pwm-tegra.c | 1 - drivers/pwm/pwm-tiecap.c | 2 +- drivers/pwm/pwm-tiehrpwm.c | 2 +- drivers/pwm/pwm-visconti.c | 2 +- drivers/pwm/pwm-vt8500.c | 5 +---- 28 files changed, 21 insertions(+), 21 deletions(-)
drivers/pwm/core.c +1 -0
@@ -8,6 +8,7 @@#include <linux/acpi.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/pwm.h> #include <linux/radix-tree.h> #include <linux/list.h>
drivers/pwm/pwm-apple.c +1 -0
@@ -12,6 +12,7 @@* - When APPLE_PWM_CTRL is set to 0, the output is constant low */ +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-atmel-hlcdc.c +1 -0
@@ -10,6 +10,7 @@#include <linux/delay.h> #include <linux/mfd/atmel-hlcdc.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/regmap.h>
drivers/pwm/pwm-atmel-tcb.c +1 -2
@@ -19,8 +19,7 @@#include <linux/mfd/syscon.h> #include <linux/platform_device.h> #include <linux/pwm.h> -#include <linux/of_device.h> -#include <linux/of_irq.h> +#include <linux/of.h> #include <linux/regmap.h> #include <linux/slab.h> #include <soc/at91/atmel_tcb.h>
drivers/pwm/pwm-atmel.c +0 -1
@@ -25,7 +25,6 @@#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-berlin.c +1 -0
@@ -13,6 +13,7 @@#include <linux/clk.h> #include <linux/io.h> #include <linux/kernel.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-cros-ec.c +1 -0
@@ -6,6 +6,7 @@*/ #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_data/cros_ec_commands.h> #include <linux/platform_data/cros_ec_proto.h> #include <linux/platform_device.h>
drivers/pwm/pwm-fsl-ftm.c +1 -2
@@ -11,8 +11,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/of_address.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm.h> #include <linux/pwm.h>
drivers/pwm/pwm-hibvt.c +1 -1
@@ -10,7 +10,7 @@#include <linux/delay.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/reset.h>
drivers/pwm/pwm-imx1.c +0 -1
@@ -14,7 +14,6 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-jz4740.c +1 -1
@@ -15,7 +15,7 @@#include <linux/mfd/ingenic-tcu.h> #include <linux/mfd/syscon.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/regmap.h>
drivers/pwm/pwm-lp3943.c +1 -0
@@ -10,6 +10,7 @@#include <linux/err.h> #include <linux/mfd/lp3943.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-lpc18xx-sct.c +1 -0
@@ -22,6 +22,7 @@#include <linux/clk.h> #include <linux/err.h> #include <linux/io.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-mediatek.c +0 -1
@@ -14,7 +14,6 @@#include <linux/module.h> #include <linux/clk.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-meson.c +0 -1
@@ -37,7 +37,6 @@#include <linux/math64.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-microchip-core.c +1 -1
@@ -37,7 +37,7 @@#include <linux/math.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-mtk-disp.c +0 -1
@@ -11,7 +11,6 @@#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/slab.h>
drivers/pwm/pwm-pxa.c +1 -0
@@ -15,6 +15,7 @@* input clock (PWMCR_SD is set) and the output is driven to inactive. */ +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/platform_device.h>
drivers/pwm/pwm-sifive.c +1 -0
@@ -13,6 +13,7 @@*/ #include <linux/clk.h> #include <linux/io.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-sl28cpld.c +1 -0
@@ -38,6 +38,7 @@#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/pwm.h> #include <linux/regmap.h>
drivers/pwm/pwm-sprd.c +1 -0
@@ -7,6 +7,7 @@#include <linux/err.h> #include <linux/io.h> #include <linux/math64.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-sun4i.c +0 -1
@@ -17,7 +17,6 @@#include <linux/jiffies.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pwm.h> #include <linux/reset.h>
drivers/pwm/pwm-sunplus.c +1 -0
@@ -23,6 +23,7 @@#include <linux/clk.h> #include <linux/io.h> #include <linux/kernel.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-tegra.c +0 -1
@@ -41,7 +41,6 @@#include <linux/io.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_device.h> #include <linux/pm_opp.h> #include <linux/pwm.h> #include <linux/platform_device.h>
drivers/pwm/pwm-tiecap.c +1 -1
@@ -12,7 +12,7 @@#include <linux/clk.h> #include <linux/pm_runtime.h> #include <linux/pwm.h> -#include <linux/of_device.h> +#include <linux/of.h> /* ECAP registers and bits definitions */ #define CAP1 0x08
drivers/pwm/pwm-tiehrpwm.c +1 -1
@@ -12,7 +12,7 @@#include <linux/err.h> #include <linux/clk.h> #include <linux/pm_runtime.h> -#include <linux/of_device.h> +#include <linux/of.h> /* EHRPWM registers and bits definitions */
drivers/pwm/pwm-visconti.c +1 -1
@@ -21,7 +21,7 @@#include <linux/err.h> #include <linux/io.h> #include <linux/module.h> -#include <linux/of_device.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pwm.h>
drivers/pwm/pwm-vt8500.c +1 -4
@@ -6,6 +6,7 @@* Copyright (C) 2010 Alexey Charkov <[email protected]> */ +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/platform_device.h>
@@ -18,10 +19,6 @@#include <asm/div64.h> -#include <linux/of.h> -#include <linux/of_device.h> -#include <linux/of_address.h> -/* * SoC architecture allocates register space for 4 PWMs but only * 2 are currently implemented.
Signature · 1 line
2.40.1
Quoted 10 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.Signed-off-by Rob Herring <[email protected]>
For pwm-cros-ec.c:
Quoted 8 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
so the eventual goal here is to prepare for:
- drop #include <linux/of_device.h> from include/linux/of_platform.h
- drop #include <linux/of.h> from include/linux/of_device.h
- drop #include <linux/of_platform.h> from include/linux/of_device.h
- drop #include <linux/platform_device.h> from include/linux/of_device.h
- drop #include <linux/platform_device.h> from include/linux/of_platform.h
Quoted 37 lines
Signed-off-by Rob Herring <[email protected]>--- drivers/pwm/core.c | 1 + drivers/pwm/pwm-apple.c | 1 + drivers/pwm/pwm-atmel-hlcdc.c | 1 + drivers/pwm/pwm-atmel-tcb.c | 3 +-- drivers/pwm/pwm-atmel.c | 1 - drivers/pwm/pwm-berlin.c | 1 + drivers/pwm/pwm-cros-ec.c | 1 + drivers/pwm/pwm-fsl-ftm.c | 3 +-- drivers/pwm/pwm-hibvt.c | 2 +- drivers/pwm/pwm-imx1.c | 1 - drivers/pwm/pwm-jz4740.c | 2 +- drivers/pwm/pwm-lp3943.c | 1 + drivers/pwm/pwm-lpc18xx-sct.c | 1 + drivers/pwm/pwm-mediatek.c | 1 - drivers/pwm/pwm-meson.c | 1 - drivers/pwm/pwm-microchip-core.c | 2 +- drivers/pwm/pwm-mtk-disp.c | 1 - drivers/pwm/pwm-pxa.c | 1 + drivers/pwm/pwm-sifive.c | 1 + drivers/pwm/pwm-sl28cpld.c | 1 + drivers/pwm/pwm-sprd.c | 1 + drivers/pwm/pwm-sun4i.c | 1 - drivers/pwm/pwm-sunplus.c | 1 + drivers/pwm/pwm-tegra.c | 1 - drivers/pwm/pwm-tiecap.c | 2 +- drivers/pwm/pwm-tiehrpwm.c | 2 +- drivers/pwm/pwm-visconti.c | 2 +- drivers/pwm/pwm-vt8500.c | 5 +---- 28 files changed, 21 insertions(+), 21 deletions(-)drivers/pwm/core.c +0
-0
drivers/pwm/core.c line 14
Quoted 7 lines
drivers/pwm/core.c +1
-0@@ -8,6 +8,7 @@#include <linux/acpi.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/pwm.h> #include <linux/radix-tree.h> #include <linux/list.h>
This file includes neither of_device.h nor of_platform.h and up to now gets of.h via <linux/pwm.h>.
What is your plan for <linux/pwm.h>'s include? I think it would only need
struct of_phandle_args;
to replace that. (But that would need another patch like this one, as then e.g. drivers/pwm/pwm-sl28cpld.c fails to compile because device_property_read_u32() is undeclared. It would need to #include <linux/property.h> which now it gets transitively via <linux/of.h>.)
If <linux/pwm.h> is planed to continue #including <linux/of.h>, the explicit include here isn't necessary (and probably elsewhere).
I don't care much either way, but maybe your quest would be a bit simpler if you only touch files that include the two files you want to modify?
*shrug*, this patch is still an improvement so:
Another thing I wonder is: How did you identify the files that need these includes. I guess you have a list of types for each header and search for files that use any of the types but doesn't include the respecitve header? I wonder if tracking this type -> header mapping in machine readable form somewhere would be nice, to e.g. make checkpatch warn if a file uses struct of_node but only gets it by chance?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 11 lines · Uwe Kleine-König
Quoted 8 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 7 lines
so the eventual goal here is to prepare for:
- drop #include <
linux/of_device.h> frominclude/linux/of_platform.h
- drop #include <linux/of.h> frominclude/linux/of_device.h
- drop #include <linux/of_platform.h> frominclude/linux/of_device.h
- drop #include <linux/platform_device.h> frominclude/linux/of_device.h
- drop #include <linux/platform_device.h> frominclude/linux/of_platform.h
Yes.
Quoted 38 lines
Quoted 38 lines
Signed-off-by Rob Herring <[email protected]>--- drivers/pwm/core.c | 1 + drivers/pwm/pwm-apple.c | 1 + drivers/pwm/pwm-atmel-hlcdc.c | 1 + drivers/pwm/pwm-atmel-tcb.c | 3 +-- drivers/pwm/pwm-atmel.c | 1 - drivers/pwm/pwm-berlin.c | 1 + drivers/pwm/pwm-cros-ec.c | 1 + drivers/pwm/pwm-fsl-ftm.c | 3 +-- drivers/pwm/pwm-hibvt.c | 2 +- drivers/pwm/pwm-imx1.c | 1 - drivers/pwm/pwm-jz4740.c | 2 +- drivers/pwm/pwm-lp3943.c | 1 + drivers/pwm/pwm-lpc18xx-sct.c | 1 + drivers/pwm/pwm-mediatek.c | 1 - drivers/pwm/pwm-meson.c | 1 - drivers/pwm/pwm-microchip-core.c | 2 +- drivers/pwm/pwm-mtk-disp.c | 1 - drivers/pwm/pwm-pxa.c | 1 + drivers/pwm/pwm-sifive.c | 1 + drivers/pwm/pwm-sl28cpld.c | 1 + drivers/pwm/pwm-sprd.c | 1 + drivers/pwm/pwm-sun4i.c | 1 - drivers/pwm/pwm-sunplus.c | 1 + drivers/pwm/pwm-tegra.c | 1 - drivers/pwm/pwm-tiecap.c | 2 +- drivers/pwm/pwm-tiehrpwm.c | 2 +- drivers/pwm/pwm-visconti.c | 2 +- drivers/pwm/pwm-vt8500.c | 5 +---- 28 files changed, 21 insertions(+), 21 deletions(-)drivers/pwm/core.c +0
-0@@ -8,6 +8,7 @@
Quoted 9 lines
drivers/pwm/core.c line 14
Quoted 6 lines
drivers/pwm/core.c +1
-0#include <linux/acpi.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/pwm.h> #include <linux/radix-tree.h> #include <linux/list.h> This file includes neither
of_device.hnorof_platform.hand up to now getsof.hvia <linux/pwm.h>.
Indeed.
Quoted 3 lines
What is your plan for <linux/pwm.h>'s include? I think it would only need
struct of_phandle_args;
Here's what I'm testing with:
include/linux/pwm.h +3 -1
@@ -4,8 +4,10 @@#include <linux/err.h> #include <linux/mutex.h> -#include <linux/of.h> +struct device ; +struct fwnode_handle ; +struct of_phandle_args ;struct pwm_chip ;/**
Quoted 5 lines
to replace that. (But that would need another patch like this one, as then e.g.
drivers/pwm/pwm-sl28cpld.cfails to compile becausedevice_property_read_u32()is undeclared. It would need to #include <linux/property.h> which now it gets transitively via <linux/of.h>.)
property.h is added in this patch, so it should be okay?
Quoted 2 lines
If <
linux/pwm.h> is planed to continue #including <linux/of.h>, the explicit include here isn't necessary (and probably elsewhere).
I would like to drop including of.h, but probably not this cycle. Either way, I thought kernel best practice was to not rely on implicit includes.
BTW, linux/i2c.h is another source of lots of implicit of.h includes. That one looks like we can't get rid of.
Quoted 3 lines
I don't care much either way, but maybe your quest would be a bit simpler if you only touch files that include the two files you want to modify?
Yes, that's how it started. I kind of decided it wasn't worth trying to split things up by every separate reason explicit includes were not correct.
Quoted 11 lines
*shrug*, this patch is still an improvement so:
Acked-by Uwe Kleine-Köng <[email protected]>Another thing I wonder is: How did you identify the files that need these includes. I guess you have a list of types for each header and search for files that use any of the types but doesn't include the respecitve header? I wonder if tracking this type -> header mapping in machine readable form somewhere would be nice, to e.g. make checkpatch warn if a file uses struct
of_nodebut only gets it by chance?
It's been less automated than I'd like. It's been a lot of grepping with a list of symbols the headers provide. For example, I get all the files including of_device.h and then get the ones with no symbols from of_device.h. And then do a manual review of what are the correct headers for the file. And then run thru builds and fix all the issues.
Rob
Hello Thierry,
Quoted 1 line · Uwe Kleine-König
Acked-by Uwe Kleine-Köng <[email protected]>
I mistyped my name and this made it into your for-next branch. It would be great if you fixed it, e.g. using:
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch -f --msg-filter 'sed "s/ng <u.kl/nig <u.kl/"' linus/master..
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Quoted 9 lines · Uwe Kleine-König
Hello Thierry,
Quoted 1 line · Uwe Kleine-König
Acked-by Uwe Kleine-Köng <[email protected]>I mistyped my name and this made it into your for-next branch. It would be great if you fixed it, e.g. using:
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch -f --msg-filter 'sed "s/ng <u.kl/nig <u.kl/"' linus/master..
Done.
Thierry
Hi,
Quoted 45 lines
-----Original Message-----
From: Rob Herring <[email protected]>
Sent: Saturday, July 15, 2023 2:49 AM
To: Thierry Reding <[email protected]>; Uwe Kleine-König <[email protected]>; Hector Martin <[email protected]>; Sven Peter <[email protected]>; Alyssa Rosenzweig <[email protected]>; Nicolas Ferre <[email protected]>; Alexandre Belloni <[email protected]>; Claudiu Beznea <[email protected]>; Benson Leung <[email protected]>; Guenter Roeck <[email protected]>; Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>; Pengutronix Kernel Team <[email protected]>; Fabio Estevam <[email protected]>; NXP Linux Team <[email protected]>; Paul Cercueil <[email protected]>; Vladimir Zapolskiy <[email protected]>; Neil Armstrong <[email protected]>; Kevin Hilman <[email protected]>; Jerome Brunet <[email protected]>; Martin Blumenstingl <[email protected]>; Conor Dooley <[email protected]>; Daire McNamara <[email protected]>; Matthias Brugger <[email protected]>; AngeloGioacchino Del Regno <[email protected]>; Palmer Dabbelt <[email protected]>; Paul Walmsley <[email protected]>; Michael Walle <[email protected]>; Orson Zhai <[email protected]>; Baolin Wang <[email protected]>; Chunyan Zhang <[email protected]>; Chen-Yu Tsai <[email protected]>; Jernej Skrabec <[email protected]>; Samuel Holland <[email protected]>; Hammer Hsieh <[email protected]>; Jonathan Hunter <[email protected]>; iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT ○OST) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH] pwm: Explicitly include correct DT includesThe DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 1 line
Signed-off-by Rob Herring <[email protected]>
For drivers/pwm/pwm-visconti.c:
Best regards,
Nobuhiro
Thierry Reding
AppliedQuoted 10 lines · Rob Herring
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.[...]
Applied, thanks!
[1/1] pwm: Explicitly include correct DT includes
commit: 8d171282110fcde89bb4289c4010a15aca5cec95
Best regards,
Signature · 1 line
Thierry Reding <[email protected]>
This patch was applied to chrome-platform/linux.git (for-kernelci) by Thierry Reding <[email protected]>:
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci) by Thierry Reding <[email protected]>:
Quoted 10 lines · On Fri, 14 Jul 2023 11:48:50 -0600 you wrote:
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.[...]
Here is the summary with links:
- pwm: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/0a41b0c5d97a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Hello,
Quoted 13 lines · On Mon, Sep 11, 2023 at 04:31:40AM +0000…
This patch was applied to chrome-platform/linux.git (for-kernelci) by Thierry Reding <[email protected]>:
Quoted 9 lines · On Fri, 14 Jul 2023 11:48:50 -0600 you wrote:
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Quoted 7 lines
Quoted 1 line
[...]
Here is the summary with links:
- pwm: Explicitly include correct DT includeshttps://git.kernel.org/chrome-platform/c/0a41b0c5d97aYou are awesome, thank you!
It's a bit strange to get this notification given that this patch was applied via the pwm tree and only made it into the chrome-platform/linux.git repo via an update to v6.6-rc1.
It's not a big problem, but if such mail could be suppressed that would be nice.
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
This patch was applied to chrome-platform/linux.git (for-next) by Thierry Reding <[email protected]>:
Hello:
This patch was applied to chrome-platform/linux.git (for-next) by Thierry Reding <[email protected]>:
Quoted 10 lines · On Fri, 14 Jul 2023 11:48:50 -0600 you wrote:
The DT
of_device.handof_platform.hdate back to the separateof_platform_bus_typebefore it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also includeplatform_device.handof.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.[...]
Here is the summary with links:
- pwm: Explicitly include correct DT includes
https://git.kernel.org/chrome-platform/c/0a41b0c5d97a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html