cpufreq: intel_pstate: Clean up aperf_mperf_shift description
Subsystems (2)
PATCH 1/1 cpufreq: intel_pstate: Clean up aperf_mperf_shift description
From: Rafael J. Wysocki <[email protected]>
The kerneldoc description of the aperf_mperf_shift field in struct global_params is unclear and there is a typo in it, so simplify it and clean it up.
Reported-by Lee Jones <[email protected]>
Signed-off-by Rafael J. Wysocki <[email protected]>
--- drivers/cpufreq/intel_pstate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/cpufreq/intel_pstate.c +1 -3
@@ -202,9 +202,7 @@ struct global_params {* @pstate: Stores P state limits for this CPU * @vid: Stores VID limits for this CPU * @last_sample_time: Last Sample time -* @aperf_mperf_shift: Number of clock cycles after aperf, merf is incremented -* This shift is a multiplier to mperf delta to -* calculate CPU busy. +* @aperf_mperf_shift: APERF vs MPERF counting frequency difference * @prev_aperf: Last APERF value read from APERF MSR * @prev_mperf: Last MPERF value read from MPERF MSR * @prev_tsc: Last timestamp counter (TSC) value
Quoted 17 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The kerneldoc description of the
aperf_mperf_shiftfield in structglobal_paramsis unclear and there is a typo in it, so simplify it and clean it up.Reported-by Lee Jones <[email protected]>Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/cpufreq/intel_pstate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)Index:
linux-pm/drivers/cpufreq/intel_pstate.c
===================================================================
drivers/cpufreq/intel_pstate.c struct global_params { · line 208
Quoted 10 lines
drivers/cpufreq/intel_pstate.c +1
-3@@ -202,9 +202,7 @@ struct global_params {* @pstate: Stores P state limits for this CPU * @vid: Stores VID limits for this CPU * @last_sample_time: Last Sample time -* @aperf_mperf_shift: Number of clock cycles after aperf, merf is incremented -* This shift is a multiplier to mperf delta to -* calculate CPU busy. +* @aperf_mperf_shift: APERF vs MPERF counting frequency difference * @prev_aperf: Last APERF value read from APERF MSR * @prev_mperf: Last MPERF value read from MPERF MSR * @prev_tsc: Last timestamp counter (TSC) value
Definitely clearer.
Reviewed-by Lee Jones <[email protected]>
Signature · 4 lines
Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog