Skip to contentSkip to conversation

net: lan743x: also select PHYLIB

PATCH Applied Randy Dunlap 3 participants 3 messages Oct 2, 2023 – Oct 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: lan743x: also select PHYLIB

Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid a kconfig warning:

WARNING: unmet direct dependencies detected for FIXED_PHY
Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
Selected by [y]:
- LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]

Fixes 73c4d1b307ae ("net: lan743x: select FIXED_PHY")
Closes lore.kernel.org/r/[email protected]
Cc Bryan Whitehead <[email protected]>
Cc Simon Horman <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Paolo Abeni <[email protected]>

---
v2: Also Cc: netdev and Microchip people;

 drivers/net/ethernet/microchip/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/microchip/Kconfig +1 -0
diff -- a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
@@ -46,6 +46,7 @@ config LAN743X
 	tristate "LAN743x support"
 	depends on PCI
 	depends on PTP_1588_CLOCK_OPTIONAL
+	select PHYLIB
 	select FIXED_PHY
 	select CRC16
 	select CRC32
reviewer Reviewed-by Tested-by on v2 1/1
#1 lore raw
Quoted 8 lines · Randy Dunlap

Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid a kconfig warning:

WARNING: unmet direct dependencies detected for FIXED_PHY
Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
Selected by [y]:
- LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]

Quoted 4 lines
Fixes 73c4d1b307ae ("net: lan743x: select FIXED_PHY")
Closes lore.kernel.org/r/[email protected]
#2 lore raw
In reply to Randy Dunlap
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 2 Oct 2023 12:35:44 -0700 you wrote:

Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid a kconfig warning:

WARNING: unmet direct dependencies detected for FIXED_PHY
Depends on [n]: NETDEVICES [=y] && PHYLIB [=n]
Selected by [y]:
- LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y]

[...]

Here is the summary with links:
- [v2] net: lan743x: also select PHYLIB

    https://git.kernel.org/netdev/net/c/566aeed6871a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html