Skip to contentSkip to conversation

Remove last acpi procfs dirs after being marked deprecated for a decade

PATCH Thomas Renninger 3 participants 5 messages May 27, 2020 – Jun 22, 2020 ACPI

lore
Share & tools
lore
#0 lore raw

Kernel development should not be hindered anymore by this absolutely outdated stuff.

CC Sorin Manolache <[email protected]>
CC Lan Tianyu <[email protected]>
CC Rafael J. Wysocki <[email protected]>
CC Zhang Rui <[email protected]>
drivers/acpi/Kconfig +0 -17
index ce2730d61a8f..db3c45305414 100644
@@ -99,23 +99,6 @@ config ACPI_SLEEP
 	depends on ACPI_SYSTEM_POWER_STATES_SUPPORT
 	default y
 
-config ACPI_PROCFS_POWER
-	bool "Deprecated power /proc/acpi directories"
-	depends on X86 && PROC_FS
-	help
-	  For backwards compatibility, this option allows
-	  deprecated power /proc/acpi/ directories to exist, even when
-	  they have been replaced by functions in /sys.
-	  The deprecated directories (and their replacements) include:
-	  /proc/acpi/battery/* (/sys/class/power_supply/*) and
-	  /proc/acpi/ac_adapter/* (sys/class/power_supply/*).
-	  This option has no effect on /proc/acpi/ directories
-	  and functions which do not yet exist in /sys.
-	  This option, together with the proc directories, will be
-	  deleted in the future.
-
-	  Say N to delete power /proc/acpi/ directories that have moved to /sys.
-
 config ACPI_REV_OVERRIDE_POSSIBLE
 	bool "Allow supported ACPI revision to be overridden"
 	depends on X86
drivers/acpi/Makefile +0 -1
index e81e1ebbfb32..9a957544e357 100644
@@ -55,7 +55,6 @@ acpi-$(CONFIG_X86)		+= acpi_cmos_rtc.o
 acpi-$(CONFIG_X86)		+= x86/apple.o
 acpi-$(CONFIG_X86)		+= x86/utils.o
 acpi-$(CONFIG_DEBUG_FS)		+= debugfs.o
-acpi-$(CONFIG_ACPI_PROCFS_POWER) += cm_sbs.o
 acpi-y				+= acpi_lpat.o
 acpi-$(CONFIG_ACPI_LPIT)	+= acpi_lpit.o
 acpi-$(CONFIG_ACPI_GENERIC_GSI) += irq.o
drivers/acpi/ac.c +0 -106

156 lines not on this page · raw message

drivers/acpi/battery.c +0 -255

298 lines not on this page · raw message

drivers/acpi/cm_sbs.c deleted +0 -87

87 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Thomas Renninger

Kernel development should not be hindered anymore by this absolutely outdated stuff.

Well, this is a bit vague.

I'm not against making this change, but why do it now? Is there anything in particular that cannot be done without it?

Thanks!

#2 lore raw

Am Mittwoch, 27. Mai 2020, 17:49:09 CEST schrieb Rafael J. Wysocki:

Quoted 8 lines · Thomas Renninger
Quoted 2 lines

Kernel development should not be hindered anymore by this absolutely outdated stuff.

Well, this is a bit vague.

I'm not against making this change, but why do it now? Is there anything in particular that cannot be done without it?

Because of the deprecated message being shown on laptops booting with the option enabled. I got a bugreport about it recently.

I could not please check_patch to properly include this commit id (recon the double quotes in the title):

e63f6e28dda6de3de2392ddca321e211fd860925
Date: Mon Jul 7 01:13:46 2014 +0200

Revert "ACPI / AC: Remove AC's proc directory."

Revert commit ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.), because some old tools (e.g. kpowersave from kde 3.5.10) are still using /proc/acpi/ac_adapter.

Fixes ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.)

kpowersave was written by myself and I can say for sure, that this stuff is more than outdated.

Thanks,

Thomas

#3 lore raw
Quoted 26 lines · Thomas Renninger

Am Mittwoch, 27. Mai 2020, 17:49:09 CEST schrieb Rafael J. Wysocki:

Quoted 8 lines · Thomas Renninger
Quoted 2 lines

Kernel development should not be hindered anymore by this absolutely outdated stuff.

Well, this is a bit vague.

I'm not against making this change, but why do it now? Is there anything in particular that cannot be done without it?

Because of the deprecated message being shown on laptops booting with the option enabled. I got a bugreport about it recently.

I could not please check_patch to properly include this commit id (recon the double quotes in the title):

e63f6e28dda6de3de2392ddca321e211fd860925
Date: Mon Jul 7 01:13:46 2014 +0200

Revert "ACPI / AC: Remove AC's proc directory."

Revert commit ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.), because some old tools (e.g. kpowersave from kde 3.5.10) are still using /proc/acpi/ac_adapter.

Quoted 5 lines
Fixes ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.)

kpowersave was written by myself and I can say for sure, that this stuff is more than outdated.

Fair enough, but I'd rather stage it for 5.9 to give it a full cycle of baking in linux-next.

Thanks!

#4 lore raw
Quoted 27 lines · CEST Rafael J. Wysocki
Quoted 26 lines · Thomas Renninger

Am Mittwoch, 27. Mai 2020, 17:49:09 CEST schrieb Rafael J. Wysocki:

Quoted 8 lines · Thomas Renninger
Quoted 2 lines

Kernel development should not be hindered anymore by this absolutely outdated stuff.

Well, this is a bit vague.

I'm not against making this change, but why do it now? Is there anything in particular that cannot be done without it?

Because of the deprecated message being shown on laptops booting with the option enabled. I got a bugreport about it recently.

I could not please check_patch to properly include this commit id (recon the double quotes in the title):

e63f6e28dda6de3de2392ddca321e211fd860925
Date: Mon Jul 7 01:13:46 2014 +0200

Revert "ACPI / AC: Remove AC's proc directory."

Revert commit ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.), because some old tools (e.g. kpowersave from kde 3.5.10) are still using /proc/acpi/ac_adapter.

Quoted 8 lines
Quoted 5 lines
Fixes ab0fd674d6ce (ACPI / AC: Remove AC's proc directory.)

kpowersave was written by myself and I can say for sure, that this stuff is more than outdated.

Fair enough, but I'd rather stage it for 5.9 to give it a full cycle of baking in linux-next.

And so applied now as 5.9 material, thanks!