Skip to contentSkip to conversation

:/proc/fs/nfsd/

PATCH Petr Vandrovec 2 participants 2 messages Mar 5, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · Neil Brown
Quoted 1 line

The following patch fixes it.

Does it need fixing??

If you remove this, then people who compile a kernel without nfsd support, and then later decide to compile an nfsd module and load it, will not be able to mount the nfsd filesystem at the right place.

I think it is a very small cost, and a measurable gain, to leave it there.

Maybe I'm stupid, but why cannot knfsd module create fs/nfsd directory at module load? That way you can do insmod/modprobe followed by mount() to do that. And if you'll fiddle with do_mount a bit (so that get_fs_type() is invoked before walking mount path) you can do it even without modprobing knfsd in advance, by just doing 'mount none /proc/fs/nfsd -t nfsd'.
Petr Vandrovec

#1 lore raw
Quoted 12 lines · On Friday March 5, [email protected] wrote:
Quoted 10 lines · Neil Brown
Quoted 1 line

The following patch fixes it.

Does it need fixing??

If you remove this, then people who compile a kernel without nfsd support, and then later decide to compile an nfsd module and load it, will not be able to mount the nfsd filesystem at the right place.

I think it is a very small cost, and a measurable gain, to leave it there.

Quoted 7 lines

Maybe I'm stupid, but why cannot knfsd module create fs/nfsd directory at module load? That way you can do insmod/modprobe followed by mount() to do that. And if you'll fiddle with do_mount a bit (so that get_fs_type() is invoked before walking mount path) you can do it even without modprobing knfsd in advance, by just doing 'mount none /proc/fs/nfsd -t nfsd'.
Petr Vandrovec

I wanted
mount -t nfsd nfsd /proc/fs/nfsd
to load the module and, as you have noticed, that doesn't work.

"fiddle"ing with do_mount is an interesting idea. If you (or someone) can make that work and get it accepted, I am happy to have the nfsd module create the directory.

NeilBrown