Skip to contentSkip to conversation

net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

PATCH Applied Heiner Kallweit 5 participants 6 messages Apr 3, 2023 – Apr 5, 2023

Subsystems (4)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

Enable EDPD PHY tunable support for the G12A internal PHY, reusing the recently added tunable support in the smsc driver.

---
 drivers/net/phy/meson-gxl.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/phy/meson-gxl.c +4 -0
index 3dea7c752..bb9b33b6b 100644
@@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
 		.read_status	= lan87xx_read_status,
 		.config_intr	= smsc_phy_config_intr,
 		.handle_interrupt = smsc_phy_handle_interrupt,
+
+		.get_tunable	= smsc_phy_get_tunable,
+		.set_tunable	= smsc_phy_set_tunable,
+
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
 		.read_mmd	= genphy_read_mmd_unsupported,
Signature · 1 line
2.40.0
#2 lore raw
In reply to Heiner Kallweit
Quoted 14 lines · Heiner Kallweit

Enable EDPD PHY tunable support for the G12A internal PHY, reusing the recently added tunable support in the smsc driver.

---
 drivers/net/phy/meson-gxl.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/phy/meson-gxl.c +0 -0
index 3dea7c752..bb9b33b6b 100644

drivers/net/phy/meson-gxl.c static struct phy_driver meson_gxl_phy[] = { · line 217

Quoted 8 lines
drivers/net/phy/meson-gxl.c +4 -0
@@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
                .read_status    = lan87xx_read_status,
                .config_intr    = smsc_phy_config_intr,
                .handle_interrupt = smsc_phy_handle_interrupt,
+
+               .get_tunable    = smsc_phy_get_tunable,
+               .set_tunable    = smsc_phy_set_tunable,
+
                .suspend        = genphy_suspend,

Why add the empty lines before and after the two new lines?

Quoted 5 lines
drivers/net/phy/meson-gxl.c +0 -1
                .resume         = genphy_resume,
                .read_mmd       = genphy_read_mmd_unsupported,
--

2.40.0

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

author maintainer
#3 lore raw
Quoted 10 lines · Chris Healy
Quoted 9 lines · Heiner Kallweit

Enable EDPD PHY tunable support for the G12A internal PHY, reusing the recently added tunable support in the smsc driver.

---
 drivers/net/phy/meson-gxl.c | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 15 lines

drivers/net/phy/meson-gxl.c static struct phy_driver meson_gxl_phy[] = { · line 217

Quoted 13 lines
drivers/net/phy/meson-gxl.c +4 -0
index 3dea7c752..bb9b33b6b 100644
@@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
                .read_status    = lan87xx_read_status,
                .config_intr    = smsc_phy_config_intr,
                .handle_interrupt = smsc_phy_handle_interrupt,
+
+               .get_tunable    = smsc_phy_get_tunable,
+               .set_tunable    = smsc_phy_set_tunable,
+
                .suspend        = genphy_suspend,

Why add the empty lines before and after the two new lines?

Just for readability, because these two entries belong together. Sometimes it's a little hard to read if drivers have 10+ callbacks in a flat list in different, arbitrary order.

Quoted 5 lines
Quoted 5 lines
drivers/net/phy/meson-gxl.c +0 -1
                .resume         = genphy_resume,
                .read_mmd       = genphy_read_mmd_unsupported,
--

2.40.0

#5 lore raw
In reply to Heiner Kallweit
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Mon, 3 Apr 2023 21:35:46 +0200 you wrote:

Enable EDPD PHY tunable support for the G12A internal PHY, reusing the recently added tunable support in the smsc driver.

---
 drivers/net/phy/meson-gxl.c | 4 ++++
 1 file changed, 4 insertions(+)

Here is the summary with links:
- [net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

    https://git.kernel.org/netdev/net-next/c/992e76908e92

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html