Skip to contentSkip to conversation

lame: Remove hardcoded rpaths

PATCH In review Paulo Neves 3 participants 4 messages Jul 26, 2022 – Nov 3, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lame: Remove hardcoded rpaths

Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]

---
 meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/lame/lame_3.100.bb +4 -0
index 5b42795f4e..2d9bd9d29f 100644
@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame"
 FILES:libmp3lame = "${libdir}/libmp3lame.so.*"
 FILES:libmp3lame-dev = "${includedir} ${libdir}/*"
 FILES:${PN}-dev = ""
+do_compile:prepend() {
+    # Stop libtool adding RPATHs
+    sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool
+}
Signature · 1 line
2.25.1
#1 lore raw
Quoted 14 lines · Paulo Neves

Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]

---
 meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/lame/lame_3.100.bb +0 -0
index 5b42795f4e..2d9bd9d29f 100644

meta/recipes-multimedia/lame/lame_3.100.bb FILES:${PN} = "${bindir}/lame" · line 30

Quoted 7 lines
meta/recipes-multimedia/lame/lame_3.100.bb +4 -0
@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame"
 FILES:libmp3lame = "${libdir}/libmp3lame.so.*"
 FILES:libmp3lame-dev = "${includedir} ${libdir}/*"
 FILES:${PN}-dev = ""
+do_compile:prepend() {
+    # Stop libtool adding RPATHs
+    sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool
+}

Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?

Cheers,

Richard

#2 lore raw

I thought of that myself, but did not yet investigate. We have hardcode_into_libs disabling in 4 "recipes":

git grep hardcode_into_libs -- meta
recipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: hardcode_into_libs=yes recipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: if test "$hardcode_into_libs" != yes || test "$build_old_libs" = yes; then recipes-devtools/gcc/gcc-sanitizers.inc:    sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/libsanitizer/libtool recipes-devtools/gcc/gcc-source.inc:    cmd = d.expand("sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${S}/libcc1/configure") recipes-devtools/gcc/libgfortran.inc:              sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/$target/libtool recipes-support/db/db_5.3.28.bb:    sed -i -e 's|hardcode_into_libs=yes|hardcode_into_libs=no|' ${B}/libtool

The hardcode_into_libs=no did not fix things for the lame case. We have a patch for libtools that looks like could be the culprit and need tightening [1]

[1] recipes-devtools/libtool/libtool/0004-ltmain.sh-Fix-sysroot-paths-being-encoded-into-RPATH.patch

Paulo Neves

Quoted 29 lines · Richard Purdie
Quoted 14 lines · Paulo Neves

Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]

---
  meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++
  1 file changed, 4 insertions(+)
meta/recipes-multimedia/lame/lame_3.100.bb +0 -0
index 5b42795f4e..2d9bd9d29f 100644

meta/recipes-multimedia/lame/lame_3.100.bb FILES:${PN} = "${bindir}/lame" · line 30

Quoted 7 lines
meta/recipes-multimedia/lame/lame_3.100.bb +4 -0
@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame"
  FILES:libmp3lame = "${libdir}/libmp3lame.so.*"
  FILES:libmp3lame-dev = "${includedir} ${libdir}/*"
  FILES:${PN}-dev = ""
+do_compile:prepend() {
+    # Stop libtool adding RPATHs
+    sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool
+}

Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?

Cheers,

Richard

#3 lore raw
Quoted 10 lines · Paulo Neves

I thought of that myself, but did not yet investigate. We have hardcode_into_libs disabling in 4 "recipes":

git grep hardcode_into_libs -- meta
recipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: hardcode_into_libs=yes recipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: if test "$hardcode_into_libs" != yes || test "$build_old_libs" = yes; then recipes-devtools/gcc/gcc-sanitizers.inc:    sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/libsanitizer/libtool recipes-devtools/gcc/gcc-source.inc:    cmd = d.expand("sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${S}/libcc1/configure") recipes-devtools/gcc/libgfortran.inc:              sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/$target/libtool recipes-support/db/db_5.3.28.bb:    sed -i -e 's|hardcode_into_libs=yes|hardcode_into_libs=no|' ${B}/libtool

Quoted 4 lines

The hardcode_into_libs=no did not fix things for the lame case. We have a patch for libtools that looks like could be the culprit and need tightening [1]

[1] recipes-devtools/libtool/libtool/0004-ltmain.sh-Fix-sysroot-paths-being-encoded-into-RPATH.patch

Paulo,

Can you summarize where we are with this bug. Richard thinks that there has been some progres...

We were reviewing it during the YP bugboard.
I've put the bug in NEEDINFO.

Thanks,

../Randy

Quoted 44 lines

Paulo Neves

Quoted 27 lines · Richard Purdie
Quoted 14 lines · Paulo Neves

Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]

---
  meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++

  1 file changed, 4 insertions(+)
meta/recipes-multimedia/lame/lame_3.100.bb +0 -0
index 5b42795f4e..2d9bd9d29f 100644
@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame"
Quoted 8 lines

  FILES:libmp3lame = "${libdir}/libmp3lame.so.*" FILES:libmp3lame-dev = "${includedir} ${libdir}/*" FILES:${PN}-dev = ""
+do_compile:prepend() {
+    # Stop libtool adding RPATHs
+    sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool +}

Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?

Quoted 3 lines

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168549): https://lists.openembedded.org/g/openembedded-core/message/168549
Mute This Topic: https://lists.openembedded.org/mt/92636379/3616765
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
# Randy MacLeod
# Wind River Linux