lame: Remove hardcoded rpaths
PATCH 1/1 lame: Remove hardcoded rpaths
Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]
--- meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-multimedia/lame/lame_3.100.bb +4 -0
@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame" FILES:libmp3lame = "${libdir}/libmp3lame.so.*" FILES:libmp3lame-dev = "${includedir} ${libdir}/*" FILES:${PN}-dev = "" +do_compile:prepend() { + # Stop libtool adding RPATHs + sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool +}
Signature · 1 line
2.25.1
Quoted 14 lines · Paulo Neves
Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]
Signed-off-by Paulo Neves <[email protected]>--- meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++ 1 file changed, 4 insertions(+)meta/recipes-multimedia/lame/lame_3.100.bb +0
-0
meta/recipes-multimedia/lame/lame_3.100.bb FILES:${PN} = "${bindir}/lame" · line 30
Quoted 7 lines
meta/recipes-multimedia/lame/lame_3.100.bb +4
-0@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame" FILES:libmp3lame = "${libdir}/libmp3lame.so.*" FILES:libmp3lame-dev = "${includedir} ${libdir}/*" FILES:${PN}-dev = "" +do_compile:prepend() { + # Stop libtool adding RPATHs + sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool +}
Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?
Cheers,
Richard
I thought of that myself, but did not yet investigate. We have hardcode_into_libs disabling in 4 "recipes":
git grep hardcode_into_libs -- metarecipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: hardcode_into_libs=yes recipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: if test "$hardcode_into_libs" != yes || test "$build_old_libs" = yes; then recipes-devtools/gcc/gcc-sanitizers.inc: sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/libsanitizer/libtool recipes-devtools/gcc/gcc-source.inc: cmd = d.expand("sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${S}/libcc1/configure") recipes-devtools/gcc/libgfortran.inc: sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/$target/libtool recipes-support/db/db_5.3.28.bb: sed -i -e 's|hardcode_into_libs=yes|hardcode_into_libs=no|' ${B}/libtool
The hardcode_into_libs=no did not fix things for the lame case. We have a patch for libtools that looks like could be the culprit and need tightening [1]
[1] recipes-devtools/libtool/libtool/0004-ltmain.sh-Fix-sysroot-paths-being-encoded-into-RPATH.patch
Paulo Neves
Quoted 29 lines · Richard Purdie
Quoted 14 lines · Paulo Neves
Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]
Signed-off-by Paulo Neves <[email protected]>--- meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++ 1 file changed, 4 insertions(+)meta/recipes-multimedia/lame/lame_3.100.bb +0
-0meta/recipes-multimedia/lame/lame_3.100.bb FILES:${PN} = "${bindir}/lame" · line 30
Quoted 7 lines
meta/recipes-multimedia/lame/lame_3.100.bb +4
-0@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame" FILES:libmp3lame = "${libdir}/libmp3lame.so.*" FILES:libmp3lame-dev = "${includedir} ${libdir}/*" FILES:${PN}-dev = "" +do_compile:prepend() { + # Stop libtool adding RPATHs + sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool +}Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?
Cheers,
Richard
Quoted 10 lines · Paulo Neves
I thought of that myself, but did not yet investigate. We have
hardcode_into_libsdisabling in 4 "recipes":git grep
hardcode_into_libs-- metarecipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: hardcode_into_libs=yesrecipes-devtools/binutils/binutils/0009-Use-libtool-2.4.patch: if test "$hardcode_into_libs" != yes || test "$build_old_libs" = yes; then recipes-devtools/gcc/gcc-sanitizers.inc: sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/libsanitizer/libtool recipes-devtools/gcc/gcc-source.inc: cmd =d.expand("sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${S}/libcc1/configure")recipes-devtools/gcc/libgfortran.inc: sed -i -e 's/hardcode_into_libs=yes/hardcode_into_libs=no/' ${B}/${TARGET_SYS}/$target/libtool recipes-support/db/db_5.3.28.bb: sed -i -e 's|hardcode_into_libs=yes|hardcode_into_libs=no|' ${B}/libtool
Quoted 4 lines
The hardcode_into_libs=no did not fix things for the lame case. We have a patch for libtools that looks like could be the culprit and need tightening [1]
[1]
recipes-devtools/libtool/libtool/0004-ltmain.sh-Fix-sysroot-paths-being-encoded-into-RPATH.patch
Paulo,
Can you summarize where we are with this bug. Richard thinks that there has been some progres...
We were reviewing it during the YP bugboard.
I've put the bug in NEEDINFO.
Thanks,
../Randy
Quoted 44 lines
Paulo Neves
Quoted 27 lines · Richard Purdie
Quoted 14 lines · Paulo Neves
Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863]
Signed-off-by Paulo Neves <[email protected]>---
meta/recipes-multimedia/lame/lame_3.100.bb | 4 ++++1 file changed, 4 insertions(+)meta/recipes-multimedia/lame/lame_3.100.bb +0
-0@@ -24,3 +24,7 @@ FILES:${PN} = "${bindir}/lame"Quoted 8 lines
FILES:libmp3lame = "${libdir}/libmp3lame.so.*" FILES:libmp3lame-dev = "${includedir} ${libdir}/*" FILES:${PN}-dev = ""
+do_compile:prepend() {
+ # Stop libtool adding RPATHs
+ sed -i -e 's|hardcode_libdir_flag_spec=".*"|hardcode_libdir_flag_spec=""|' ${B}/libtool +}Any idea why lame has this issue but we don't see it with anything else using libtool? I'm wondering if there is an underlying cause we should look at?
Quoted 3 lines
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168549): https://lists.openembedded.org/g/openembedded-core/message/168549
Mute This Topic: https://lists.openembedded.org/mt/92636379/3616765
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 2 lines
# Randy MacLeod # Wind River Linux